diff options
Diffstat (limited to 'drivers/gpu/drm/i915/intel_guc_log.c')
-rw-r--r-- | drivers/gpu/drm/i915/intel_guc_log.c | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/drivers/gpu/drm/i915/intel_guc_log.c b/drivers/gpu/drm/i915/intel_guc_log.c index 16d3b8719cab..6571d96704ad 100644 --- a/drivers/gpu/drm/i915/intel_guc_log.c +++ b/drivers/gpu/drm/i915/intel_guc_log.c | |||
@@ -144,7 +144,7 @@ static int guc_log_relay_file_create(struct intel_guc *guc) | |||
144 | struct dentry *log_dir; | 144 | struct dentry *log_dir; |
145 | int ret; | 145 | int ret; |
146 | 146 | ||
147 | if (i915.guc_log_level < 0) | 147 | if (i915_modparams.guc_log_level < 0) |
148 | return 0; | 148 | return 0; |
149 | 149 | ||
150 | /* For now create the log file in /sys/kernel/debug/dri/0 dir */ | 150 | /* For now create the log file in /sys/kernel/debug/dri/0 dir */ |
@@ -480,7 +480,7 @@ err_runtime: | |||
480 | guc_log_runtime_destroy(guc); | 480 | guc_log_runtime_destroy(guc); |
481 | err: | 481 | err: |
482 | /* logging will remain off */ | 482 | /* logging will remain off */ |
483 | i915.guc_log_level = -1; | 483 | i915_modparams.guc_log_level = -1; |
484 | return ret; | 484 | return ret; |
485 | } | 485 | } |
486 | 486 | ||
@@ -502,7 +502,8 @@ static void guc_flush_logs(struct intel_guc *guc) | |||
502 | { | 502 | { |
503 | struct drm_i915_private *dev_priv = guc_to_i915(guc); | 503 | struct drm_i915_private *dev_priv = guc_to_i915(guc); |
504 | 504 | ||
505 | if (!i915.enable_guc_submission || (i915.guc_log_level < 0)) | 505 | if (!i915_modparams.enable_guc_submission || |
506 | (i915_modparams.guc_log_level < 0)) | ||
506 | return; | 507 | return; |
507 | 508 | ||
508 | /* First disable the interrupts, will be renabled afterwards */ | 509 | /* First disable the interrupts, will be renabled afterwards */ |
@@ -529,8 +530,8 @@ int intel_guc_log_create(struct intel_guc *guc) | |||
529 | 530 | ||
530 | GEM_BUG_ON(guc->log.vma); | 531 | GEM_BUG_ON(guc->log.vma); |
531 | 532 | ||
532 | if (i915.guc_log_level > GUC_LOG_VERBOSITY_MAX) | 533 | if (i915_modparams.guc_log_level > GUC_LOG_VERBOSITY_MAX) |
533 | i915.guc_log_level = GUC_LOG_VERBOSITY_MAX; | 534 | i915_modparams.guc_log_level = GUC_LOG_VERBOSITY_MAX; |
534 | 535 | ||
535 | /* The first page is to save log buffer state. Allocate one | 536 | /* The first page is to save log buffer state. Allocate one |
536 | * extra page for others in case for overlap */ | 537 | * extra page for others in case for overlap */ |
@@ -555,7 +556,7 @@ int intel_guc_log_create(struct intel_guc *guc) | |||
555 | 556 | ||
556 | guc->log.vma = vma; | 557 | guc->log.vma = vma; |
557 | 558 | ||
558 | if (i915.guc_log_level >= 0) { | 559 | if (i915_modparams.guc_log_level >= 0) { |
559 | ret = guc_log_runtime_create(guc); | 560 | ret = guc_log_runtime_create(guc); |
560 | if (ret < 0) | 561 | if (ret < 0) |
561 | goto err_vma; | 562 | goto err_vma; |
@@ -576,7 +577,7 @@ err_vma: | |||
576 | i915_vma_unpin_and_release(&guc->log.vma); | 577 | i915_vma_unpin_and_release(&guc->log.vma); |
577 | err: | 578 | err: |
578 | /* logging will be off */ | 579 | /* logging will be off */ |
579 | i915.guc_log_level = -1; | 580 | i915_modparams.guc_log_level = -1; |
580 | return ret; | 581 | return ret; |
581 | } | 582 | } |
582 | 583 | ||
@@ -600,7 +601,7 @@ int i915_guc_log_control(struct drm_i915_private *dev_priv, u64 control_val) | |||
600 | return -EINVAL; | 601 | return -EINVAL; |
601 | 602 | ||
602 | /* This combination doesn't make sense & won't have any effect */ | 603 | /* This combination doesn't make sense & won't have any effect */ |
603 | if (!log_param.logging_enabled && (i915.guc_log_level < 0)) | 604 | if (!log_param.logging_enabled && (i915_modparams.guc_log_level < 0)) |
604 | return 0; | 605 | return 0; |
605 | 606 | ||
606 | ret = guc_log_control(guc, log_param.value); | 607 | ret = guc_log_control(guc, log_param.value); |
@@ -610,7 +611,7 @@ int i915_guc_log_control(struct drm_i915_private *dev_priv, u64 control_val) | |||
610 | } | 611 | } |
611 | 612 | ||
612 | if (log_param.logging_enabled) { | 613 | if (log_param.logging_enabled) { |
613 | i915.guc_log_level = log_param.verbosity; | 614 | i915_modparams.guc_log_level = log_param.verbosity; |
614 | 615 | ||
615 | /* If log_level was set as -1 at boot time, then the relay channel file | 616 | /* If log_level was set as -1 at boot time, then the relay channel file |
616 | * wouldn't have been created by now and interrupts also would not have | 617 | * wouldn't have been created by now and interrupts also would not have |
@@ -633,7 +634,7 @@ int i915_guc_log_control(struct drm_i915_private *dev_priv, u64 control_val) | |||
633 | guc_flush_logs(guc); | 634 | guc_flush_logs(guc); |
634 | 635 | ||
635 | /* As logging is disabled, update log level to reflect that */ | 636 | /* As logging is disabled, update log level to reflect that */ |
636 | i915.guc_log_level = -1; | 637 | i915_modparams.guc_log_level = -1; |
637 | } | 638 | } |
638 | 639 | ||
639 | return ret; | 640 | return ret; |
@@ -641,7 +642,8 @@ int i915_guc_log_control(struct drm_i915_private *dev_priv, u64 control_val) | |||
641 | 642 | ||
642 | void i915_guc_log_register(struct drm_i915_private *dev_priv) | 643 | void i915_guc_log_register(struct drm_i915_private *dev_priv) |
643 | { | 644 | { |
644 | if (!i915.enable_guc_submission || i915.guc_log_level < 0) | 645 | if (!i915_modparams.enable_guc_submission || |
646 | (i915_modparams.guc_log_level < 0)) | ||
645 | return; | 647 | return; |
646 | 648 | ||
647 | mutex_lock(&dev_priv->drm.struct_mutex); | 649 | mutex_lock(&dev_priv->drm.struct_mutex); |
@@ -651,7 +653,7 @@ void i915_guc_log_register(struct drm_i915_private *dev_priv) | |||
651 | 653 | ||
652 | void i915_guc_log_unregister(struct drm_i915_private *dev_priv) | 654 | void i915_guc_log_unregister(struct drm_i915_private *dev_priv) |
653 | { | 655 | { |
654 | if (!i915.enable_guc_submission) | 656 | if (!i915_modparams.enable_guc_submission) |
655 | return; | 657 | return; |
656 | 658 | ||
657 | mutex_lock(&dev_priv->drm.struct_mutex); | 659 | mutex_lock(&dev_priv->drm.struct_mutex); |