15 files changed, 282 insertions, 39 deletions

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 2a62b96600ad..abaed4f8bb7f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -2867,16 +2867,11 @@ static int perf_event_modify_breakpoint(struct perf_event *bp,
         _perf_event_disable(bp);
 
         err = modify_user_hw_breakpoint_check(bp, attr, true);
-        if (err) {
-                if (!bp->attr.disabled)
-                        _perf_event_enable(bp);
 
-                return err;
-        }
-
-        if (!attr->disabled)
+        if (!bp->attr.disabled)
                 _perf_event_enable(bp);
-        return 0;
+
+        return err;
 }
 
 static int perf_event_modify_attr(struct perf_event *event,
diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
index b3814fce5ecb..d6b56180827c 100644
--- a/kernel/events/hw_breakpoint.c
+++ b/kernel/events/hw_breakpoint.c
@@ -509,6 +509,8 @@ modify_user_hw_breakpoint_check(struct perf_event *bp, struct perf_event_attr *a
  */
 int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *attr)
 {
+        int err;
+
         /*
          * modify_user_hw_breakpoint can be invoked with IRQs disabled and hence it
          * will not be possible to raise IPIs that invoke __perf_event_disable.
@@ -520,15 +522,12 @@ int modify_user_hw_breakpoint(struct perf_event *bp, struct perf_event_attr *att
         else
                 perf_event_disable(bp);
 
-        if (!attr->disabled) {
-                int err = modify_user_hw_breakpoint_check(bp, attr, false);
+        err = modify_user_hw_breakpoint_check(bp, attr, false);
 
-                if (err)
-                        return err;
+        if (!bp->attr.disabled)
                 perf_event_enable(bp);
-                bp->attr.disabled = 0;
-        }
-        return 0;
+
+        return err;
 }
 EXPORT_SYMBOL_GPL(modify_user_hw_breakpoint);
 
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index b3d1b12a5081..5224ade3d5af 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -777,14 +777,12 @@ endif
         $(call QUIET_INSTALL, libexec) \
                 $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)'
 ifndef NO_LIBBPF
-        $(call QUIET_INSTALL, lib) \
-                $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'
-        $(call QUIET_INSTALL, include/bpf) \
-                $(INSTALL) include/bpf/*.h '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'
-        $(call QUIET_INSTALL, lib) \
-                $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'
-        $(call QUIET_INSTALL, examples/bpf) \
-                $(INSTALL) examples/bpf/*.c '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'
+        $(call QUIET_INSTALL, bpf-headers) \
+                $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'; \
+                $(INSTALL) include/bpf/*.h -t '$(DESTDIR_SQ)$(perf_include_instdir_SQ)/bpf'
+        $(call QUIET_INSTALL, bpf-examples) \
+                $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'; \
+                $(INSTALL) examples/bpf/*.c -t '$(DESTDIR_SQ)$(perf_examples_instdir_SQ)/bpf'
 endif
         $(call QUIET_INSTALL, perf-archive) \
                 $(INSTALL) $(OUTPUT)perf-archive -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)'
diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
index f013b115dc86..dbef716a1913 100644
--- a/tools/perf/arch/arm64/Makefile
+++ b/tools/perf/arch/arm64/Makefile
@@ -11,7 +11,8 @@ PERF_HAVE_ARCH_REGS_QUERY_REGISTER_OFFSET := 1
 
 out    := $(OUTPUT)arch/arm64/include/generated/asm
 header := $(out)/syscalls.c
-sysdef := $(srctree)/tools/include/uapi/asm-generic/unistd.h
+incpath := $(srctree)/tools
+sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
 sysprf := $(srctree)/tools/perf/arch/arm64/entry/syscalls/
 systbl := $(sysprf)/mksyscalltbl
 
@@ -19,7 +20,7 @@ systbl := $(sysprf)/mksyscalltbl
 _dummy := $(shell [ -d '$(out)' ] || mkdir -p '$(out)')
 
 $(header): $(sysdef) $(systbl)
-        $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(sysdef) > $@
+        $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
 
 clean::
         $(call QUIET_CLEAN, arm64) $(RM) $(header)
diff --git a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
index 52e197317d3e..2dbb8cade048 100755
--- a/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
+++ b/tools/perf/arch/arm64/entry/syscalls/mksyscalltbl
@@ -11,7 +11,8 @@
 
 gcc=$1
 hostcc=$2
-input=$3
+incpath=$3
+input=$4
 
 if ! test -r $input; then
         echo "Could not read input file" >&2
@@ -28,7 +29,6 @@ create_table_from_c()
 
         cat <<-_EoHEADER
                 #include <stdio.h>
-                #define __ARCH_WANT_RENAMEAT
                 #include "$input"
                 int main(int argc, char *argv[])
                 {
@@ -42,7 +42,7 @@ create_table_from_c()
         printf "%s\n" " printf(\"#define SYSCALLTBL_ARM64_MAX_ID %d\\n\", __NR_$last_sc);"
         printf "}\n"
 
-        } | $hostcc -o $create_table_exe -x c -
+        } | $hostcc -I $incpath/include/uapi -o $create_table_exe -x c -
 
         $create_table_exe
 
diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c
index 20e7d74d86cd..10a44e946f77 100644
--- a/tools/perf/arch/powerpc/util/sym-handling.c
+++ b/tools/perf/arch/powerpc/util/sym-handling.c
@@ -22,15 +22,16 @@ bool elf__needs_adjust_symbols(GElf_Ehdr ehdr)
 
 #endif
 
-#if !defined(_CALL_ELF) || _CALL_ELF != 2
 int arch__choose_best_symbol(struct symbol *syma,
                              struct symbol *symb __maybe_unused)
 {
         char *sym = syma->name;
 
+#if !defined(_CALL_ELF) || _CALL_ELF != 2
         /* Skip over any initial dot */
         if (*sym == '.')
                 sym++;
+#endif
 
         /* Avoid "SyS" kernel syscall aliases */
         if (strlen(sym) >= 3 && !strncmp(sym, "SyS", 3))
@@ -41,6 +42,7 @@ int arch__choose_best_symbol(struct symbol *syma,
         return SYMBOL_A;
 }
 
+#if !defined(_CALL_ELF) || _CALL_ELF != 2
 /* Allow matching against dot variants */
 int arch__compare_symbol_names(const char *namea, const char *nameb)
 {
diff --git a/tools/perf/arch/x86/include/arch-tests.h b/tools/perf/arch/x86/include/arch-tests.h
index c1bd979b957b..613709cfbbd0 100644
--- a/tools/perf/arch/x86/include/arch-tests.h
+++ b/tools/perf/arch/x86/include/arch-tests.h
@@ -9,6 +9,7 @@ struct test;
 int test__rdpmc(struct test *test __maybe_unused, int subtest);
 int test__perf_time_to_tsc(struct test *test __maybe_unused, int subtest);
 int test__insn_x86(struct test *test __maybe_unused, int subtest);
+int test__bp_modify(struct test *test, int subtest);
 
 #ifdef HAVE_DWARF_UNWIND_SUPPORT
 struct thread;
diff --git a/tools/perf/arch/x86/tests/Build b/tools/perf/arch/x86/tests/Build
index 8e2c5a38c3b9..586849ff83a0 100644
--- a/tools/perf/arch/x86/tests/Build
+++ b/tools/perf/arch/x86/tests/Build
@@ -5,3 +5,4 @@ libperf-y += arch-tests.o
 libperf-y += rdpmc.o
 libperf-y += perf-time-to-tsc.o
 libperf-$(CONFIG_AUXTRACE) += insn-x86.o
+libperf-$(CONFIG_X86_64) += bp-modify.o
diff --git a/tools/perf/arch/x86/tests/arch-tests.c b/tools/perf/arch/x86/tests/arch-tests.c
index cc1802ff5410..d47d3f8e3c8e 100644
--- a/tools/perf/arch/x86/tests/arch-tests.c
+++ b/tools/perf/arch/x86/tests/arch-tests.c
@@ -24,6 +24,12 @@ struct test arch_tests[] = {
                 .func = test__insn_x86,
         },
 #endif
+#if defined(__x86_64__)
+        {
+                .desc = "x86 bp modify",
+                .func = test__bp_modify,
+        },
+#endif
         {
                 .func = NULL,
         },
diff --git a/tools/perf/arch/x86/tests/bp-modify.c b/tools/perf/arch/x86/tests/bp-modify.c
new file mode 100644
index 000000000000..f53e4406709f
--- /dev/null
+++ b/tools/perf/arch/x86/tests/bp-modify.c
@@ -0,0 +1,213 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <linux/compiler.h>
+#include <sys/types.h>
+#include <sys/wait.h>
+#include <sys/user.h>
+#include <syscall.h>
+#include <unistd.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <sys/ptrace.h>
+#include <asm/ptrace.h>
+#include <errno.h>
+#include "debug.h"
+#include "tests/tests.h"
+#include "arch-tests.h"
+
+static noinline int bp_1(void)
+{
+        pr_debug("in %s\n", __func__);
+        return 0;
+}
+
+static noinline int bp_2(void)
+{
+        pr_debug("in %s\n", __func__);
+        return 0;
+}
+
+static int spawn_child(void)
+{
+        int child = fork();
+
+        if (child == 0) {
+                /*
+                 * The child sets itself for as tracee and
+                 * waits in signal for parent to trace it,
+                 * then it calls bp_1 and quits.
+                 */
+                int err = ptrace(PTRACE_TRACEME, 0, NULL, NULL);
+
+                if (err) {
+                        pr_debug("failed to PTRACE_TRACEME\n");
+                        exit(1);
+                }
+
+                raise(SIGCONT);
+                bp_1();
+                exit(0);
+        }
+
+        return child;
+}
+
+/*
+ * This tests creates HW breakpoint, tries to
+ * change it and checks it was properly changed.
+ */
+static int bp_modify1(void)
+{
+        pid_t child;
+        int status;
+        unsigned long rip = 0, dr7 = 1;
+
+        child = spawn_child();
+
+        waitpid(child, &status, 0);
+        if (WIFEXITED(status)) {
+                pr_debug("tracee exited prematurely 1\n");
+                return TEST_FAIL;
+        }
+
+        /*
+         * The parent does following steps:
+         *  - creates a new breakpoint (id 0) for bp_2 function
+         *  - changes that breakponit to bp_1 function
+         *  - waits for the breakpoint to hit and checks
+         *    it has proper rip of bp_1 function
+         *  - detaches the child
+         */
+        if (ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[0]), bp_2)) {
+                pr_debug("failed to set breakpoint, 1st time: %s\n",
+                         strerror(errno));
+                goto out;
+        }
+
+        if (ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[0]), bp_1)) {
+                pr_debug("failed to set breakpoint, 2nd time: %s\n",
+                         strerror(errno));
+                goto out;
+        }
+
+        if (ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[7]), dr7)) {
+                pr_debug("failed to set dr7: %s\n", strerror(errno));
+                goto out;
+        }
+
+        if (ptrace(PTRACE_CONT, child, NULL, NULL)) {
+                pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));
+                goto out;
+        }
+
+        waitpid(child, &status, 0);
+        if (WIFEXITED(status)) {
+                pr_debug("tracee exited prematurely 2\n");
+                return TEST_FAIL;
+        }
+
+        rip = ptrace(PTRACE_PEEKUSER, child,
+                     offsetof(struct user_regs_struct, rip), NULL);
+        if (rip == (unsigned long) -1) {
+                pr_debug("failed to PTRACE_PEEKUSER: %s\n",
+                         strerror(errno));
+                goto out;
+        }
+
+        pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);
+
+out:
+        if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {
+                pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));
+                return TEST_FAIL;
+        }
+
+        return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;
+}
+
+/*
+ * This tests creates HW breakpoint, tries to
+ * change it to bogus value and checks the original
+ * breakpoint is hit.
+ */
+static int bp_modify2(void)
+{
+        pid_t child;
+        int status;
+        unsigned long rip = 0, dr7 = 1;
+
+        child = spawn_child();
+
+        waitpid(child, &status, 0);
+        if (WIFEXITED(status)) {
+                pr_debug("tracee exited prematurely 1\n");
+                return TEST_FAIL;
+        }
+
+        /*
+         * The parent does following steps:
+         *  - creates a new breakpoint (id 0) for bp_1 function
+         *  - tries to change that breakpoint to (-1) address
+         *  - waits for the breakpoint to hit and checks
+         *    it has proper rip of bp_1 function
+         *  - detaches the child
+         */
+        if (ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[0]), bp_1)) {
+                pr_debug("failed to set breakpoint: %s\n",
+                         strerror(errno));
+                goto out;
+        }
+
+        if (ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[7]), dr7)) {
+                pr_debug("failed to set dr7: %s\n", strerror(errno));
+                goto out;
+        }
+
+        if (!ptrace(PTRACE_POKEUSER, child,
+                   offsetof(struct user, u_debugreg[0]), (unsigned long) (-1))) {
+                pr_debug("failed, breakpoint set to bogus address\n");
+                goto out;
+        }
+
+        if (ptrace(PTRACE_CONT, child, NULL, NULL)) {
+                pr_debug("failed to PTRACE_CONT: %s\n", strerror(errno));
+                goto out;
+        }
+
+        waitpid(child, &status, 0);
+        if (WIFEXITED(status)) {
+                pr_debug("tracee exited prematurely 2\n");
+                return TEST_FAIL;
+        }
+
+        rip = ptrace(PTRACE_PEEKUSER, child,
+                     offsetof(struct user_regs_struct, rip), NULL);
+        if (rip == (unsigned long) -1) {
+                pr_debug("failed to PTRACE_PEEKUSER: %s\n",
+                         strerror(errno));
+                goto out;
+        }
+
+        pr_debug("rip %lx, bp_1 %p\n", rip, bp_1);
+
+out:
+        if (ptrace(PTRACE_DETACH, child, NULL, NULL)) {
+                pr_debug("failed to PTRACE_DETACH: %s", strerror(errno));
+                return TEST_FAIL;
+        }
+
+        return rip == (unsigned long) bp_1 ? TEST_OK : TEST_FAIL;
+}
+
+int test__bp_modify(struct test *test __maybe_unused,
+                    int subtest __maybe_unused)
+{
+        TEST_ASSERT_VAL("modify test 1 failed\n", !bp_modify1());
+        TEST_ASSERT_VAL("modify test 2 failed\n", !bp_modify2());
+
+        return 0;
+}
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 20061cf42288..28cd6a17491b 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -246,8 +246,14 @@ find_target:
 
 indirect_call:
         tok = strchr(endptr, '*');
-        if (tok != NULL)
-                ops->target.addr = strtoull(tok + 1, NULL, 16);
+        if (tok != NULL) {
+                endptr++;
+
+                /* Indirect call can use a non-rip register and offset: callq  *0x8(%rbx).
+                 * Do not parse such instruction.  */
+                if (strstr(endptr, "(%r") == NULL)
+                        ops->target.addr = strtoull(endptr, NULL, 16);
+        }
         goto find_target;
 }
 
@@ -276,7 +282,19 @@ bool ins__is_call(const struct ins *ins)
         return ins->ops == &call_ops || ins->ops == &s390_call_ops;
 }
 
-static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map_symbol *ms)
+/*
+ * Prevents from matching commas in the comment section, e.g.:
+ * ffff200008446e70:       b.cs    ffff2000084470f4 <generic_exec_single+0x314>  // b.hs, b.nlast
+ */
+static inline const char *validate_comma(const char *c, struct ins_operands *ops)
+{
+        if (ops->raw_comment && c > ops->raw_comment)
+                return NULL;
+
+        return c;
+}
+
+static int jump__parse(struct arch *arch, struct ins_operands *ops, struct map_symbol *ms)
 {
         struct map *map = ms->map;
         struct symbol *sym = ms->sym;
@@ -285,6 +303,10 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
         };
         const char *c = strchr(ops->raw, ',');
         u64 start, end;
+
+        ops->raw_comment = strchr(ops->raw, arch->objdump.comment_char);
+        c = validate_comma(c, ops);
+
         /*
          * Examples of lines to parse for the _cpp_lex_token@@Base
          * function:
@@ -304,6 +326,7 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op
                 ops->target.addr = strtoull(c, NULL, 16);
                 if (!ops->target.addr) {
                         c = strchr(c, ',');
+                        c = validate_comma(c, ops);
                         if (c++ != NULL)
                                 ops->target.addr = strtoull(c, NULL, 16);
                 }
@@ -361,9 +384,12 @@ static int jump__scnprintf(struct ins *ins, char *bf, size_t size,
                 return scnprintf(bf, size, "%-6s %s", ins->name, ops->target.sym->name);
 
         c = strchr(ops->raw, ',');
+        c = validate_comma(c, ops);
+
         if (c != NULL) {
                 const char *c2 = strchr(c + 1, ',');
 
+                c2 = validate_comma(c2, ops);
                 /* check for 3-op insn */
                 if (c2 != NULL)
                         c = c2;
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index 005a5fe8a8c6..5399ba2321bb 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -22,6 +22,7 @@ struct ins {
 
 struct ins_operands {
         char    *raw;
+        char    *raw_comment;
         struct {
                 char    *raw;
                 char    *name;
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index c980bbff6353..1a61628a1c12 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -251,8 +251,9 @@ struct perf_evsel *perf_evsel__new_idx(struct perf_event_attr *attr, int idx)
 {
         struct perf_evsel *evsel = zalloc(perf_evsel__object.size);
 
-        if (evsel != NULL)
-                perf_evsel__init(evsel, attr, idx);
+        if (!evsel)
+                return NULL;
+        perf_evsel__init(evsel, attr, idx);
 
         if (perf_evsel__is_bpf_output(evsel)) {
                 evsel->attr.sample_type |= (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME |
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index c85d0d1a65ed..7b0ca7cbb7de 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -377,7 +377,7 @@ out:
 
 static int record_saved_cmdline(void)
 {
-        unsigned int size;
+        unsigned long long size;
         char *path;
         struct stat st;
         int ret, err = 0;
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 920b1d58a068..e76214f8d596 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -164,16 +164,15 @@ void parse_ftrace_printk(struct tep_handle *pevent,
 void parse_saved_cmdline(struct tep_handle *pevent,
                          char *file, unsigned int size __maybe_unused)
 {
-        char *comm;
+        char comm[17]; /* Max comm length in the kernel is 16. */
         char *line;
         char *next = NULL;
         int pid;
 
         line = strtok_r(file, "\n", &next);
         while (line) {
-                sscanf(line, "%d %ms", &pid, &comm);
-                tep_register_comm(pevent, comm, pid);
-                free(comm);
+                if (sscanf(line, "%d %16s", &pid, comm) == 2)
+                        tep_register_comm(pevent, comm, pid);
                 line = strtok_r(NULL, "\n", &next);
         }
 }