aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--Documentation/clk.txt2
-rw-r--r--drivers/clk/bcm/clk-bcm2835.c25
-rw-r--r--drivers/clk/davinci/pll.c8
-rw-r--r--include/linux/clk-provider.h2
4 files changed, 16 insertions, 21 deletions
diff --git a/Documentation/clk.txt b/Documentation/clk.txt
index 511628bb3d3a..593cca5058b1 100644
--- a/Documentation/clk.txt
+++ b/Documentation/clk.txt
@@ -96,7 +96,7 @@ the operations defined in clk-provider.h::
96 int (*get_phase)(struct clk_hw *hw); 96 int (*get_phase)(struct clk_hw *hw);
97 int (*set_phase)(struct clk_hw *hw, int degrees); 97 int (*set_phase)(struct clk_hw *hw, int degrees);
98 void (*init)(struct clk_hw *hw); 98 void (*init)(struct clk_hw *hw);
99 int (*debug_init)(struct clk_hw *hw, 99 void (*debug_init)(struct clk_hw *hw,
100 struct dentry *dentry); 100 struct dentry *dentry);
101 }; 101 };
102 102
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 1329440af59f..0bd62efc07f8 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -394,7 +394,7 @@ out:
394 return count * 1000; 394 return count * 1000;
395} 395}
396 396
397static int bcm2835_debugfs_regset(struct bcm2835_cprman *cprman, u32 base, 397static void bcm2835_debugfs_regset(struct bcm2835_cprman *cprman, u32 base,
398 struct debugfs_reg32 *regs, size_t nregs, 398 struct debugfs_reg32 *regs, size_t nregs,
399 struct dentry *dentry) 399 struct dentry *dentry)
400{ 400{
@@ -402,15 +402,13 @@ static int bcm2835_debugfs_regset(struct bcm2835_cprman *cprman, u32 base,
402 402
403 regset = devm_kzalloc(cprman->dev, sizeof(*regset), GFP_KERNEL); 403 regset = devm_kzalloc(cprman->dev, sizeof(*regset), GFP_KERNEL);
404 if (!regset) 404 if (!regset)
405 return -ENOMEM; 405 return;
406 406
407 regset->regs = regs; 407 regset->regs = regs;
408 regset->nregs = nregs; 408 regset->nregs = nregs;
409 regset->base = cprman->regs + base; 409 regset->base = cprman->regs + base;
410 410
411 debugfs_create_regset32("regdump", S_IRUGO, dentry, regset); 411 debugfs_create_regset32("regdump", S_IRUGO, dentry, regset);
412
413 return 0;
414} 412}
415 413
416struct bcm2835_pll_data { 414struct bcm2835_pll_data {
@@ -728,7 +726,7 @@ static int bcm2835_pll_set_rate(struct clk_hw *hw,
728 return 0; 726 return 0;
729} 727}
730 728
731static int bcm2835_pll_debug_init(struct clk_hw *hw, 729static void bcm2835_pll_debug_init(struct clk_hw *hw,
732 struct dentry *dentry) 730 struct dentry *dentry)
733{ 731{
734 struct bcm2835_pll *pll = container_of(hw, struct bcm2835_pll, hw); 732 struct bcm2835_pll *pll = container_of(hw, struct bcm2835_pll, hw);
@@ -738,7 +736,7 @@ static int bcm2835_pll_debug_init(struct clk_hw *hw,
738 736
739 regs = devm_kzalloc(cprman->dev, 7 * sizeof(*regs), GFP_KERNEL); 737 regs = devm_kzalloc(cprman->dev, 7 * sizeof(*regs), GFP_KERNEL);
740 if (!regs) 738 if (!regs)
741 return -ENOMEM; 739 return;
742 740
743 regs[0].name = "cm_ctrl"; 741 regs[0].name = "cm_ctrl";
744 regs[0].offset = data->cm_ctrl_reg; 742 regs[0].offset = data->cm_ctrl_reg;
@@ -755,7 +753,7 @@ static int bcm2835_pll_debug_init(struct clk_hw *hw,
755 regs[6].name = "ana3"; 753 regs[6].name = "ana3";
756 regs[6].offset = data->ana_reg_base + 3 * 4; 754 regs[6].offset = data->ana_reg_base + 3 * 4;
757 755
758 return bcm2835_debugfs_regset(cprman, 0, regs, 7, dentry); 756 bcm2835_debugfs_regset(cprman, 0, regs, 7, dentry);
759} 757}
760 758
761static const struct clk_ops bcm2835_pll_clk_ops = { 759static const struct clk_ops bcm2835_pll_clk_ops = {
@@ -859,8 +857,8 @@ static int bcm2835_pll_divider_set_rate(struct clk_hw *hw,
859 return 0; 857 return 0;
860} 858}
861 859
862static int bcm2835_pll_divider_debug_init(struct clk_hw *hw, 860static void bcm2835_pll_divider_debug_init(struct clk_hw *hw,
863 struct dentry *dentry) 861 struct dentry *dentry)
864{ 862{
865 struct bcm2835_pll_divider *divider = bcm2835_pll_divider_from_hw(hw); 863 struct bcm2835_pll_divider *divider = bcm2835_pll_divider_from_hw(hw);
866 struct bcm2835_cprman *cprman = divider->cprman; 864 struct bcm2835_cprman *cprman = divider->cprman;
@@ -869,14 +867,14 @@ static int bcm2835_pll_divider_debug_init(struct clk_hw *hw,
869 867
870 regs = devm_kzalloc(cprman->dev, 7 * sizeof(*regs), GFP_KERNEL); 868 regs = devm_kzalloc(cprman->dev, 7 * sizeof(*regs), GFP_KERNEL);
871 if (!regs) 869 if (!regs)
872 return -ENOMEM; 870 return;
873 871
874 regs[0].name = "cm"; 872 regs[0].name = "cm";
875 regs[0].offset = data->cm_reg; 873 regs[0].offset = data->cm_reg;
876 regs[1].name = "a2w"; 874 regs[1].name = "a2w";
877 regs[1].offset = data->a2w_reg; 875 regs[1].offset = data->a2w_reg;
878 876
879 return bcm2835_debugfs_regset(cprman, 0, regs, 2, dentry); 877 bcm2835_debugfs_regset(cprman, 0, regs, 2, dentry);
880} 878}
881 879
882static const struct clk_ops bcm2835_pll_divider_clk_ops = { 880static const struct clk_ops bcm2835_pll_divider_clk_ops = {
@@ -1252,15 +1250,14 @@ static struct debugfs_reg32 bcm2835_debugfs_clock_reg32[] = {
1252 }, 1250 },
1253}; 1251};
1254 1252
1255static int bcm2835_clock_debug_init(struct clk_hw *hw, 1253static void bcm2835_clock_debug_init(struct clk_hw *hw,
1256 struct dentry *dentry) 1254 struct dentry *dentry)
1257{ 1255{
1258 struct bcm2835_clock *clock = bcm2835_clock_from_hw(hw); 1256 struct bcm2835_clock *clock = bcm2835_clock_from_hw(hw);
1259 struct bcm2835_cprman *cprman = clock->cprman; 1257 struct bcm2835_cprman *cprman = clock->cprman;
1260 const struct bcm2835_clock_data *data = clock->data; 1258 const struct bcm2835_clock_data *data = clock->data;
1261 1259
1262 return bcm2835_debugfs_regset( 1260 bcm2835_debugfs_regset(cprman, data->ctl_reg,
1263 cprman, data->ctl_reg,
1264 bcm2835_debugfs_clock_reg32, 1261 bcm2835_debugfs_clock_reg32,
1265 ARRAY_SIZE(bcm2835_debugfs_clock_reg32), 1262 ARRAY_SIZE(bcm2835_debugfs_clock_reg32),
1266 dentry); 1263 dentry);
diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c
index bb9594703d4a..5a5b853dde8a 100644
--- a/drivers/clk/davinci/pll.c
+++ b/drivers/clk/davinci/pll.c
@@ -190,7 +190,7 @@ static int davinci_pll_set_rate(struct clk_hw *hw, unsigned long rate,
190} 190}
191 191
192#ifdef CONFIG_DEBUG_FS 192#ifdef CONFIG_DEBUG_FS
193static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry); 193static void davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry);
194#else 194#else
195#define davinci_pll_debug_init NULL 195#define davinci_pll_debug_init NULL
196#endif 196#endif
@@ -874,21 +874,19 @@ static const struct debugfs_reg32 davinci_pll_regs[] = {
874 DEBUG_REG(PLLDIV9), 874 DEBUG_REG(PLLDIV9),
875}; 875};
876 876
877static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry) 877static void davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry)
878{ 878{
879 struct davinci_pll_clk *pll = to_davinci_pll_clk(hw); 879 struct davinci_pll_clk *pll = to_davinci_pll_clk(hw);
880 struct debugfs_regset32 *regset; 880 struct debugfs_regset32 *regset;
881 881
882 regset = kzalloc(sizeof(*regset), GFP_KERNEL); 882 regset = kzalloc(sizeof(*regset), GFP_KERNEL);
883 if (!regset) 883 if (!regset)
884 return -ENOMEM; 884 return;
885 885
886 regset->regs = davinci_pll_regs; 886 regset->regs = davinci_pll_regs;
887 regset->nregs = ARRAY_SIZE(davinci_pll_regs); 887 regset->nregs = ARRAY_SIZE(davinci_pll_regs);
888 regset->base = pll->base; 888 regset->base = pll->base;
889 889
890 debugfs_create_regset32("registers", 0400, dentry, regset); 890 debugfs_create_regset32("registers", 0400, dentry, regset);
891
892 return 0;
893} 891}
894#endif 892#endif
diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 00e55d4d07f1..a4dc15afbdaf 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -218,7 +218,7 @@ struct clk_ops {
218 int (*get_phase)(struct clk_hw *hw); 218 int (*get_phase)(struct clk_hw *hw);
219 int (*set_phase)(struct clk_hw *hw, int degrees); 219 int (*set_phase)(struct clk_hw *hw, int degrees);
220 void (*init)(struct clk_hw *hw); 220 void (*init)(struct clk_hw *hw);
221 int (*debug_init)(struct clk_hw *hw, struct dentry *dentry); 221 void (*debug_init)(struct clk_hw *hw, struct dentry *dentry);
222}; 222};
223 223
224/** 224/**