diff options
| -rw-r--r-- | drivers/hsi/controllers/omap_ssi.c | 7 | ||||
| -rw-r--r-- | drivers/hsi/controllers/omap_ssi_port.c | 8 | ||||
| -rw-r--r-- | include/linux/hsi/hsi.h | 3 |
3 files changed, 7 insertions, 11 deletions
diff --git a/drivers/hsi/controllers/omap_ssi.c b/drivers/hsi/controllers/omap_ssi.c index f6d3100b7a32..27b91f14ba7a 100644 --- a/drivers/hsi/controllers/omap_ssi.c +++ b/drivers/hsi/controllers/omap_ssi.c | |||
| @@ -323,11 +323,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi, | |||
| 323 | return -ENOMEM; | 323 | return -ENOMEM; |
| 324 | } | 324 | } |
| 325 | 325 | ||
| 326 | ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); | 326 | err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); |
| 327 | if (ssi->id < 0) { | 327 | if (err < 0) |
| 328 | err = ssi->id; | ||
| 329 | goto out_err; | 328 | goto out_err; |
| 330 | } | 329 | ssi->id = err; |
| 331 | 330 | ||
| 332 | ssi->owner = THIS_MODULE; | 331 | ssi->owner = THIS_MODULE; |
| 333 | ssi->device.parent = &pd->dev; | 332 | ssi->device.parent = &pd->dev; |
diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c index 02e66032ae73..e80a66e20998 100644 --- a/drivers/hsi/controllers/omap_ssi_port.c +++ b/drivers/hsi/controllers/omap_ssi_port.c | |||
| @@ -1147,13 +1147,13 @@ static int __init ssi_port_probe(struct platform_device *pd) | |||
| 1147 | goto error; | 1147 | goto error; |
| 1148 | } | 1148 | } |
| 1149 | 1149 | ||
| 1150 | cawake_gpio = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); | 1150 | err = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); |
| 1151 | if (cawake_gpio < 0) { | 1151 | if (err < 0) { |
| 1152 | dev_err(&pd->dev, "DT data is missing cawake gpio (err=%d)\n", | 1152 | dev_err(&pd->dev, "DT data is missing cawake gpio (err=%d)\n", |
| 1153 | cawake_gpio); | 1153 | err); |
| 1154 | err = -ENODEV; | ||
| 1155 | goto error; | 1154 | goto error; |
| 1156 | } | 1155 | } |
| 1156 | cawake_gpio = err; | ||
| 1157 | 1157 | ||
| 1158 | err = devm_gpio_request_one(&port->device, cawake_gpio, GPIOF_DIR_IN, | 1158 | err = devm_gpio_request_one(&port->device, cawake_gpio, GPIOF_DIR_IN, |
| 1159 | "cawake"); | 1159 | "cawake"); |
diff --git a/include/linux/hsi/hsi.h b/include/linux/hsi/hsi.h index 5dd60c2e120f..2790591c77cf 100644 --- a/include/linux/hsi/hsi.h +++ b/include/linux/hsi/hsi.h | |||
| @@ -135,9 +135,6 @@ static inline int hsi_register_board_info(struct hsi_board_info const *info, | |||
| 135 | * @device: Driver model representation of the device | 135 | * @device: Driver model representation of the device |
| 136 | * @tx_cfg: HSI TX configuration | 136 | * @tx_cfg: HSI TX configuration |
| 137 | * @rx_cfg: HSI RX configuration | 137 | * @rx_cfg: HSI RX configuration |
| 138 | * @e_handler: Callback for handling port events (RX Wake High/Low) | ||
| 139 | * @pclaimed: Keeps tracks if the clients claimed its associated HSI port | ||
| 140 | * @nb: Notifier block for port events | ||
| 141 | */ | 138 | */ |
| 142 | struct hsi_client { | 139 | struct hsi_client { |
| 143 | struct device device; | 140 | struct device device; |
