aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--security/keys/dh.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/security/keys/dh.c b/security/keys/dh.c
index e603bd912e4c..8abc70ebe22d 100644
--- a/security/keys/dh.c
+++ b/security/keys/dh.c
@@ -89,6 +89,7 @@ static int kdf_alloc(struct kdf_sdesc **sdesc_ret, char *hashname)
89 struct crypto_shash *tfm; 89 struct crypto_shash *tfm;
90 struct kdf_sdesc *sdesc; 90 struct kdf_sdesc *sdesc;
91 int size; 91 int size;
92 int err;
92 93
93 /* allocate synchronous hash */ 94 /* allocate synchronous hash */
94 tfm = crypto_alloc_shash(hashname, 0, 0); 95 tfm = crypto_alloc_shash(hashname, 0, 0);
@@ -97,16 +98,25 @@ static int kdf_alloc(struct kdf_sdesc **sdesc_ret, char *hashname)
97 return PTR_ERR(tfm); 98 return PTR_ERR(tfm);
98 } 99 }
99 100
101 err = -EINVAL;
102 if (crypto_shash_digestsize(tfm) == 0)
103 goto out_free_tfm;
104
105 err = -ENOMEM;
100 size = sizeof(struct shash_desc) + crypto_shash_descsize(tfm); 106 size = sizeof(struct shash_desc) + crypto_shash_descsize(tfm);
101 sdesc = kmalloc(size, GFP_KERNEL); 107 sdesc = kmalloc(size, GFP_KERNEL);
102 if (!sdesc) 108 if (!sdesc)
103 return -ENOMEM; 109 goto out_free_tfm;
104 sdesc->shash.tfm = tfm; 110 sdesc->shash.tfm = tfm;
105 sdesc->shash.flags = 0x0; 111 sdesc->shash.flags = 0x0;
106 112
107 *sdesc_ret = sdesc; 113 *sdesc_ret = sdesc;
108 114
109 return 0; 115 return 0;
116
117out_free_tfm:
118 crypto_free_shash(tfm);
119 return err;
110} 120}
111 121
112static void kdf_dealloc(struct kdf_sdesc *sdesc) 122static void kdf_dealloc(struct kdf_sdesc *sdesc)