diff options
-rw-r--r-- | net/sunrpc/xprtrdma/fmr_ops.c | 32 | ||||
-rw-r--r-- | net/sunrpc/xprtrdma/xprt_rdma.h | 7 |
2 files changed, 28 insertions, 11 deletions
diff --git a/net/sunrpc/xprtrdma/fmr_ops.c b/net/sunrpc/xprtrdma/fmr_ops.c index 52f9ad5fe19b..4a53ad5ab4b3 100644 --- a/net/sunrpc/xprtrdma/fmr_ops.c +++ b/net/sunrpc/xprtrdma/fmr_ops.c | |||
@@ -72,13 +72,19 @@ fmr_op_init(struct rpcrdma_xprt *r_xprt) | |||
72 | i = (buf->rb_max_requests + 1) * RPCRDMA_MAX_SEGS; | 72 | i = (buf->rb_max_requests + 1) * RPCRDMA_MAX_SEGS; |
73 | dprintk("RPC: %s: initializing %d FMRs\n", __func__, i); | 73 | dprintk("RPC: %s: initializing %d FMRs\n", __func__, i); |
74 | 74 | ||
75 | rc = -ENOMEM; | ||
75 | while (i--) { | 76 | while (i--) { |
76 | r = kzalloc(sizeof(*r), GFP_KERNEL); | 77 | r = kzalloc(sizeof(*r), GFP_KERNEL); |
77 | if (!r) | 78 | if (!r) |
78 | return -ENOMEM; | 79 | goto out; |
80 | |||
81 | r->r.fmr.physaddrs = kmalloc(RPCRDMA_MAX_FMR_SGES * | ||
82 | sizeof(u64), GFP_KERNEL); | ||
83 | if (!r->r.fmr.physaddrs) | ||
84 | goto out_free; | ||
79 | 85 | ||
80 | r->r.fmr = ib_alloc_fmr(pd, mr_access_flags, &fmr_attr); | 86 | r->r.fmr.fmr = ib_alloc_fmr(pd, mr_access_flags, &fmr_attr); |
81 | if (IS_ERR(r->r.fmr)) | 87 | if (IS_ERR(r->r.fmr.fmr)) |
82 | goto out_fmr_err; | 88 | goto out_fmr_err; |
83 | 89 | ||
84 | list_add(&r->mw_list, &buf->rb_mws); | 90 | list_add(&r->mw_list, &buf->rb_mws); |
@@ -87,9 +93,12 @@ fmr_op_init(struct rpcrdma_xprt *r_xprt) | |||
87 | return 0; | 93 | return 0; |
88 | 94 | ||
89 | out_fmr_err: | 95 | out_fmr_err: |
90 | rc = PTR_ERR(r->r.fmr); | 96 | rc = PTR_ERR(r->r.fmr.fmr); |
91 | dprintk("RPC: %s: ib_alloc_fmr status %i\n", __func__, rc); | 97 | dprintk("RPC: %s: ib_alloc_fmr status %i\n", __func__, rc); |
98 | kfree(r->r.fmr.physaddrs); | ||
99 | out_free: | ||
92 | kfree(r); | 100 | kfree(r); |
101 | out: | ||
93 | return rc; | 102 | return rc; |
94 | } | 103 | } |
95 | 104 | ||
@@ -98,7 +107,7 @@ __fmr_unmap(struct rpcrdma_mw *r) | |||
98 | { | 107 | { |
99 | LIST_HEAD(l); | 108 | LIST_HEAD(l); |
100 | 109 | ||
101 | list_add(&r->r.fmr->list, &l); | 110 | list_add(&r->r.fmr.fmr->list, &l); |
102 | return ib_unmap_fmr(&l); | 111 | return ib_unmap_fmr(&l); |
103 | } | 112 | } |
104 | 113 | ||
@@ -113,7 +122,6 @@ fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg, | |||
113 | struct ib_device *device = ia->ri_device; | 122 | struct ib_device *device = ia->ri_device; |
114 | enum dma_data_direction direction = rpcrdma_data_dir(writing); | 123 | enum dma_data_direction direction = rpcrdma_data_dir(writing); |
115 | struct rpcrdma_mr_seg *seg1 = seg; | 124 | struct rpcrdma_mr_seg *seg1 = seg; |
116 | u64 physaddrs[RPCRDMA_MAX_DATA_SEGS]; | ||
117 | int len, pageoff, i, rc; | 125 | int len, pageoff, i, rc; |
118 | struct rpcrdma_mw *mw; | 126 | struct rpcrdma_mw *mw; |
119 | 127 | ||
@@ -138,7 +146,7 @@ fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg, | |||
138 | nsegs = RPCRDMA_MAX_FMR_SGES; | 146 | nsegs = RPCRDMA_MAX_FMR_SGES; |
139 | for (i = 0; i < nsegs;) { | 147 | for (i = 0; i < nsegs;) { |
140 | rpcrdma_map_one(device, seg, direction); | 148 | rpcrdma_map_one(device, seg, direction); |
141 | physaddrs[i] = seg->mr_dma; | 149 | mw->r.fmr.physaddrs[i] = seg->mr_dma; |
142 | len += seg->mr_len; | 150 | len += seg->mr_len; |
143 | ++seg; | 151 | ++seg; |
144 | ++i; | 152 | ++i; |
@@ -148,12 +156,13 @@ fmr_op_map(struct rpcrdma_xprt *r_xprt, struct rpcrdma_mr_seg *seg, | |||
148 | break; | 156 | break; |
149 | } | 157 | } |
150 | 158 | ||
151 | rc = ib_map_phys_fmr(mw->r.fmr, physaddrs, i, seg1->mr_dma); | 159 | rc = ib_map_phys_fmr(mw->r.fmr.fmr, mw->r.fmr.physaddrs, |
160 | i, seg1->mr_dma); | ||
152 | if (rc) | 161 | if (rc) |
153 | goto out_maperr; | 162 | goto out_maperr; |
154 | 163 | ||
155 | seg1->rl_mw = mw; | 164 | seg1->rl_mw = mw; |
156 | seg1->mr_rkey = mw->r.fmr->rkey; | 165 | seg1->mr_rkey = mw->r.fmr.fmr->rkey; |
157 | seg1->mr_base = seg1->mr_dma + pageoff; | 166 | seg1->mr_base = seg1->mr_dma + pageoff; |
158 | seg1->mr_nsegs = i; | 167 | seg1->mr_nsegs = i; |
159 | seg1->mr_len = len; | 168 | seg1->mr_len = len; |
@@ -207,10 +216,13 @@ fmr_op_destroy(struct rpcrdma_buffer *buf) | |||
207 | while (!list_empty(&buf->rb_all)) { | 216 | while (!list_empty(&buf->rb_all)) { |
208 | r = list_entry(buf->rb_all.next, struct rpcrdma_mw, mw_all); | 217 | r = list_entry(buf->rb_all.next, struct rpcrdma_mw, mw_all); |
209 | list_del(&r->mw_all); | 218 | list_del(&r->mw_all); |
210 | rc = ib_dealloc_fmr(r->r.fmr); | 219 | kfree(r->r.fmr.physaddrs); |
220 | |||
221 | rc = ib_dealloc_fmr(r->r.fmr.fmr); | ||
211 | if (rc) | 222 | if (rc) |
212 | dprintk("RPC: %s: ib_dealloc_fmr failed %i\n", | 223 | dprintk("RPC: %s: ib_dealloc_fmr failed %i\n", |
213 | __func__, rc); | 224 | __func__, rc); |
225 | |||
214 | kfree(r); | 226 | kfree(r); |
215 | } | 227 | } |
216 | } | 228 | } |
diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h b/net/sunrpc/xprtrdma/xprt_rdma.h index df92884400c4..110d685b4ac5 100644 --- a/net/sunrpc/xprtrdma/xprt_rdma.h +++ b/net/sunrpc/xprtrdma/xprt_rdma.h | |||
@@ -206,9 +206,14 @@ struct rpcrdma_frmr { | |||
206 | struct rpcrdma_xprt *fr_xprt; | 206 | struct rpcrdma_xprt *fr_xprt; |
207 | }; | 207 | }; |
208 | 208 | ||
209 | struct rpcrdma_fmr { | ||
210 | struct ib_fmr *fmr; | ||
211 | u64 *physaddrs; | ||
212 | }; | ||
213 | |||
209 | struct rpcrdma_mw { | 214 | struct rpcrdma_mw { |
210 | union { | 215 | union { |
211 | struct ib_fmr *fmr; | 216 | struct rpcrdma_fmr fmr; |
212 | struct rpcrdma_frmr frmr; | 217 | struct rpcrdma_frmr frmr; |
213 | } r; | 218 | } r; |
214 | void (*mw_sendcompletion)(struct ib_wc *); | 219 | void (*mw_sendcompletion)(struct ib_wc *); |