diff options
-rw-r--r-- | include/linux/percpu-refcount.h | 3 | ||||
-rw-r--r-- | lib/percpu-refcount.c | 4 |
2 files changed, 3 insertions, 4 deletions
diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h index b61bd6f23985..8146aa9cd89e 100644 --- a/include/linux/percpu-refcount.h +++ b/include/linux/percpu-refcount.h | |||
@@ -66,7 +66,8 @@ struct percpu_ref { | |||
66 | struct rcu_head rcu; | 66 | struct rcu_head rcu; |
67 | }; | 67 | }; |
68 | 68 | ||
69 | int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release); | 69 | int __must_check percpu_ref_init(struct percpu_ref *ref, |
70 | percpu_ref_func_t *release); | ||
70 | void percpu_ref_kill(struct percpu_ref *ref); | 71 | void percpu_ref_kill(struct percpu_ref *ref); |
71 | 72 | ||
72 | #define PCPU_STATUS_BITS 2 | 73 | #define PCPU_STATUS_BITS 2 |
diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c index 9a78e55fa48f..b35eaac2954f 100644 --- a/lib/percpu-refcount.c +++ b/lib/percpu-refcount.c | |||
@@ -57,12 +57,10 @@ int percpu_ref_init(struct percpu_ref *ref, percpu_ref_func_t *release) | |||
57 | static void percpu_ref_kill_rcu(struct rcu_head *rcu) | 57 | static void percpu_ref_kill_rcu(struct rcu_head *rcu) |
58 | { | 58 | { |
59 | struct percpu_ref *ref = container_of(rcu, struct percpu_ref, rcu); | 59 | struct percpu_ref *ref = container_of(rcu, struct percpu_ref, rcu); |
60 | unsigned __percpu *pcpu_count; | 60 | unsigned __percpu *pcpu_count = ref->pcpu_count; |
61 | unsigned count = 0; | 61 | unsigned count = 0; |
62 | int cpu; | 62 | int cpu; |
63 | 63 | ||
64 | pcpu_count = ACCESS_ONCE(ref->pcpu_count); | ||
65 | |||
66 | /* Mask out PCPU_REF_DEAD */ | 64 | /* Mask out PCPU_REF_DEAD */ |
67 | pcpu_count = (unsigned __percpu *) | 65 | pcpu_count = (unsigned __percpu *) |
68 | (((unsigned long) pcpu_count) & ~PCPU_STATUS_MASK); | 66 | (((unsigned long) pcpu_count) & ~PCPU_STATUS_MASK); |