diff options
| -rw-r--r-- | drivers/pci/pci-sysfs.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index 1eecfa301f7f..8e075ea2743e 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c | |||
| @@ -686,7 +686,7 @@ static ssize_t driver_override_store(struct device *dev, | |||
| 686 | const char *buf, size_t count) | 686 | const char *buf, size_t count) |
| 687 | { | 687 | { |
| 688 | struct pci_dev *pdev = to_pci_dev(dev); | 688 | struct pci_dev *pdev = to_pci_dev(dev); |
| 689 | char *driver_override, *old = pdev->driver_override, *cp; | 689 | char *driver_override, *old, *cp; |
| 690 | 690 | ||
| 691 | /* We need to keep extra room for a newline */ | 691 | /* We need to keep extra room for a newline */ |
| 692 | if (count >= (PAGE_SIZE - 1)) | 692 | if (count >= (PAGE_SIZE - 1)) |
| @@ -700,12 +700,15 @@ static ssize_t driver_override_store(struct device *dev, | |||
| 700 | if (cp) | 700 | if (cp) |
| 701 | *cp = '\0'; | 701 | *cp = '\0'; |
| 702 | 702 | ||
| 703 | device_lock(dev); | ||
| 704 | old = pdev->driver_override; | ||
| 703 | if (strlen(driver_override)) { | 705 | if (strlen(driver_override)) { |
| 704 | pdev->driver_override = driver_override; | 706 | pdev->driver_override = driver_override; |
| 705 | } else { | 707 | } else { |
| 706 | kfree(driver_override); | 708 | kfree(driver_override); |
| 707 | pdev->driver_override = NULL; | 709 | pdev->driver_override = NULL; |
| 708 | } | 710 | } |
| 711 | device_unlock(dev); | ||
| 709 | 712 | ||
| 710 | kfree(old); | 713 | kfree(old); |
| 711 | 714 | ||
| @@ -716,8 +719,12 @@ static ssize_t driver_override_show(struct device *dev, | |||
| 716 | struct device_attribute *attr, char *buf) | 719 | struct device_attribute *attr, char *buf) |
| 717 | { | 720 | { |
| 718 | struct pci_dev *pdev = to_pci_dev(dev); | 721 | struct pci_dev *pdev = to_pci_dev(dev); |
| 722 | ssize_t len; | ||
| 719 | 723 | ||
| 720 | return snprintf(buf, PAGE_SIZE, "%s\n", pdev->driver_override); | 724 | device_lock(dev); |
| 725 | len = snprintf(buf, PAGE_SIZE, "%s\n", pdev->driver_override); | ||
| 726 | device_unlock(dev); | ||
| 727 | return len; | ||
| 721 | } | 728 | } |
| 722 | static DEVICE_ATTR_RW(driver_override); | 729 | static DEVICE_ATTR_RW(driver_override); |
| 723 | 730 | ||
