aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--sound/soc/codecs/wm8996.c6
-rw-r--r--sound/soc/xtensa/xtfpga-i2s.c8
-rw-r--r--sound/soc/zte/zx296702-i2s.c6
3 files changed, 6 insertions, 14 deletions
diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c
index a1905433b125..f7ccd9fc5808 100644
--- a/sound/soc/codecs/wm8996.c
+++ b/sound/soc/codecs/wm8996.c
@@ -2647,12 +2647,10 @@ static int wm8996_probe(struct snd_soc_codec *codec)
2647 if (irq_flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING)) 2647 if (irq_flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING))
2648 ret = request_threaded_irq(i2c->irq, NULL, 2648 ret = request_threaded_irq(i2c->irq, NULL,
2649 wm8996_edge_irq, 2649 wm8996_edge_irq,
2650 irq_flags | IRQF_ONESHOT, 2650 irq_flags, "wm8996", codec);
2651 "wm8996", codec);
2652 else 2651 else
2653 ret = request_threaded_irq(i2c->irq, NULL, wm8996_irq, 2652 ret = request_threaded_irq(i2c->irq, NULL, wm8996_irq,
2654 irq_flags | IRQF_ONESHOT, 2653 irq_flags, "wm8996", codec);
2655 "wm8996", codec);
2656 2654
2657 if (ret == 0) { 2655 if (ret == 0) {
2658 /* Unmask the interrupt */ 2656 /* Unmask the interrupt */
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c
index 1cfb19e12949..8382ffa3bcaf 100644
--- a/sound/soc/xtensa/xtfpga-i2s.c
+++ b/sound/soc/xtensa/xtfpga-i2s.c
@@ -75,7 +75,7 @@ struct xtfpga_i2s {
75 * stream in the pcm_close callback it synchronizes with the interrupt 75 * stream in the pcm_close callback it synchronizes with the interrupt
76 * handler by means of synchronize_rcu call. 76 * handler by means of synchronize_rcu call.
77 */ 77 */
78 struct snd_pcm_substream *tx_substream; 78 struct snd_pcm_substream __rcu *tx_substream;
79 unsigned (*tx_fn)(struct xtfpga_i2s *i2s, 79 unsigned (*tx_fn)(struct xtfpga_i2s *i2s,
80 struct snd_pcm_runtime *runtime, 80 struct snd_pcm_runtime *runtime,
81 unsigned tx_ptr); 81 unsigned tx_ptr);
@@ -474,11 +474,6 @@ static int xtfpga_pcm_new(struct snd_soc_pcm_runtime *rtd)
474 card->dev, size, size); 474 card->dev, size, size);
475} 475}
476 476
477static void xtfpga_pcm_free(struct snd_pcm *pcm)
478{
479 snd_pcm_lib_preallocate_free_for_all(pcm);
480}
481
482static const struct snd_pcm_ops xtfpga_pcm_ops = { 477static const struct snd_pcm_ops xtfpga_pcm_ops = {
483 .open = xtfpga_pcm_open, 478 .open = xtfpga_pcm_open,
484 .close = xtfpga_pcm_close, 479 .close = xtfpga_pcm_close,
@@ -490,7 +485,6 @@ static const struct snd_pcm_ops xtfpga_pcm_ops = {
490 485
491static const struct snd_soc_platform_driver xtfpga_soc_platform = { 486static const struct snd_soc_platform_driver xtfpga_soc_platform = {
492 .pcm_new = xtfpga_pcm_new, 487 .pcm_new = xtfpga_pcm_new,
493 .pcm_free = xtfpga_pcm_free,
494 .ops = &xtfpga_pcm_ops, 488 .ops = &xtfpga_pcm_ops,
495}; 489};
496 490
diff --git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c
index 1930c42e1f55..1cad93dc1fcf 100644
--- a/sound/soc/zte/zx296702-i2s.c
+++ b/sound/soc/zte/zx296702-i2s.c
@@ -380,7 +380,7 @@ static int zx_i2s_probe(struct platform_device *pdev)
380 struct zx_i2s_info *zx_i2s; 380 struct zx_i2s_info *zx_i2s;
381 int ret; 381 int ret;
382 382
383 zx_i2s = kzalloc(sizeof(*zx_i2s), GFP_KERNEL); 383 zx_i2s = devm_kzalloc(&pdev->dev, sizeof(*zx_i2s), GFP_KERNEL);
384 if (!zx_i2s) 384 if (!zx_i2s)
385 return -ENOMEM; 385 return -ENOMEM;
386 386
@@ -401,8 +401,8 @@ static int zx_i2s_probe(struct platform_device *pdev)
401 writel_relaxed(0, zx_i2s->reg_base + ZX_I2S_FIFO_CTRL); 401 writel_relaxed(0, zx_i2s->reg_base + ZX_I2S_FIFO_CTRL);
402 platform_set_drvdata(pdev, zx_i2s); 402 platform_set_drvdata(pdev, zx_i2s);
403 403
404 ret = snd_soc_register_component(&pdev->dev, &zx_i2s_component, 404 ret = devm_snd_soc_register_component(&pdev->dev, &zx_i2s_component,
405 &zx_i2s_dai, 1); 405 &zx_i2s_dai, 1);
406 if (ret) { 406 if (ret) {
407 dev_err(&pdev->dev, "Register DAI failed: %d\n", ret); 407 dev_err(&pdev->dev, "Register DAI failed: %d\n", ret);
408 return ret; 408 return ret;