diff options
| -rw-r--r-- | drivers/ata/ahci_qoriq.c | 6 | ||||
| -rw-r--r-- | drivers/ata/libata-sff.c | 1 | ||||
| -rw-r--r-- | drivers/ata/libata-transport.c | 9 |
3 files changed, 7 insertions, 9 deletions
diff --git a/drivers/ata/ahci_qoriq.c b/drivers/ata/ahci_qoriq.c index 85d833289f28..4c96f3ac4976 100644 --- a/drivers/ata/ahci_qoriq.c +++ b/drivers/ata/ahci_qoriq.c | |||
| @@ -177,7 +177,8 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv) | |||
| 177 | case AHCI_LS1043A: | 177 | case AHCI_LS1043A: |
| 178 | if (!qpriv->ecc_addr) | 178 | if (!qpriv->ecc_addr) |
| 179 | return -EINVAL; | 179 | return -EINVAL; |
| 180 | writel(ECC_DIS_ARMV8_CH2, qpriv->ecc_addr); | 180 | writel(readl(qpriv->ecc_addr) | ECC_DIS_ARMV8_CH2, |
| 181 | qpriv->ecc_addr); | ||
| 181 | writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); | 182 | writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); |
| 182 | writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS); | 183 | writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS); |
| 183 | if (qpriv->is_dmacoherent) | 184 | if (qpriv->is_dmacoherent) |
| @@ -194,7 +195,8 @@ static int ahci_qoriq_phy_init(struct ahci_host_priv *hpriv) | |||
| 194 | case AHCI_LS1046A: | 195 | case AHCI_LS1046A: |
| 195 | if (!qpriv->ecc_addr) | 196 | if (!qpriv->ecc_addr) |
| 196 | return -EINVAL; | 197 | return -EINVAL; |
| 197 | writel(ECC_DIS_ARMV8_CH2, qpriv->ecc_addr); | 198 | writel(readl(qpriv->ecc_addr) | ECC_DIS_ARMV8_CH2, |
| 199 | qpriv->ecc_addr); | ||
| 198 | writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); | 200 | writel(AHCI_PORT_PHY_1_CFG, reg_base + PORT_PHY1); |
| 199 | writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS); | 201 | writel(AHCI_PORT_TRANS_CFG, reg_base + PORT_TRANS); |
| 200 | if (qpriv->is_dmacoherent) | 202 | if (qpriv->is_dmacoherent) |
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 2bd92dca3e62..274d6d7193d7 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c | |||
| @@ -1482,7 +1482,6 @@ unsigned int ata_sff_qc_issue(struct ata_queued_cmd *qc) | |||
| 1482 | break; | 1482 | break; |
| 1483 | 1483 | ||
| 1484 | default: | 1484 | default: |
| 1485 | WARN_ON_ONCE(1); | ||
| 1486 | return AC_ERR_SYSTEM; | 1485 | return AC_ERR_SYSTEM; |
| 1487 | } | 1486 | } |
| 1488 | 1487 | ||
diff --git a/drivers/ata/libata-transport.c b/drivers/ata/libata-transport.c index 46698232e6bf..19e6e539a061 100644 --- a/drivers/ata/libata-transport.c +++ b/drivers/ata/libata-transport.c | |||
| @@ -224,7 +224,6 @@ static DECLARE_TRANSPORT_CLASS(ata_port_class, | |||
| 224 | 224 | ||
| 225 | static void ata_tport_release(struct device *dev) | 225 | static void ata_tport_release(struct device *dev) |
| 226 | { | 226 | { |
| 227 | put_device(dev->parent); | ||
| 228 | } | 227 | } |
| 229 | 228 | ||
| 230 | /** | 229 | /** |
| @@ -284,7 +283,7 @@ int ata_tport_add(struct device *parent, | |||
| 284 | device_initialize(dev); | 283 | device_initialize(dev); |
| 285 | dev->type = &ata_port_type; | 284 | dev->type = &ata_port_type; |
| 286 | 285 | ||
| 287 | dev->parent = get_device(parent); | 286 | dev->parent = parent; |
| 288 | dev->release = ata_tport_release; | 287 | dev->release = ata_tport_release; |
| 289 | dev_set_name(dev, "ata%d", ap->print_id); | 288 | dev_set_name(dev, "ata%d", ap->print_id); |
| 290 | transport_setup_device(dev); | 289 | transport_setup_device(dev); |
| @@ -348,7 +347,6 @@ static DECLARE_TRANSPORT_CLASS(ata_link_class, | |||
| 348 | 347 | ||
| 349 | static void ata_tlink_release(struct device *dev) | 348 | static void ata_tlink_release(struct device *dev) |
| 350 | { | 349 | { |
| 351 | put_device(dev->parent); | ||
| 352 | } | 350 | } |
| 353 | 351 | ||
| 354 | /** | 352 | /** |
| @@ -410,7 +408,7 @@ int ata_tlink_add(struct ata_link *link) | |||
| 410 | int error; | 408 | int error; |
| 411 | 409 | ||
| 412 | device_initialize(dev); | 410 | device_initialize(dev); |
| 413 | dev->parent = get_device(&ap->tdev); | 411 | dev->parent = &ap->tdev; |
| 414 | dev->release = ata_tlink_release; | 412 | dev->release = ata_tlink_release; |
| 415 | if (ata_is_host_link(link)) | 413 | if (ata_is_host_link(link)) |
| 416 | dev_set_name(dev, "link%d", ap->print_id); | 414 | dev_set_name(dev, "link%d", ap->print_id); |
| @@ -589,7 +587,6 @@ static DECLARE_TRANSPORT_CLASS(ata_dev_class, | |||
| 589 | 587 | ||
| 590 | static void ata_tdev_release(struct device *dev) | 588 | static void ata_tdev_release(struct device *dev) |
| 591 | { | 589 | { |
| 592 | put_device(dev->parent); | ||
| 593 | } | 590 | } |
| 594 | 591 | ||
| 595 | /** | 592 | /** |
| @@ -662,7 +659,7 @@ static int ata_tdev_add(struct ata_device *ata_dev) | |||
| 662 | int error; | 659 | int error; |
| 663 | 660 | ||
| 664 | device_initialize(dev); | 661 | device_initialize(dev); |
| 665 | dev->parent = get_device(&link->tdev); | 662 | dev->parent = &link->tdev; |
| 666 | dev->release = ata_tdev_release; | 663 | dev->release = ata_tdev_release; |
| 667 | if (ata_is_host_link(link)) | 664 | if (ata_is_host_link(link)) |
| 668 | dev_set_name(dev, "dev%d.%d", ap->print_id,ata_dev->devno); | 665 | dev_set_name(dev, "dev%d.%d", ap->print_id,ata_dev->devno); |
