aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--mm/compaction.c25
-rw-r--r--mm/migrate.c15
2 files changed, 14 insertions, 26 deletions
diff --git a/mm/compaction.c b/mm/compaction.c
index 0409a4ad6ea1..70e6bec46dc2 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -634,22 +634,6 @@ isolate_freepages_range(struct compact_control *cc,
634 return pfn; 634 return pfn;
635} 635}
636 636
637/* Update the number of anon and file isolated pages in the zone */
638static void acct_isolated(struct zone *zone, struct compact_control *cc)
639{
640 struct page *page;
641 unsigned int count[2] = { 0, };
642
643 if (list_empty(&cc->migratepages))
644 return;
645
646 list_for_each_entry(page, &cc->migratepages, lru)
647 count[!!page_is_file_cache(page)]++;
648
649 mod_node_page_state(zone->zone_pgdat, NR_ISOLATED_ANON, count[0]);
650 mod_node_page_state(zone->zone_pgdat, NR_ISOLATED_FILE, count[1]);
651}
652
653/* Similar to reclaim, but different enough that they don't share logic */ 637/* Similar to reclaim, but different enough that they don't share logic */
654static bool too_many_isolated(struct zone *zone) 638static bool too_many_isolated(struct zone *zone)
655{ 639{
@@ -866,6 +850,8 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn,
866 850
867 /* Successfully isolated */ 851 /* Successfully isolated */
868 del_page_from_lru_list(page, lruvec, page_lru(page)); 852 del_page_from_lru_list(page, lruvec, page_lru(page));
853 inc_node_page_state(page,
854 NR_ISOLATED_ANON + page_is_file_cache(page));
869 855
870isolate_success: 856isolate_success:
871 list_add(&page->lru, &cc->migratepages); 857 list_add(&page->lru, &cc->migratepages);
@@ -902,7 +888,6 @@ isolate_fail:
902 spin_unlock_irqrestore(zone_lru_lock(zone), flags); 888 spin_unlock_irqrestore(zone_lru_lock(zone), flags);
903 locked = false; 889 locked = false;
904 } 890 }
905 acct_isolated(zone, cc);
906 putback_movable_pages(&cc->migratepages); 891 putback_movable_pages(&cc->migratepages);
907 cc->nr_migratepages = 0; 892 cc->nr_migratepages = 0;
908 cc->last_migrated_pfn = 0; 893 cc->last_migrated_pfn = 0;
@@ -988,7 +973,6 @@ isolate_migratepages_range(struct compact_control *cc, unsigned long start_pfn,
988 if (cc->nr_migratepages == COMPACT_CLUSTER_MAX) 973 if (cc->nr_migratepages == COMPACT_CLUSTER_MAX)
989 break; 974 break;
990 } 975 }
991 acct_isolated(cc->zone, cc);
992 976
993 return pfn; 977 return pfn;
994} 978}
@@ -1258,10 +1242,8 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone,
1258 low_pfn = isolate_migratepages_block(cc, low_pfn, 1242 low_pfn = isolate_migratepages_block(cc, low_pfn,
1259 block_end_pfn, isolate_mode); 1243 block_end_pfn, isolate_mode);
1260 1244
1261 if (!low_pfn || cc->contended) { 1245 if (!low_pfn || cc->contended)
1262 acct_isolated(zone, cc);
1263 return ISOLATE_ABORT; 1246 return ISOLATE_ABORT;
1264 }
1265 1247
1266 /* 1248 /*
1267 * Either we isolated something and proceed with migration. Or 1249 * Either we isolated something and proceed with migration. Or
@@ -1271,7 +1253,6 @@ static isolate_migrate_t isolate_migratepages(struct zone *zone,
1271 break; 1253 break;
1272 } 1254 }
1273 1255
1274 acct_isolated(zone, cc);
1275 /* Record where migration scanner will be restarted. */ 1256 /* Record where migration scanner will be restarted. */
1276 cc->migrate_pfn = low_pfn; 1257 cc->migrate_pfn = low_pfn;
1277 1258
diff --git a/mm/migrate.c b/mm/migrate.c
index 99250aee1ac1..66ce6b490b13 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -168,8 +168,6 @@ void putback_movable_pages(struct list_head *l)
168 continue; 168 continue;
169 } 169 }
170 list_del(&page->lru); 170 list_del(&page->lru);
171 dec_node_page_state(page, NR_ISOLATED_ANON +
172 page_is_file_cache(page));
173 /* 171 /*
174 * We isolated non-lru movable page so here we can use 172 * We isolated non-lru movable page so here we can use
175 * __PageMovable because LRU page's mapping cannot have 173 * __PageMovable because LRU page's mapping cannot have
@@ -186,6 +184,8 @@ void putback_movable_pages(struct list_head *l)
186 put_page(page); 184 put_page(page);
187 } else { 185 } else {
188 putback_lru_page(page); 186 putback_lru_page(page);
187 dec_node_page_state(page, NR_ISOLATED_ANON +
188 page_is_file_cache(page));
189 } 189 }
190 } 190 }
191} 191}
@@ -1121,8 +1121,15 @@ out:
1121 * restored. 1121 * restored.
1122 */ 1122 */
1123 list_del(&page->lru); 1123 list_del(&page->lru);
1124 dec_node_page_state(page, NR_ISOLATED_ANON + 1124
1125 page_is_file_cache(page)); 1125 /*
1126 * Compaction can migrate also non-LRU pages which are
1127 * not accounted to NR_ISOLATED_*. They can be recognized
1128 * as __PageMovable
1129 */
1130 if (likely(!__PageMovable(page)))
1131 dec_node_page_state(page, NR_ISOLATED_ANON +
1132 page_is_file_cache(page));
1126 } 1133 }
1127 1134
1128 /* 1135 /*