diff options
| -rw-r--r-- | fs/ext3/fsync.c | 8 | ||||
| -rw-r--r-- | fs/ext3/super.c | 13 |
2 files changed, 18 insertions, 3 deletions
diff --git a/fs/ext3/fsync.c b/fs/ext3/fsync.c index b31dbd4c46ad..1cb9c7e10c6f 100644 --- a/fs/ext3/fsync.c +++ b/fs/ext3/fsync.c | |||
| @@ -48,9 +48,13 @@ int ext3_sync_file(struct file *file, loff_t start, loff_t end, int datasync) | |||
| 48 | 48 | ||
| 49 | trace_ext3_sync_file_enter(file, datasync); | 49 | trace_ext3_sync_file_enter(file, datasync); |
| 50 | 50 | ||
| 51 | if (inode->i_sb->s_flags & MS_RDONLY) | 51 | if (inode->i_sb->s_flags & MS_RDONLY) { |
| 52 | /* Make sure that we read updated state */ | ||
| 53 | smp_rmb(); | ||
| 54 | if (EXT3_SB(inode->i_sb)->s_mount_state & EXT3_ERROR_FS) | ||
| 55 | return -EROFS; | ||
| 52 | return 0; | 56 | return 0; |
| 53 | 57 | } | |
| 54 | ret = filemap_write_and_wait_range(inode->i_mapping, start, end); | 58 | ret = filemap_write_and_wait_range(inode->i_mapping, start, end); |
| 55 | if (ret) | 59 | if (ret) |
| 56 | goto out; | 60 | goto out; |
diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 6356665a74bb..c47f14750722 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c | |||
| @@ -174,6 +174,11 @@ static void ext3_handle_error(struct super_block *sb) | |||
| 174 | if (test_opt (sb, ERRORS_RO)) { | 174 | if (test_opt (sb, ERRORS_RO)) { |
| 175 | ext3_msg(sb, KERN_CRIT, | 175 | ext3_msg(sb, KERN_CRIT, |
| 176 | "error: remounting filesystem read-only"); | 176 | "error: remounting filesystem read-only"); |
| 177 | /* | ||
| 178 | * Make sure updated value of ->s_mount_state will be visible | ||
| 179 | * before ->s_flags update. | ||
| 180 | */ | ||
| 181 | smp_wmb(); | ||
| 177 | sb->s_flags |= MS_RDONLY; | 182 | sb->s_flags |= MS_RDONLY; |
| 178 | } | 183 | } |
| 179 | ext3_commit_super(sb, es, 1); | 184 | ext3_commit_super(sb, es, 1); |
| @@ -291,8 +296,14 @@ void ext3_abort(struct super_block *sb, const char *function, | |||
| 291 | ext3_msg(sb, KERN_CRIT, | 296 | ext3_msg(sb, KERN_CRIT, |
| 292 | "error: remounting filesystem read-only"); | 297 | "error: remounting filesystem read-only"); |
| 293 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; | 298 | EXT3_SB(sb)->s_mount_state |= EXT3_ERROR_FS; |
| 294 | sb->s_flags |= MS_RDONLY; | ||
| 295 | set_opt(EXT3_SB(sb)->s_mount_opt, ABORT); | 299 | set_opt(EXT3_SB(sb)->s_mount_opt, ABORT); |
| 300 | /* | ||
| 301 | * Make sure updated value of ->s_mount_state will be visible | ||
| 302 | * before ->s_flags update. | ||
| 303 | */ | ||
| 304 | smp_wmb(); | ||
| 305 | sb->s_flags |= MS_RDONLY; | ||
| 306 | |||
| 296 | if (EXT3_SB(sb)->s_journal) | 307 | if (EXT3_SB(sb)->s_journal) |
| 297 | journal_abort(EXT3_SB(sb)->s_journal, -EIO); | 308 | journal_abort(EXT3_SB(sb)->s_journal, -EIO); |
| 298 | } | 309 | } |
