aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/pci/host/pci-dra7xx.c2
-rw-r--r--drivers/pci/host/pci-imx6.c12
-rw-r--r--drivers/pci/host/pcie-spear13xx.c3
3 files changed, 4 insertions, 13 deletions
diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
index 52e2da7b3cd7..199e29a044cd 100644
--- a/drivers/pci/host/pci-dra7xx.c
+++ b/drivers/pci/host/pci-dra7xx.c
@@ -396,7 +396,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
396 396
397 pm_runtime_enable(dev); 397 pm_runtime_enable(dev);
398 ret = pm_runtime_get_sync(dev); 398 ret = pm_runtime_get_sync(dev);
399 if (IS_ERR_VALUE(ret)) { 399 if (ret < 0) {
400 dev_err(dev, "pm_runtime_get_sync failed\n"); 400 dev_err(dev, "pm_runtime_get_sync failed\n");
401 goto err_get_sync; 401 goto err_get_sync;
402 } 402 }
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c
index 233a196c6e66..8f3a9813c4e5 100644
--- a/drivers/pci/host/pci-imx6.c
+++ b/drivers/pci/host/pci-imx6.c
@@ -117,11 +117,7 @@ static int pcie_phy_wait_ack(void __iomem *dbi_base, int addr)
117 val = addr << PCIE_PHY_CTRL_DATA_LOC; 117 val = addr << PCIE_PHY_CTRL_DATA_LOC;
118 writel(val, dbi_base + PCIE_PHY_CTRL); 118 writel(val, dbi_base + PCIE_PHY_CTRL);
119 119
120 ret = pcie_phy_poll_ack(dbi_base, 0); 120 return pcie_phy_poll_ack(dbi_base, 0);
121 if (ret)
122 return ret;
123
124 return 0;
125} 121}
126 122
127/* Read from the 16-bit PCIe PHY control registers (not memory-mapped) */ 123/* Read from the 16-bit PCIe PHY control registers (not memory-mapped) */
@@ -148,11 +144,7 @@ static int pcie_phy_read(void __iomem *dbi_base, int addr , int *data)
148 /* deassert Read signal */ 144 /* deassert Read signal */
149 writel(0x00, dbi_base + PCIE_PHY_CTRL); 145 writel(0x00, dbi_base + PCIE_PHY_CTRL);
150 146
151 ret = pcie_phy_poll_ack(dbi_base, 0); 147 return pcie_phy_poll_ack(dbi_base, 0);
152 if (ret)
153 return ret;
154
155 return 0;
156} 148}
157 149
158static int pcie_phy_write(void __iomem *dbi_base, int addr, int data) 150static int pcie_phy_write(void __iomem *dbi_base, int addr, int data)
diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
index c49fbdc0f6e4..98d2683181bc 100644
--- a/drivers/pci/host/pcie-spear13xx.c
+++ b/drivers/pci/host/pcie-spear13xx.c
@@ -223,8 +223,7 @@ static irqreturn_t spear13xx_pcie_irq_handler(int irq, void *arg)
223 status = readl(&app_reg->int_sts); 223 status = readl(&app_reg->int_sts);
224 224
225 if (status & MSI_CTRL_INT) { 225 if (status & MSI_CTRL_INT) {
226 if (!IS_ENABLED(CONFIG_PCI_MSI)) 226 BUG_ON(!IS_ENABLED(CONFIG_PCI_MSI));
227 BUG();
228 dw_handle_msi_irq(pp); 227 dw_handle_msi_irq(pp);
229 } 228 }
230 229