1 files changed, 175 insertions, 144 deletions

diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 1fe30da653c3..56883f48c2e4 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -3,6 +3,8 @@
     Philip Edelbrock <phil@netroedge.com>, and Mark D. Studebaker
     <mdsxyz123@yahoo.com>
     Copyright (C) 2007, 2008   Jean Delvare <khali@linux-fr.org>
+    Copyright (C) 2010         Intel Corporation,
+                               David Woodhouse <dwmw2@infradead.org>
 
     This program is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
@@ -55,8 +57,6 @@
   See the file Documentation/i2c/busses/i2c-i801 for details.
 */
 
-/* Note: we assume there can only be one I801, with one SMBus interface */
-
 #include <linux/module.h>
 #include <linux/pci.h>
 #include <linux/kernel.h>
@@ -70,16 +70,16 @@
 #include <linux/dmi.h>
 
 /* I801 SMBus address offsets */
-#define SMBHSTSTS       (0 + i801_smba)
-#define SMBHSTCNT       (2 + i801_smba)
-#define SMBHSTCMD       (3 + i801_smba)
-#define SMBHSTADD       (4 + i801_smba)
-#define SMBHSTDAT0      (5 + i801_smba)
-#define SMBHSTDAT1      (6 + i801_smba)
-#define SMBBLKDAT       (7 + i801_smba)
-#define SMBPEC          (8 + i801_smba)         /* ICH3 and later */
-#define SMBAUXSTS       (12 + i801_smba)        /* ICH4 and later */
-#define SMBAUXCTL       (13 + i801_smba)        /* ICH4 and later */
+#define SMBHSTSTS(p)    (0 + (p)->smba)
+#define SMBHSTCNT(p)    (2 + (p)->smba)
+#define SMBHSTCMD(p)    (3 + (p)->smba)
+#define SMBHSTADD(p)    (4 + (p)->smba)
+#define SMBHSTDAT0(p)   (5 + (p)->smba)
+#define SMBHSTDAT1(p)   (6 + (p)->smba)
+#define SMBBLKDAT(p)    (7 + (p)->smba)
+#define SMBPEC(p)       (8 + (p)->smba)         /* ICH3 and later */
+#define SMBAUXSTS(p)    (12 + (p)->smba)        /* ICH4 and later */
+#define SMBAUXCTL(p)    (13 + (p)->smba)        /* ICH4 and later */
 
 /* PCI Address Constants */
 #define SMBBAR          4
@@ -128,16 +128,20 @@
                                  SMBHSTSTS_BUS_ERR | SMBHSTSTS_DEV_ERR | \
                                  SMBHSTSTS_INTR)
 
-static unsigned long i801_smba;
-static unsigned char i801_original_hstcfg;
+struct i801_priv {
+        struct i2c_adapter adapter;
+        unsigned long smba;
+        unsigned char original_hstcfg;
+        struct pci_dev *pci_dev;
+        unsigned int features;
+};
+
 static struct pci_driver i801_driver;
-static struct pci_dev *I801_dev;
 
 #define FEATURE_SMBUS_PEC       (1 << 0)
 #define FEATURE_BLOCK_BUFFER    (1 << 1)
 #define FEATURE_BLOCK_PROC      (1 << 2)
 #define FEATURE_I2C_BLOCK_READ  (1 << 3)
-static unsigned int i801_features;
 
 static const char *i801_feature_names[] = {
         "SMBus PEC",
@@ -152,24 +156,24 @@ MODULE_PARM_DESC(disable_features, "Disable selected driver features");
 
 /* Make sure the SMBus host is ready to start transmitting.
    Return 0 if it is, -EBUSY if it is not. */
-static int i801_check_pre(void)
+static int i801_check_pre(struct i801_priv *priv)
 {
         int status;
 
-        status = inb_p(SMBHSTSTS);
+        status = inb_p(SMBHSTSTS(priv));
         if (status & SMBHSTSTS_HOST_BUSY) {
-                dev_err(&I801_dev->dev, "SMBus is busy, can't use it!\n");
+                dev_err(&priv->pci_dev->dev, "SMBus is busy, can't use it!\n");
                 return -EBUSY;
         }
 
         status &= STATUS_FLAGS;
         if (status) {
-                dev_dbg(&I801_dev->dev, "Clearing status flags (%02x)\n",
+                dev_dbg(&priv->pci_dev->dev, "Clearing status flags (%02x)\n",
                         status);
-                outb_p(status, SMBHSTSTS);
-                status = inb_p(SMBHSTSTS) & STATUS_FLAGS;
+                outb_p(status, SMBHSTSTS(priv));
+                status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
                 if (status) {
-                        dev_err(&I801_dev->dev,
+                        dev_err(&priv->pci_dev->dev,
                                 "Failed clearing status flags (%02x)\n",
                                 status);
                         return -EBUSY;
@@ -180,48 +184,50 @@ static int i801_check_pre(void)
 }
 
 /* Convert the status register to an error code, and clear it. */
-static int i801_check_post(int status, int timeout)
+static int i801_check_post(struct i801_priv *priv, int status, int timeout)
 {
         int result = 0;
 
         /* If the SMBus is still busy, we give up */
         if (timeout) {
-                dev_err(&I801_dev->dev, "Transaction timeout\n");
+                dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
                 /* try to stop the current command */
-                dev_dbg(&I801_dev->dev, "Terminating the current operation\n");
-                outb_p(inb_p(SMBHSTCNT) | SMBHSTCNT_KILL, SMBHSTCNT);
+                dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n");
+                outb_p(inb_p(SMBHSTCNT(priv)) | SMBHSTCNT_KILL,
+                       SMBHSTCNT(priv));
                 msleep(1);
-                outb_p(inb_p(SMBHSTCNT) & (~SMBHSTCNT_KILL), SMBHSTCNT);
+                outb_p(inb_p(SMBHSTCNT(priv)) & (~SMBHSTCNT_KILL),
+                       SMBHSTCNT(priv));
 
                 /* Check if it worked */
-                status = inb_p(SMBHSTSTS);
+                status = inb_p(SMBHSTSTS(priv));
                 if ((status & SMBHSTSTS_HOST_BUSY) ||
                     !(status & SMBHSTSTS_FAILED))
-                        dev_err(&I801_dev->dev,
+                        dev_err(&priv->pci_dev->dev,
                                 "Failed terminating the transaction\n");
-                outb_p(STATUS_FLAGS, SMBHSTSTS);
+                outb_p(STATUS_FLAGS, SMBHSTSTS(priv));
                 return -ETIMEDOUT;
         }
 
         if (status & SMBHSTSTS_FAILED) {
                 result = -EIO;
-                dev_err(&I801_dev->dev, "Transaction failed\n");
+                dev_err(&priv->pci_dev->dev, "Transaction failed\n");
         }
         if (status & SMBHSTSTS_DEV_ERR) {
                 result = -ENXIO;
-                dev_dbg(&I801_dev->dev, "No response\n");
+                dev_dbg(&priv->pci_dev->dev, "No response\n");
         }
         if (status & SMBHSTSTS_BUS_ERR) {
                 result = -EAGAIN;
-                dev_dbg(&I801_dev->dev, "Lost arbitration\n");
+                dev_dbg(&priv->pci_dev->dev, "Lost arbitration\n");
         }
 
         if (result) {
                 /* Clear error flags */
-                outb_p(status & STATUS_FLAGS, SMBHSTSTS);
-                status = inb_p(SMBHSTSTS) & STATUS_FLAGS;
+                outb_p(status & STATUS_FLAGS, SMBHSTSTS(priv));
+                status = inb_p(SMBHSTSTS(priv)) & STATUS_FLAGS;
                 if (status) {
-                        dev_warn(&I801_dev->dev, "Failed clearing status "
+                        dev_warn(&priv->pci_dev->dev, "Failed clearing status "
                                  "flags at end of transaction (%02x)\n",
                                  status);
                 }
@@ -230,86 +236,88 @@ static int i801_check_post(int status, int timeout)
         return result;
 }