aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorWang Nan <wangnan0@huawei.com>2016-01-14 23:00:14 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-01-15 14:31:59 -0500
commiteb807730c034090599135bc03578015ebf8974af (patch)
treef7a71e35258c42c971db1044fa8475ff977c81c2 /tools
parent7be43dfb1e617b87bf2d936d82c026be39b43910 (diff)
perf build: Pass O option to Makefile.perf in build-test
Unlike tools/perf/Makefile, tools/perf/Makefile.perf obey 'O' option when it is passed through cmdline only, due to code in tools/scripts/Makefile.include: ifneq ($(O),) ifeq ($(origin O), command line) ... ABSOLUTE_O := $(shell cd $(O) ; pwd) OUTPUT := $(ABSOLUTE_O)/$(if $(subdir),$(subdir)/) endif endif This patch passes 'O' to Makefile.perf through cmdline explicitly to make it follow O variable during build-test. 'make clean' should have identical 'O' option with 'make'. If not, config-clean may error. Signed-off-by: Wang Nan <wangnan0@huawei.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Zefan Li <lizefan@huawei.com> Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1452830421-77757-3-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/tests/make14
1 files changed, 11 insertions, 3 deletions
diff --git a/tools/perf/tests/make b/tools/perf/tests/make
index c0ee67906e0a..fc2a9a31113f 100644
--- a/tools/perf/tests/make
+++ b/tools/perf/tests/make
@@ -5,7 +5,7 @@ ifeq ($(MAKECMDGOALS),)
5# no target specified, trigger the whole suite 5# no target specified, trigger the whole suite
6all: 6all:
7 @echo "Testing Makefile"; $(MAKE) -sf tests/make MK=Makefile 7 @echo "Testing Makefile"; $(MAKE) -sf tests/make MK=Makefile
8 @echo "Testing Makefile.perf"; $(MAKE) -sf tests/make MK=Makefile.perf SET_PARALLEL=1 8 @echo "Testing Makefile.perf"; $(MAKE) -sf tests/make MK=Makefile.perf SET_PARALLEL=1 SET_O=1
9else 9else
10# run only specific test over 'Makefile' 10# run only specific test over 'Makefile'
11%: 11%:
@@ -13,6 +13,14 @@ else
13endif 13endif
14else 14else
15PERF := . 15PERF := .
16O_OPT :=
17
18ifneq ($(O),)
19 FULL_O := $(shell readlink -f $(O) || echo $(O))
20 ifeq ($(SET_O),1)
21 O_OPT := 'O=$(FULL_O)'
22 endif
23endif
16 24
17PARALLEL_OPT= 25PARALLEL_OPT=
18ifeq ($(SET_PARALLEL),1) 26ifeq ($(SET_PARALLEL),1)
@@ -256,12 +264,12 @@ endif
256 264
257MAKEFLAGS := --no-print-directory 265MAKEFLAGS := --no-print-directory
258 266
259clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null) 267clean := @(cd $(PERF); make -s -f $(MK) $(O_OPT) clean >/dev/null)
260 268
261$(run): 269$(run):
262 $(call clean) 270 $(call clean)
263 @TMP_DEST=$$(mktemp -d); \ 271 @TMP_DEST=$$(mktemp -d); \
264 cmd="cd $(PERF) && make -f $(MK) $(PARALLEL_OPT) DESTDIR=$$TMP_DEST $($@)"; \ 272 cmd="cd $(PERF) && make -f $(MK) $(PARALLEL_OPT) $(O_OPT) DESTDIR=$$TMP_DEST $($@)"; \
265 echo "- $@: $$cmd" && echo $$cmd > $@ && \ 273 echo "- $@: $$cmd" && echo $$cmd > $@ && \
266 ( eval $$cmd ) >> $@ 2>&1; \ 274 ( eval $$cmd ) >> $@ 2>&1; \
267 echo " test: $(call test,$@)" >> $@ 2>&1; \ 275 echo " test: $(call test,$@)" >> $@ 2>&1; \