aboutsummaryrefslogtreecommitdiffstats
path: root/tools/testing
diff options
context:
space:
mode:
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>2014-10-07 16:34:25 -0400
committerSteven Rostedt <rostedt@goodmis.org>2014-10-07 16:34:25 -0400
commitd832d743385dd5e735660951aa9d7d36a6a4176a (patch)
tree19d28a395d71ac95715c95416914e7cca324de88 /tools/testing
parent995bc4314071db148222497875be32d1eb73726d (diff)
ktest: Don't bother with bisect good or bad on replay
If git bisect reply is being used in the bisect tests, don't bother doing the git bisect good or git bisect bad calls. The git bisect reply will override them anyway, and that's called immediately after the other two. Going the git bisect (good|bad) is just a waste of time. Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'tools/testing')
-rwxr-xr-xtools/testing/ktest/ktest.pl14
1 files changed, 8 insertions, 6 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index c518b0fb6d01..bf1398180785 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2736,15 +2736,17 @@ sub bisect {
2736 run_command "git bisect start$start_files" or 2736 run_command "git bisect start$start_files" or
2737 dodie "could not start bisect"; 2737 dodie "could not start bisect";
2738 2738
2739 run_command "git bisect good $good" or
2740 dodie "could not set bisect good to $good";
2741
2742 run_git_bisect "git bisect bad $bad" or
2743 dodie "could not set bisect bad to $bad";
2744
2745 if (defined($replay)) { 2739 if (defined($replay)) {
2746 run_command "git bisect replay $replay" or 2740 run_command "git bisect replay $replay" or
2747 dodie "failed to run replay"; 2741 dodie "failed to run replay";
2742 } else {
2743
2744 run_command "git bisect good $good" or
2745 dodie "could not set bisect good to $good";
2746
2747 run_git_bisect "git bisect bad $bad" or
2748 dodie "could not set bisect bad to $bad";
2749
2748 } 2750 }
2749 2751
2750 if (defined($start)) { 2752 if (defined($start)) {