diff options
| author | Ingo Molnar <mingo@kernel.org> | 2017-11-29 01:12:36 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2017-11-29 01:15:09 -0500 |
| commit | 6e948c67c47211afcc65c9ccdeedbd5db5c57077 (patch) | |
| tree | 6fa7d1aa3191f1c06cdd866a6bc1982dbfeb5448 /tools/perf | |
| parent | 4fc31ba13d052c2933bf91095c063cf9a39effd0 (diff) | |
| parent | 1b3b5219abfd6a214e99018747e9fe98514b43ca (diff) | |
Merge branch 'perf/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent
Pull perf tooling fixes from Arnaldo Carvalho de Melo:
"- Fix window dimensions change handling in 'perf top' (Jiri Olsa)
- Fix 'perf record -c/-F' options for CPU event aliases (Andi Kleen)
- Generate PERF_RECORD_{MMAP,COMM,EXEC} with 'perf record --delay'
fixing symbol resolution for processes created, maps put in place
while --delay happens (Arnaldo Carvalho de Melo)
- Fix up leftover perf_evsel_stat usage via evsel->priv, plugging
a SEGV when using event groups as in:
$ perf stat -e '{cpu-clock,instructions}' workload
- Fix 'perf script --per-event-dump' for auxtrace synth evsels (Arnaldo Carvalho de Melo)
- Ignore kptr_restrict when not sampling the kernel (Arnaldo Carvalho de Melo)
- Synchronize kernel ABI headers wrt SPDX tags and ABI changes,
taking minimal action to handle new syscall args and silencing
perf build warnings (Arnaldo Carvalho de Melo, Ingo Molnar)
- Fix header.size for namespace events (Jiri Olsa)
- Fix a bug during strstart() conversion in 'perf help' (Namhyung Kim)
- Do not truncate instruction names at 6 chars in 'perf annotate', there
are really long instruction names in PPC (Ravi Bangoria)
- Fixup discontiguous/sparse numa nodes in 'perf bench numa' (Satheesh Rajendran)
- Fix an exit code of trace__symbols_init in 'perf trace' (Andrei Vagin)
- Fix 'perf test' entries on s/390 (Thomas Richter)
- Bring instruction decoder files used by Intel PT into line with the kernel,
silencing build warning (Adrian Hunter)"
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/perf')
| -rw-r--r-- | tools/perf/bench/numa.c | 56 | ||||
| -rw-r--r-- | tools/perf/builtin-help.c | 4 | ||||
| -rw-r--r-- | tools/perf/builtin-record.c | 42 | ||||
| -rw-r--r-- | tools/perf/builtin-report.c | 3 | ||||
| -rw-r--r-- | tools/perf/builtin-script.c | 31 | ||||
| -rw-r--r-- | tools/perf/builtin-top.c | 36 | ||||
| -rw-r--r-- | tools/perf/builtin-trace.c | 6 | ||||
| -rwxr-xr-x | tools/perf/tests/shell/trace+probe_libc_inet_pton.sh | 7 | ||||
| -rwxr-xr-x | tools/perf/tests/shell/trace+probe_vfs_getname.sh | 6 | ||||
| -rw-r--r-- | tools/perf/tests/task-exit.c | 4 | ||||
| -rw-r--r-- | tools/perf/trace/beauty/mmap.c | 3 | ||||
| -rw-r--r-- | tools/perf/util/annotate.c | 18 | ||||
| -rw-r--r-- | tools/perf/util/evlist.c | 14 | ||||
| -rw-r--r-- | tools/perf/util/evlist.h | 2 | ||||
| -rw-r--r-- | tools/perf/util/evsel.c | 14 | ||||
| -rw-r--r-- | tools/perf/util/evsel.h | 1 | ||||
| -rw-r--r-- | tools/perf/util/intel-pt-decoder/inat.h | 10 | ||||
| -rw-r--r-- | tools/perf/util/machine.c | 3 | ||||
| -rw-r--r-- | tools/perf/util/parse-events.c | 2 | ||||
| -rw-r--r-- | tools/perf/util/parse-events.h | 3 | ||||
| -rw-r--r-- | tools/perf/util/pmu.c | 5 |
21 files changed, 212 insertions, 58 deletions
diff --git a/tools/perf/bench/numa.c b/tools/perf/bench/numa.c index d95fdcc26f4b..944070e98a2c 100644 --- a/tools/perf/bench/numa.c +++ b/tools/perf/bench/numa.c | |||
| @@ -216,6 +216,47 @@ static const char * const numa_usage[] = { | |||
| 216 | NULL | 216 | NULL |
| 217 | }; | 217 | }; |
| 218 | 218 | ||
| 219 | /* | ||
| 220 | * To get number of numa nodes present. | ||
| 221 | */ | ||
| 222 | static int nr_numa_nodes(void) | ||
| 223 | { | ||
| 224 | int i, nr_nodes = 0; | ||
| 225 | |||
| 226 | for (i = 0; i < g->p.nr_nodes; i++) { | ||
| 227 | if (numa_bitmask_isbitset(numa_nodes_ptr, i)) | ||
| 228 | nr_nodes++; | ||
| 229 | } | ||
| 230 | |||
| 231 | return nr_nodes; | ||
| 232 | } | ||
| 233 | |||
| 234 | /* | ||
| 235 | * To check if given numa node is present. | ||
| 236 | */ | ||
| 237 | static int is_node_present(int node) | ||
| 238 | { | ||
| 239 | return numa_bitmask_isbitset(numa_nodes_ptr, node); | ||
| 240 | } | ||
| 241 | |||
| 242 | /* | ||
| 243 | * To check given numa node has cpus. | ||
| 244 | */ | ||
| 245 | static bool node_has_cpus(int node) | ||
| 246 | { | ||
| 247 | struct bitmask *cpu = numa_allocate_cpumask(); | ||
| 248 | unsigned int i; | ||
| 249 | |||
| 250 | if (cpu && !numa_node_to_cpus(node, cpu)) { | ||
| 251 | for (i = 0; i < cpu->size; i++) { | ||
| 252 | if (numa_bitmask_isbitset(cpu, i)) | ||
| 253 | return true; | ||
| 254 | } | ||
| 255 | } | ||
| 256 | |||
| 257 | return false; /* lets fall back to nocpus safely */ | ||
| 258 | } | ||
| 259 | |||
| 219 | static cpu_set_t bind_to_cpu(int target_cpu) | 260 | static cpu_set_t bind_to_cpu(int target_cpu) |
| 220 | { | 261 | { |
| 221 | cpu_set_t orig_mask, mask; | 262 | cpu_set_t orig_mask, mask; |
| @@ -244,12 +285,12 @@ static cpu_set_t bind_to_cpu(int target_cpu) | |||
| 244 | 285 | ||
| 245 | static cpu_set_t bind_to_node(int target_node) | 286 | static cpu_set_t bind_to_node(int target_node) |
| 246 | { | 287 | { |
| 247 | int cpus_per_node = g->p.nr_cpus/g->p.nr_nodes; | 288 | int cpus_per_node = g->p.nr_cpus / nr_numa_nodes(); |
| 248 | cpu_set_t orig_mask, mask; | 289 | cpu_set_t orig_mask, mask; |
| 249 | int cpu; | 290 | int cpu; |
| 250 | int ret; | 291 | int ret; |
| 251 | 292 | ||
| 252 | BUG_ON(cpus_per_node*g->p.nr_nodes != g->p.nr_cpus); | 293 | BUG_ON(cpus_per_node * nr_numa_nodes() != g->p.nr_cpus); |
| 253 | BUG_ON(!cpus_per_node); | 294 | BUG_ON(!cpus_per_node); |
| 254 | 295 | ||
| 255 | ret = sched_getaffinity(0, sizeof(orig_mask), &orig_mask); | 296 | ret = sched_getaffinity(0, sizeof(orig_mask), &orig_mask); |
| @@ -649,7 +690,7 @@ static int parse_setup_node_list(void) | |||
| 649 | int i; | 690 | int i; |
| 650 | 691 | ||
| 651 | for (i = 0; i < mul; i++) { | 692 | for (i = 0; i < mul; i++) { |
| 652 | if (t >= g->p.nr_tasks) { | 693 | if (t >= g->p.nr_tasks || !node_has_cpus(bind_node)) { |
| 653 | printf("\n# NOTE: ignoring bind NODEs starting at NODE#%d\n", bind_node); | 694 | printf("\n# NOTE: ignoring bind NODEs starting at NODE#%d\n", bind_node); |
| 654 | goto out; | 695 | goto out; |
| 655 | } | 696 | } |
| @@ -964,6 +1005,8 @@ static void calc_convergence(double runtime_ns_max, double *convergence) | |||
| 964 | sum = 0; | 1005 | sum = 0; |
| 965 | 1006 | ||
| 966 | for (node = 0; node < g->p.nr_nodes; node++) { | 1007 | for (node = 0; node < g->p.nr_nodes; node++) { |
| 1008 | if (!is_node_present(node)) | ||
| 1009 | continue; | ||
| 967 | nr = nodes[node]; | 1010 | nr = nodes[node]; |
| 968 | nr_min = min(nr, nr_min); | 1011 | nr_min = min(nr, nr_min); |
| 969 | nr_max = max(nr, nr_max); | 1012 | nr_max = max(nr, nr_max); |
| @@ -984,8 +1027,11 @@ static void calc_convergence(double runtime_ns_max, double *convergence) | |||
| 984 | process_groups = 0; | 1027 | process_groups = 0; |
| 985 | 1028 | ||
| 986 | for (node = 0; node < g->p.nr_nodes; node++) { | 1029 | for (node = 0; node < g->p.nr_nodes; node++) { |
| 987 | int processes = count_node_processes(node); | 1030 | int processes; |
| 988 | 1031 | ||
| 1032 | if (!is_node_present(node)) | ||
| 1033 | continue; | ||
| 1034 | processes = count_node_processes(node); | ||
| 989 | nr = nodes[node]; | 1035 | nr = nodes[node]; |
| 990 | tprintf(" %2d/%-2d", nr, processes); | 1036 | tprintf(" %2d/%-2d", nr, processes); |
| 991 | 1037 | ||
| @@ -1291,7 +1337,7 @@ static void print_summary(void) | |||
| 1291 | 1337 | ||
| 1292 | printf("\n ###\n"); | 1338 | printf("\n ###\n"); |
| 1293 | printf(" # %d %s will execute (on %d nodes, %d CPUs):\n", | 1339 | printf(" # %d %s will execute (on %d nodes, %d CPUs):\n", |
| 1294 | g->p.nr_tasks, g->p.nr_tasks == 1 ? "task" : "tasks", g->p.nr_nodes, g->p.nr_cpus); | 1340 | g->p.nr_tasks, g->p.nr_tasks == 1 ? "task" : "tasks", nr_numa_nodes(), g->p.nr_cpus); |
| 1295 | printf(" # %5dx %5ldMB global shared mem operations\n", | 1341 | printf(" # %5dx %5ldMB global shared mem operations\n", |
| 1296 | g->p.nr_loops, g->p.bytes_global/1024/1024); | 1342 | g->p.nr_loops, g->p.bytes_global/1024/1024); |
| 1297 | printf(" # %5dx %5ldMB process shared mem operations\n", | 1343 | printf(" # %5dx %5ldMB process shared mem operations\n", |
diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c index bd1fedef3d1c..a0f7ed2b869b 100644 --- a/tools/perf/builtin-help.c +++ b/tools/perf/builtin-help.c | |||
| @@ -284,7 +284,7 @@ static int perf_help_config(const char *var, const char *value, void *cb) | |||
| 284 | add_man_viewer(value); | 284 | add_man_viewer(value); |
| 285 | return 0; | 285 | return 0; |
| 286 | } | 286 | } |
| 287 | if (!strstarts(var, "man.")) | 287 | if (strstarts(var, "man.")) |
| 288 | return add_man_viewer_info(var, value); | 288 | return add_man_viewer_info(var, value); |
| 289 | 289 | ||
| 290 | return 0; | 290 | return 0; |
| @@ -314,7 +314,7 @@ static const char *cmd_to_page(const char *perf_cmd) | |||
| 314 | 314 | ||
| 315 | if (!perf_cmd) | 315 | if (!perf_cmd) |
| 316 | return "perf"; | 316 | return "perf"; |
| 317 | else if (!strstarts(perf_cmd, "perf")) | 317 | else if (strstarts(perf_cmd, "perf")) |
| 318 | return perf_cmd; | 318 | return perf_cmd; |
| 319 | 319 | ||
| 320 | return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s; | 320 | return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s; |
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 3d7f33e19df2..003255910c05 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c | |||
| @@ -339,6 +339,22 @@ static int record__open(struct record *rec) | |||
| 339 | struct perf_evsel_config_term *err_term; | 339 | struct perf_evsel_config_term *err_term; |
| 340 | int rc = 0; | 340 | int rc = 0; |
| 341 | 341 | ||
| 342 | /* | ||
| 343 | * For initial_delay we need to add a dummy event so that we can track | ||
| 344 | * PERF_RECORD_MMAP while we wait for the initial delay to enable the | ||
| 345 | * real events, the ones asked by the user. | ||
| 346 | */ | ||
| 347 | if (opts->initial_delay) { | ||
| 348 | if (perf_evlist__add_dummy(evlist)) | ||
| 349 | return -ENOMEM; | ||
| 350 | |||
| 351 | pos = perf_evlist__first(evlist); | ||
| 352 | pos->tracking = 0; | ||
| 353 | pos = perf_evlist__last(evlist); | ||
| 354 | pos->tracking = 1; | ||
| 355 | pos->attr.enable_on_exec = 1; | ||
| 356 | } | ||
| 357 | |||
| 342 | perf_evlist__config(evlist, opts, &callchain_param); | 358 | perf_evlist__config(evlist, opts, &callchain_param); |
| 343 | 359 | ||
| 344 | evlist__for_each_entry(evlist, pos) { | 360 | evlist__for_each_entry(evlist, pos) { |
| @@ -749,17 +765,19 @@ static int record__synthesize(struct record *rec, bool tail) | |||
| 749 | goto out; | 765 | goto out; |
| 750 | } | 766 | } |
| 751 | 767 | ||
| 752 | err = perf_event__synthesize_kernel_mmap(tool, process_synthesized_event, | 768 | if (!perf_evlist__exclude_kernel(rec->evlist)) { |
| 753 | machine); | 769 | err = perf_event__synthesize_kernel_mmap(tool, process_synthesized_event, |
| 754 | WARN_ONCE(err < 0, "Couldn't record kernel reference relocation symbol\n" | 770 | machine); |
| 755 | "Symbol resolution may be skewed if relocation was used (e.g. kexec).\n" | 771 | WARN_ONCE(err < 0, "Couldn't record kernel reference relocation symbol\n" |
| 756 | "Check /proc/kallsyms permission or run as root.\n"); | 772 | "Symbol resolution may be skewed if relocation was used (e.g. kexec).\n" |
| 757 | 773 | "Check /proc/kallsyms permission or run as root.\n"); | |
| 758 | err = perf_event__synthesize_modules(tool, process_synthesized_event, | 774 | |
| 759 | machine); | 775 | err = perf_event__synthesize_modules(tool, process_synthesized_event, |
| 760 | WARN_ONCE(err < 0, "Couldn't record kernel module information.\n" | 776 | machine); |
| 761 | "Symbol resolution may be skewed if relocation was used (e.g. kexec).\n" | 777 | WARN_ONCE(err < 0, "Couldn't record kernel module information.\n" |
| 762 | "Check /proc/modules permission or run as root.\n"); | 778 | "Symbol resolution may be skewed if relocation was used (e.g. kexec).\n" |
| 779 | "Check /proc/modules permission or run as root.\n"); | ||
| 780 | } | ||
| 763 | 781 | ||
| 764 | if (perf_guest) { | 782 | if (perf_guest) { |
| 765 | machines__process_guests(&session->machines, | 783 | machines__process_guests(&session->machines, |
| @@ -1693,7 +1711,7 @@ int cmd_record(int argc, const char **argv) | |||
| 1693 | 1711 | ||
| 1694 | err = -ENOMEM; | 1712 | err = -ENOMEM; |
| 1695 | 1713 | ||
| 1696 | if (symbol_conf.kptr_restrict) | 1714 | if (symbol_conf.kptr_restrict && !perf_evlist__exclude_kernel(rec->evlist)) |
| 1697 | pr_warning( | 1715 | pr_warning( |
| 1698 | "WARNING: Kernel address maps (/proc/{kallsyms,modules}) are restricted,\n" | 1716 | "WARNING: Kernel address maps (/proc/{kallsyms,modules}) are restricted,\n" |
| 1699 | "check /proc/sys/kernel/kptr_restrict.\n\n" | 1717 | "check /proc/sys/kernel/kptr_restrict.\n\n" |
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 1394cd8d96f7..af5dd038195e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
| @@ -441,6 +441,9 @@ static void report__warn_kptr_restrict(const struct report *rep) | |||
| 441 | struct map *kernel_map = machine__kernel_map(&rep->session->machines.host); | 441 | struct map *kernel_map = machine__kernel_map(&rep->session->machines.host); |
| 442 | struct kmap *kernel_kmap = kernel_map ? map__kmap(kernel_map) : NULL; | 442 | struct kmap *kernel_kmap = kernel_map ? map__kmap(kernel_map) : NULL; |
| 443 | 443 | ||
| 444 | if (perf_evlist__exclude_kernel(rep->session->evlist)) | ||
| 445 | return; | ||
| 446 | |||
| 444 | if (kernel_map == NULL || | 447 | if (kernel_map == NULL || |
| 445 | (kernel_map->dso->hit && | 448 | (kernel_map->dso->hit && |
| 446 | (kernel_kmap->ref_reloc_sym == NULL || | 449 | (kernel_kmap->ref_reloc_sym == NULL || |
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 68f36dc0344f..9b43bda45a41 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c | |||
| @@ -1955,6 +1955,16 @@ static int perf_script__fopen_per_event_dump(struct perf_script *script) | |||
| 1955 | struct perf_evsel *evsel; | 1955 | struct perf_evsel *evsel; |
| 1956 | 1956 | ||
| 1957 | evlist__for_each_entry(script->session->evlist, evsel) { | 1957 | evlist__for_each_entry(script->session->evlist, evsel) { |
| 1958 | /* | ||
| 1959 | * Already setup? I.e. we may be called twice in cases like | ||
| 1960 | * Intel PT, one for the intel_pt// and dummy events, then | ||
| 1961 | * for the evsels syntheized from the auxtrace info. | ||
| 1962 | * | ||
| 1963 | * Ses perf_script__process_auxtrace_info. | ||
| 1964 | */ | ||
| 1965 | if (evsel->priv != NULL) | ||
| 1966 | continue; | ||
| 1967 | |||
| 1958 | evsel->priv = perf_evsel_script__new(evsel, script->session->data); | 1968 | evsel->priv = perf_evsel_script__new(evsel, script->session->data); |
| 1959 | if (evsel->priv == NULL) | 1969 | if (evsel->priv == NULL) |
| 1960 | goto out_err_fclose; | 1970 | goto out_err_fclose; |
| @@ -2838,6 +2848,25 @@ int process_cpu_map_event(struct perf_tool *tool __maybe_unused, | |||
| 2838 | return set_maps(script); | 2848 | return set_maps(script); |
| 2839 | } | 2849 | } |
| 2840 | 2850 | ||
| 2851 | #ifdef HAVE_AUXTRACE_SUPPORT | ||
| 2852 | static int perf_script__process_auxtrace_info(struct perf_tool *tool, | ||
| 2853 | union perf_event *event, | ||
| 2854 | struct perf_session *session) | ||
| 2855 | { | ||
| 2856 | int ret = perf_event__process_auxtrace_info(tool, event, session); | ||
| 2857 | |||
| 2858 | if (ret == 0) { | ||
| 2859 | struct perf_script *script = container_of(tool, struct perf_script, tool); | ||
| 2860 | |||
| 2861 | ret = perf_script__setup_per_event_dump(script); | ||
| 2862 | } | ||
| 2863 | |||
| 2864 | return ret; | ||
| 2865 | } | ||
| 2866 | #else | ||
| 2867 | #define perf_script__process_auxtrace_info 0 | ||
| 2868 | #endif | ||
| 2869 | |||
| 2841 | int cmd_script(int argc, const char **argv) | 2870 | int cmd_script(int argc, const char **argv) |
| 2842 | { | 2871 | { |
| 2843 | bool show_full_info = false; | 2872 | bool show_full_info = false; |
| @@ -2866,7 +2895,7 @@ int cmd_script(int argc, const char **argv) | |||
| 2866 | .feature = perf_event__process_feature, | 2895 | .feature = perf_event__process_feature, |
| 2867 | .build_id = perf_event__process_build_id, | 2896 | .build_id = perf_event__process_build_id, |
| 2868 | .id_index = perf_event__process_id_index, | 2897 | .id_index = perf_event__process_id_index, |
| 2869 | .auxtrace_info = perf_event__process_auxtrace_info, | 2898 | .auxtrace_info = perf_script__process_auxtrace_info, |
| 2870 | .auxtrace = perf_event__process_auxtrace, | 2899 | .auxtrace = perf_event__process_auxtrace, |
| 2871 | .auxtrace_error = perf_event__process_auxtrace_error, | 2900 | .auxtrace_error = perf_event__process_auxtrace_error, |
| 2872 | .stat = perf_event__process_stat_event, | 2901 | .stat = perf_event__process_stat_event, |
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 477a8699f0b5..9e0d2645ae13 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c | |||
| @@ -77,6 +77,7 @@ | |||
| 77 | #include "sane_ctype.h" | 77 | #include "sane_ctype.h" |
| 78 | 78 | ||
| 79 | static volatile int done; | 79 | static volatile int done; |
| 80 | static volatile int resize; | ||
| 80 | 81 | ||
| 81 | #define HEADER_LINE_NR 5 | 82 | #define HEADER_LINE_NR 5 |
| 82 | 83 | ||
| @@ -85,11 +86,13 @@ static void perf_top__update_print_entries(struct perf_top *top) | |||
| 85 | top->print_entries = top->winsize.ws_row - HEADER_LINE_NR; | 86 | top->print_entries = top->winsize.ws_row - HEADER_LINE_NR; |
| 86 | } | 87 | } |
| 87 | 88 | ||
| 88 | static void perf_top__sig_winch(int sig __maybe_unused, | 89 | static void winch_sig(int sig __maybe_unused) |
| 89 | siginfo_t *info __maybe_unused, void *arg) | ||
| 90 | { | 90 | { |
| 91 | struct perf_top *top = arg; | 91 | resize = 1; |
| 92 | } | ||
| 92 | 93 | ||
| 94 | static void perf_top__resize(struct perf_top *top) | ||
| 95 | { | ||
| 93 | get_term_dimensions(&top->winsize); | 96 | get_term_dimensions(&top->winsize); |
| 94 | perf_top__update_print_entries(top); | 97 | perf_top__update_print_entries(top); |
| 95 | } | 98 | } |
| @@ -473,12 +476,8 @@ static bool perf_top__handle_keypress(struct perf_top *top, int c) | |||
| 473 | case 'e': | 476 | case 'e': |
| 474 | prompt_integer(&top->print_entries, "Enter display entries (lines)"); | 477 | prompt_integer(&top->print_entries, "Enter display entries (lines)"); |
| 475 | if (top->print_entries == 0) { | 478 | if (top->print_entries == 0) { |
| 476 | struct sigaction act = { | 479 | perf_top__resize(top); |
| 477 | .sa_sigaction = perf_top__sig_winch, | 480 | signal(SIGWINCH, winch_sig); |
| 478 | .sa_flags = SA_SIGINFO, | ||
| 479 | }; | ||
| 480 | perf_top__sig_winch(SIGWINCH, NULL, top); | ||
| 481 | sigaction(SIGWINCH, &act, NULL); | ||
| 482 | } else { | 481 | } else { |
| 483 | signal(SIGWINCH, SIG_DFL); | 482 | signal(SIGWINCH, SIG_DFL); |
| 484 | } | 483 | } |
| @@ -732,14 +731,16 @@ static void perf_event__process_sample(struct perf_tool *tool, | |||
| 732 | if (!machine->kptr_restrict_warned && | 731 | if (!machine->kptr_restrict_warned && |
| 733 | symbol_conf.kptr_restrict && | 732 | symbol_conf.kptr_restrict && |
| 734 | al.cpumode == PERF_RECORD_MISC_KERNEL) { | 733 | al.cpumode == PERF_RECORD_MISC_KERNEL) { |
| 735 | ui__warning( | 734 | if (!perf_evlist__exclude_kernel(top->session->evlist)) { |
| 735 | ui__warning( | ||
| 736 | "Kernel address maps (/proc/{kallsyms,modules}) are restricted.\n\n" | 736 | "Kernel address maps (/proc/{kallsyms,modules}) are restricted.\n\n" |
| 737 | "Check /proc/sys/kernel/kptr_restrict.\n\n" | 737 | "Check /proc/sys/kernel/kptr_restrict.\n\n" |
| 738 | "Kernel%s samples will not be resolved.\n", | 738 | "Kernel%s samples will not be resolved.\n", |
| 739 | al.map && !RB_EMPTY_ROOT(&al.map->dso->symbols[MAP__FUNCTION]) ? | 739 | al.map && !RB_EMPTY_ROOT(&al.map->dso->symbols[MAP__FUNCTION]) ? |
| 740 | " modules" : ""); | 740 | " modules" : ""); |
| 741 | if (use_browser <= 0) | 741 | if (use_browser <= 0) |
| 742 | sleep(5); | 742 | sleep(5); |
| 743 | } | ||
| 743 | machine->kptr_restrict_warned = true; | 744 | machine->kptr_restrict_warned = true; |
| 744 | } | 745 | } |
| 745 | 746 | ||
| @@ -1030,6 +1031,11 @@ static int __cmd_top(struct perf_top *top) | |||
| 1030 | 1031 | ||
| 1031 | if (hits == top->samples) | 1032 | if (hits == top->samples) |
| 1032 | ret = perf_evlist__poll(top->evlist, 100); | 1033 | ret = perf_evlist__poll(top->evlist, 100); |
| 1034 | |||
| 1035 | if (resize) { | ||
| 1036 | perf_top__resize(top); | ||
| 1037 | resize = 0; | ||
| 1038 | } | ||
| 1033 | } | 1039 | } |
| 1034 | 1040 | ||
| 1035 | ret = 0; | 1041 | ret = 0; |
| @@ -1352,12 +1358,8 @@ int cmd_top(int argc, const char **argv) | |||
| 1352 | 1358 | ||
| 1353 | get_term_dimensions(&top.winsize); | 1359 | get_term_dimensions(&top.winsize); |
| 1354 | if (top.print_entries == 0) { | 1360 | if (top.print_entries == 0) { |
| 1355 | struct sigaction act = { | ||
| 1356 | .sa_sigaction = perf_top__sig_winch, | ||
| 1357 | .sa_flags = SA_SIGINFO, | ||
| 1358 | }; | ||
| 1359 | perf_top__update_print_entries(&top); | 1361 | perf_top__update_print_entries(&top); |
| 1360 | sigaction(SIGWINCH, &act, NULL); | 1362 | signal(SIGWINCH, winch_sig); |
| 1361 | } | 1363 | } |
| 1362 | 1364 | ||
| 1363 | status = __cmd_top(&top); | 1365 | status = __cmd_top(&top); |
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index f2757d38c7d7..84debdbad327 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c | |||
| @@ -1152,12 +1152,14 @@ static int trace__symbols_init(struct trace *trace, struct perf_evlist *evlist) | |||
| 1152 | if (trace->host == NULL) | 1152 | if (trace->host == NULL) |
| 1153 | return -ENOMEM; | 1153 | return -ENOMEM; |
| 1154 | 1154 | ||
| 1155 | if (trace_event__register_resolver(trace->host, trace__machine__resolve_kernel_addr) < 0) | 1155 | err = trace_event__register_resolver(trace->host, trace__machine__resolve_kernel_addr); |
| 1156 | return -errno; | 1156 | if (err < 0) |
| 1157 | goto out; | ||
| 1157 | 1158 | ||
| 1158 | err = __machine__synthesize_threads(trace->host, &trace->tool, &trace->opts.target, | 1159 | err = __machine__synthesize_threads(trace->host, &trace->tool, &trace->opts.target, |
| 1159 | evlist->threads, trace__tool_process, false, | 1160 | evlist->threads, trace__tool_process, false, |
| 1160 | trace->opts.proc_map_timeout, 1); | 1161 | trace->opts.proc_map_timeout, 1); |
| 1162 | out: | ||
| 1161 | if (err) | 1163 | if (err) |
| 1162 | symbol__exit(); | 1164 | symbol__exit(); |
| 1163 | 1165 | ||
diff --git a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh index 7a84d73324e3..8b3da21a08f1 100755 --- a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh +++ b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh | |||
| @@ -10,8 +10,8 @@ | |||
| 10 | 10 | ||
| 11 | . $(dirname $0)/lib/probe.sh | 11 | . $(dirname $0)/lib/probe.sh |
| 12 | 12 | ||
| 13 | ld=$(realpath /lib64/ld*.so.* | uniq) | 13 | libc=$(grep -w libc /proc/self/maps | head -1 | sed -r 's/.*[[:space:]](\/.*)/\1/g') |
| 14 | libc=$(echo $ld | sed 's/ld/libc/g') | 14 | nm -g $libc 2>/dev/null | fgrep -q inet_pton || exit 254 |
| 15 | 15 | ||
| 16 | trace_libc_inet_pton_backtrace() { | 16 | trace_libc_inet_pton_backtrace() { |
| 17 | idx=0 | 17 | idx=0 |
| @@ -37,6 +37,9 @@ trace_libc_inet_pton_backtrace() { | |||
| 37 | done | 37 | done |
| 38 | } | 38 | } |
| 39 | 39 | ||
| 40 | # Check for IPv6 interface existence | ||
| 41 | ip a sh lo | fgrep -q inet6 || exit 2 | ||
| 42 | |||
| 40 | skip_if_no_perf_probe && \ | 43 | skip_if_no_perf_probe && \ |
| 41 | perf probe -q $libc inet_pton && \ | 44 | perf probe -q $libc inet_pton && \ |
| 42 | trace_libc_inet_pton_backtrace | 45 | trace_libc_inet_pton_backtrace |
diff --git a/tools/perf/tests/shell/trace+probe_vfs_getname.sh b/tools/perf/tests/shell/trace+probe_vfs_getname.sh index 2e68c5f120da..2a9ef080efd0 100755 --- a/tools/perf/tests/shell/trace+probe_vfs_getname.sh +++ b/tools/perf/tests/shell/trace+probe_vfs_getname.sh | |||
| @@ -17,8 +17,10 @@ skip_if_no_perf_probe || exit 2 | |||
| 17 | file=$(mktemp /tmp/temporary_file.XXXXX) | 17 | file=$(mktemp /tmp/temporary_file.XXXXX) |
| 18 | 18 | ||
| 19 | trace_open_vfs_getname() { | 19 | trace_open_vfs_getname() { |
| 20 | perf trace -e open touch $file 2>&1 | \ | 20 | test "$(uname -m)" = s390x && { svc="openat"; txt="dfd: +CWD, +"; } |
| 21 | egrep " +[0-9]+\.[0-9]+ +\( +[0-9]+\.[0-9]+ ms\): +touch\/[0-9]+ open\(filename: +${file}, +flags: CREAT\|NOCTTY\|NONBLOCK\|WRONLY, +mode: +IRUGO\|IWUGO\) += +[0-9]+$" | 21 | |
| 22 | perf trace -e ${svc:-open} touch $file 2>&1 | \ | ||
| 23 | egrep " +[0-9]+\.[0-9]+ +\( +[0-9]+\.[0-9]+ ms\): +touch\/[0-9]+ ${svc:-open}\(${txt}filename: +${file}, +flags: CREAT\|NOCTTY\|NONBLOCK\|WRONLY, +mode: +IRUGO\|IWUGO\) += +[0-9]+$" | ||
| 22 | } | 24 | } |
| 23 | 25 | ||
| 24 | 26 | ||
diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index bc4a7344e274..89c8e1604ca7 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c | |||
| @@ -84,7 +84,11 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused | |||
| 84 | 84 | ||
| 85 | evsel = perf_evlist__first(evlist); | 85 | evsel = perf_evlist__first(evlist); |
| 86 | evsel->attr.task = 1; | 86 | evsel->attr.task = 1; |
| 87 | #ifdef __s390x__ | ||
| 88 | evsel->attr.sample_freq = 1000000; | ||
| 89 | #else | ||
| 87 | evsel->attr.sample_freq = 1; | 90 | evsel->attr.sample_freq = 1; |
| 91 | #endif | ||
| 88 | evsel->attr.inherit = 0; | 92 | evsel->attr.inherit = 0; |
| 89 | evsel->attr.watermark = 0; | 93 | evsel->attr.watermark = 0; |
| 90 | evsel->attr.wakeup_events = 1; | 94 | evsel->attr.wakeup_events = 1; |
diff --git a/tools/perf/trace/beauty/mmap.c b/tools/perf/trace/beauty/mmap.c index 9e1668b2c5d7..417e3ecfe9d7 100644 --- a/tools/perf/trace/beauty/mmap.c +++ b/tools/perf/trace/beauty/mmap.c | |||
| @@ -62,6 +62,9 @@ static size_t syscall_arg__scnprintf_mmap_flags(char *bf, size_t size, | |||
| 62 | P_MMAP_FLAG(POPULATE); | 62 | P_MMAP_FLAG(POPULATE); |
| 63 | P_MMAP_FLAG(STACK); | 63 | P_MMAP_FLAG(STACK); |
| 64 | P_MMAP_FLAG(UNINITIALIZED); | 64 | P_MMAP_FLAG(UNINITIALIZED); |
| 65 | #ifdef MAP_SYNC | ||
| 66 | P_MMAP_FLAG(SYNC); | ||
| 67 | #endif | ||
| 65 | #undef P_MMAP_FLAG | 68 | #undef P_MMAP_FLAG |
| 66 | 69 | ||
| 67 | if (flags) | 70 | if (flags) |
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index da1c4c4a0dd8..3369c7830260 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c | |||
| @@ -165,7 +165,7 @@ static void ins__delete(struct ins_operands *ops) | |||
| 165 | static int ins__raw_scnprintf(struct ins *ins, char *bf, size_t size, | 165 | static int ins__raw_scnprintf(struct ins *ins, char *bf, size_t size, |
| 166 | struct ins_operands *ops) | 166 | struct ins_operands *ops) |
| 167 | { | 167 | { |
| 168 | return scnprintf(bf, size, "%-6.6s %s", ins->name, ops->raw); | 168 | return scnprintf(bf, size, "%-6s %s", ins->name, ops->raw); |
| 169 | } | 169 | } |
| 170 | 170 | ||
| 171 | int ins__scnprintf(struct ins *ins, char *bf, size_t size, | 171 | int ins__scnprintf(struct ins *ins, char *bf, size_t size, |
| @@ -230,12 +230,12 @@ static int call__scnprintf(struct ins *ins, char *bf, size_t size, | |||
| 230 | struct ins_operands *ops) | 230 | struct ins_operands *ops) |
| 231 | { | 231 | { |
| 232 | if (ops->target.name) | 232 | if (ops->target.name) |
| 233 | return scnprintf(bf, size, "%-6.6s %s", ins->name, ops->target.name); | 233 | return scnprintf(bf, size, "%-6s %s", ins->name, ops->target.name); |
| 234 | 234 | ||
| 235 | if (ops->target.addr == 0) | 235 | if (ops->target.addr == 0) |
| 236 | return ins__raw_scnprintf(ins, bf, size, ops); | 236 | return ins__raw_scnprintf(ins, bf, size, ops); |
| 237 | 237 | ||
| 238 | return scnprintf(bf, size, "%-6.6s *%" PRIx64, ins->name, ops->target.addr); | 238 | return scnprintf(bf, size, "%-6s *%" PRIx64, ins->name, ops->target.addr); |
| 239 | } | 239 | } |
| 240 | 240 | ||
| 241 | static struct ins_ops call_ops = { | 241 | static struct ins_ops call_ops = { |
| @@ -299,7 +299,7 @@ static int jump__scnprintf(struct ins *ins, char *bf, size_t size, | |||
| 299 | c++; | 299 | c++; |
| 300 | } | 300 | } |
| 301 | 301 | ||
| 302 | return scnprintf(bf, size, "%-6.6s %.*s%" PRIx64, | 302 | return scnprintf(bf, size, "%-6s %.*s%" PRIx64, |
| 303 | ins->name, c ? c - ops->raw : 0, ops->raw, | 303 | ins->name, c ? c - ops->raw : 0, ops->raw, |
| 304 | ops->target.offset); | 304 | ops->target.offset); |
| 305 | } | 305 | } |
| @@ -372,7 +372,7 @@ static int lock__scnprintf(struct ins *ins, char *bf, size_t size, | |||
| 372 | if (ops->locked.ins.ops == NULL) | 372 | if (ops->locked.ins.ops == NULL) |
| 373 | return ins__raw_scnprintf(ins, bf, size, ops); | 373 | return ins__raw_scnprintf(ins, bf, size, ops); |
| 374 | 374 | ||
| 375 | printed = scnprintf(bf, size, "%-6.6s ", ins->name); | 375 | printed = scnprintf(bf, size, "%-6s ", ins->name); |
| 376 | return printed + ins__scnprintf(&ops->locked.ins, bf + printed, | 376 | return printed + ins__scnprintf(&ops->locked.ins, bf + printed, |
| 377 | size - printed, ops->locked.ops); | 377 | size - printed, ops->locked.ops); |
| 378 | } | 378 | } |
| @@ -448,7 +448,7 @@ out_free_source: | |||
| 448 | static int mov__scnprintf(struct ins *ins, char *bf, size_t size, | 448 | static int mov__scnprintf(struct ins *ins, char *bf, size_t size, |
| 449 | struct ins_operands *ops) | 449 | struct ins_operands *ops) |
| 450 | { | 450 | { |
| 451 | return scnprintf(bf, size, "%-6.6s %s,%s", ins->name, | 451 | return scnprintf(bf, size, "%-6s %s,%s", ins->name, |
| 452 | ops->source.name ?: ops->source.raw, | 452 | ops->source.name ?: ops->source.raw, |
| 453 | ops->target.name ?: ops->target.raw); | 453 | ops->target.name ?: ops->target.raw); |
| 454 | } | 454 | } |
| @@ -488,7 +488,7 @@ static int dec__parse(struct arch *arch __maybe_unused, struct ins_operands *ops | |||
| 488 | static int dec__scnprintf(struct ins *ins, char *bf, size_t size, | 488 | static int dec__scnprintf(struct ins *ins, char *bf, size_t size, |
| 489 | struct ins_operands *ops) | 489 | struct ins_operands *ops) |
| 490 | { | 490 | { |
| 491 | return scnprintf(bf, size, "%-6.6s %s", ins->name, | 491 | return scnprintf(bf, size, "%-6s %s", ins->name, |
| 492 | ops->target.name ?: ops->target.raw); | 492 | ops->target.name ?: ops->target.raw); |
| 493 | } | 493 | } |
| 494 | 494 | ||
| @@ -500,7 +500,7 @@ static struct ins_ops dec_ops = { | |||
| 500 | static int nop__scnprintf(struct ins *ins __maybe_unused, char *bf, size_t size, | 500 | static int nop__scnprintf(struct ins *ins __maybe_unused, char *bf, size_t size, |
| 501 | struct ins_operands *ops __maybe_unused) | 501 | struct ins_operands *ops __maybe_unused) |
| 502 | { | 502 | { |
| 503 | return scnprintf(bf, size, "%-6.6s", "nop"); | 503 | return scnprintf(bf, size, "%-6s", "nop"); |
| 504 | } | 504 | } |
| 505 | 505 | ||
| 506 | static struct ins_ops nop_ops = { | 506 | static struct ins_ops nop_ops = { |
| @@ -924,7 +924,7 @@ void disasm_line__free(struct disasm_line *dl) | |||
| 924 | int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw) | 924 | int disasm_line__scnprintf(struct disasm_line *dl, char *bf, size_t size, bool raw) |
| 925 | { | 925 | { |
| 926 | if (raw || !dl->ins.ops) | 926 | if (raw || !dl->ins.ops) |
| 927 | return scnprintf(bf, size, "%-6.6s %s", dl->ins.name, dl->ops.raw); | 927 | return scnprintf(bf, size, "%-6s %s", dl->ins.name, dl->ops.raw); |
| 928 | 928 | ||
| 929 | return ins__scnprintf(&dl->ins, bf, size, &dl->ops); | 929 | return ins__scnprintf(&dl->ins, bf, size, &dl->ops); |
| 930 | } | 930 | } |
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index c6c891e154a6..b62e523a7035 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c | |||
| @@ -257,7 +257,7 @@ int perf_evlist__add_dummy(struct perf_evlist *evlist) | |||
| 257 | .config = PERF_COUNT_SW_DUMMY, | 257 | .config = PERF_COUNT_SW_DUMMY, |
| 258 | .size = sizeof(attr), /* to capture ABI version */ | 258 | .size = sizeof(attr), /* to capture ABI version */ |
| 259 | }; | 259 | }; |
| 260 | struct perf_evsel *evsel = perf_evsel__new(&attr); | 260 | struct perf_evsel *evsel = perf_evsel__new_idx(&attr, evlist->nr_entries); |
| 261 | 261 | ||
| 262 | if (evsel == NULL) | 262 | if (evsel == NULL) |
| 263 | return -ENOMEM; | 263 | return -ENOMEM; |
| @@ -1786,3 +1786,15 @@ void perf_evlist__toggle_bkw_mmap(struct perf_evlist *evlist, | |||
| 1786 | state_err: | 1786 | state_err: |
| 1787 | return; | 1787 | return; |
| 1788 | } | 1788 | } |
| 1789 | |||
| 1790 | bool perf_evlist__exclude_kernel(struct perf_evlist *evlist) | ||
| 1791 | { | ||
| 1792 | struct perf_evsel *evsel; | ||
| 1793 | |||
| 1794 | evlist__for_each_entry(evlist, evsel) { | ||
| 1795 | if (!evsel->attr.exclude_kernel) | ||
| 1796 | return false; | ||
| 1797 | } | ||
| 1798 | |||
| 1799 | return true; | ||
| 1800 | } | ||
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index e72ae64c11ac..491f69542920 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h | |||
| @@ -312,4 +312,6 @@ perf_evlist__find_evsel_by_str(struct perf_evlist *evlist, const char *str); | |||
| 312 | 312 | ||
| 313 | struct perf_evsel *perf_evlist__event2evsel(struct perf_evlist *evlist, | 313 | struct perf_evsel *perf_evlist__event2evsel(struct perf_evlist *evlist, |
| 314 | union perf_event *event); | 314 | union perf_event *event); |
| 315 | |||
| 316 | bool perf_evlist__exclude_kernel(struct perf_evlist *evlist); | ||
| 315 | #endif /* __PERF_EVLIST_H */ | 317 | #endif /* __PERF_EVLIST_H */ |
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index f894893c203d..d5fbcf8c7aa7 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c | |||
| @@ -733,12 +733,16 @@ static void apply_config_terms(struct perf_evsel *evsel, | |||
| 733 | list_for_each_entry(term, config_terms, list) { | 733 | list_for_each_entry(term, config_terms, list) { |
| 734 | switch (term->type) { | 734 | switch (term->type) { |
| 735 | case PERF_EVSEL__CONFIG_TERM_PERIOD: | 735 | case PERF_EVSEL__CONFIG_TERM_PERIOD: |
| 736 | attr->sample_period = term->val.period; | 736 | if (!(term->weak && opts->user_interval != ULLONG_MAX)) { |
| 737 | attr->freq = 0; | 737 | attr->sample_period = term->val.period; |
| 738 | attr->freq = 0; | ||
| 739 | } | ||
| 738 | break; | 740 | break; |
| 739 | case PERF_EVSEL__CONFIG_TERM_FREQ: | 741 | case PERF_EVSEL__CONFIG_TERM_FREQ: |
| 740 | attr->sample_freq = term->val.freq; | 742 | if (!(term->weak && opts->user_freq != UINT_MAX)) { |
| 741 | attr->freq = 1; | 743 | attr->sample_freq = term->val.freq; |
| 744 | attr->freq = 1; | ||
| 745 | } | ||
| 742 | break; | 746 | break; |
| 743 | case PERF_EVSEL__CONFIG_TERM_TIME: | 747 | case PERF_EVSEL__CONFIG_TERM_TIME: |
| 744 | if (term->val.time) | 748 | if (term->val.time) |
| @@ -1371,7 +1375,7 @@ perf_evsel__process_group_data(struct perf_evsel *leader, | |||
| 1371 | static int | 1375 | static int |
| 1372 | perf_evsel__read_group(struct perf_evsel *leader, int cpu, int thread) | 1376 | perf_evsel__read_group(struct perf_evsel *leader, int cpu, int thread) |
| 1373 | { | 1377 | { |
| 1374 | struct perf_stat_evsel *ps = leader->priv; | 1378 | struct perf_stat_evsel *ps = leader->stats; |
| 1375 | u64 read_format = leader->attr.read_format; | 1379 | u64 read_format = leader->attr.read_format; |
| 1376 | int size = perf_evsel__read_size(leader); | 1380 | int size = perf_evsel__read_size(leader); |
| 1377 | u64 *data = ps->group_data; | 1381 | u64 *data = ps->group_data; |
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 9277df96ffda..157f49e8a772 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h | |||
| @@ -67,6 +67,7 @@ struct perf_evsel_config_term { | |||
| 67 | bool overwrite; | 67 | bool overwrite; |
| 68 | char *branch; | 68 | char *branch; |
| 69 | } val; | 69 | } val; |
| 70 | bool weak; | ||
| 70 | }; | 71 | }; |
| 71 | 72 | ||
| 72 | struct perf_stat_evsel; | 73 | struct perf_stat_evsel; |
diff --git a/tools/perf/util/intel-pt-decoder/inat.h b/tools/perf/util/intel-pt-decoder/inat.h index 125ecd2a300d..52dc8d911173 100644 --- a/tools/perf/util/intel-pt-decoder/inat.h +++ b/tools/perf/util/intel-pt-decoder/inat.h | |||
| @@ -97,6 +97,16 @@ | |||
| 97 | #define INAT_MAKE_GROUP(grp) ((grp << INAT_GRP_OFFS) | INAT_MODRM) | 97 | #define INAT_MAKE_GROUP(grp) ((grp << INAT_GRP_OFFS) | INAT_MODRM) |
| 98 | #define INAT_MAKE_IMM(imm) (imm << INAT_IMM_OFFS) | 98 | #define INAT_MAKE_IMM(imm) (imm << INAT_IMM_OFFS) |
| 99 | 99 | ||
| 100 | /* Identifiers for segment registers */ | ||
| 101 | #define INAT_SEG_REG_IGNORE 0 | ||
| 102 | #define INAT_SEG_REG_DEFAULT 1 | ||
| 103 | #define INAT_SEG_REG_CS 2 | ||
| 104 | #define INAT_SEG_REG_SS 3 | ||
| 105 | #define INAT_SEG_REG_DS 4 | ||
| 106 | #define INAT_SEG_REG_ES 5 | ||
| 107 | #define INAT_SEG_REG_FS 6 | ||
| 108 | #define INAT_SEG_REG_GS 7 | ||
| 109 | |||
| 100 | /* Attribute search APIs */ | 110 | /* Attribute search APIs */ |
| 101 | extern insn_attr_t inat_get_opcode_attribute(insn_byte_t opcode); | 111 | extern insn_attr_t inat_get_opcode_attribute(insn_byte_t opcode); |
| 102 | extern int inat_get_last_prefix_id(insn_byte_t last_pfx); | 112 | extern int inat_get_last_prefix_id(insn_byte_t last_pfx); |
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 6a8d03c3d9b7..270f3223c6df 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c | |||
| @@ -172,6 +172,9 @@ void machine__exit(struct machine *machine) | |||
| 172 | { | 172 | { |
| 173 | int i; | 173 | int i; |
| 174 | 174 | ||
| 175 | if (machine == NULL) | ||
| 176 | return; | ||
| 177 | |||
| 175 | machine__destroy_kernel_maps(machine); | 178 | machine__destroy_kernel_maps(machine); |
| 176 | map_groups__exit(&machine->kmaps); | 179 | map_groups__exit(&machine->kmaps); |
| 177 | dsos__exit(&machine->dsos); | 180 | dsos__exit(&machine->dsos); |
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index a7fcd95961ef..170316795a18 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c | |||
| @@ -1116,6 +1116,7 @@ do { \ | |||
| 1116 | INIT_LIST_HEAD(&__t->list); \ | 1116 | INIT_LIST_HEAD(&__t->list); \ |
| 1117 | __t->type = PERF_EVSEL__CONFIG_TERM_ ## __type; \ | 1117 | __t->type = PERF_EVSEL__CONFIG_TERM_ ## __type; \ |
| 1118 | __t->val.__name = __val; \ | 1118 | __t->val.__name = __val; \ |
| 1119 | __t->weak = term->weak; \ | ||
| 1119 | list_add_tail(&__t->list, head_terms); \ | 1120 | list_add_tail(&__t->list, head_terms); \ |
| 1120 | } while (0) | 1121 | } while (0) |
| 1121 | 1122 | ||
| @@ -2410,6 +2411,7 @@ static int new_term(struct parse_events_term **_term, | |||
| 2410 | 2411 | ||
| 2411 | *term = *temp; | 2412 | *term = *temp; |
| 2412 | INIT_LIST_HEAD(&term->list); | 2413 | INIT_LIST_HEAD(&term->list); |
| 2414 | term->weak = false; | ||
| 2413 | 2415 | ||
| 2414 | switch (term->type_val) { | 2416 | switch (term->type_val) { |
| 2415 | case PARSE_EVENTS__TERM_TYPE_NUM: | 2417 | case PARSE_EVENTS__TERM_TYPE_NUM: |
diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h index be337c266697..88108cd11b4c 100644 --- a/tools/perf/util/parse-events.h +++ b/tools/perf/util/parse-events.h | |||
| @@ -101,6 +101,9 @@ struct parse_events_term { | |||
| 101 | /* error string indexes for within parsed string */ | 101 | /* error string indexes for within parsed string */ |
| 102 | int err_term; | 102 | int err_term; |
| 103 | int err_val; | 103 | int err_val; |
| 104 | |||
| 105 | /* Coming from implicit alias */ | ||
| 106 | bool weak; | ||
| 104 | }; | 107 | }; |
| 105 | 108 | ||
| 106 | struct parse_events_error { | 109 | struct parse_events_error { |
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 07cb2ac041d7..80fb1593913a 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c | |||
| @@ -405,6 +405,11 @@ static int pmu_alias_terms(struct perf_pmu_alias *alias, | |||
| 405 | parse_events_terms__purge(&list); | 405 | parse_events_terms__purge(&list); |
| 406 | return ret; | 406 | return ret; |
| 407 | } | 407 | } |
| 408 | /* | ||
| 409 | * Weak terms don't override command line options, | ||
| 410 | * which we don't want for implicit terms in aliases. | ||
| 411 | */ | ||
| 412 | cloned->weak = true; | ||
| 408 | list_add_tail(&cloned->list, &list); | 413 | list_add_tail(&cloned->list, &list); |
| 409 | } | 414 | } |
| 410 | list_splice(&list, terms); | 415 | list_splice(&list, terms); |
