aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf
diff options
context:
space:
mode:
authorNamhyung Kim <namhyung@kernel.org>2015-11-27 12:32:37 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2015-11-27 14:56:32 -0500
commit25b1606be1a910a63a23c3d1006581c9aad4e6e3 (patch)
tree3ee87b403a6184ad4aecf78310563d15df0d32ef /tools/perf
parente37df6c76cb19971f1228bfaff504d8a3ea6f748 (diff)
perf report: Show error message when processing sample fails
Currently when perf fails to process samples for some reason, it doesn't show any message about the failure. This is very inconvenient for users especially on TUI as screen is reset after the failure. Reported-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Namhyung Kim <namhyung@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1448645559-31167-1-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf')
-rw-r--r--tools/perf/builtin-report.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 8a9c6908f54e..af5db885ea9c 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep)
513 if (rep->cpu_list) { 513 if (rep->cpu_list) {
514 ret = perf_session__cpu_bitmap(session, rep->cpu_list, 514 ret = perf_session__cpu_bitmap(session, rep->cpu_list,
515 rep->cpu_bitmap); 515 rep->cpu_bitmap);
516 if (ret) 516 if (ret) {
517 ui__error("failed to set cpu bitmap\n");
517 return ret; 518 return ret;
519 }
518 } 520 }
519 521
520 if (rep->show_threads) 522 if (rep->show_threads)
521 perf_read_values_init(&rep->show_threads_values); 523 perf_read_values_init(&rep->show_threads_values);
522 524
523 ret = report__setup_sample_type(rep); 525 ret = report__setup_sample_type(rep);
524 if (ret) 526 if (ret) {
527 /* report__setup_sample_type() already showed error message */
525 return ret; 528 return ret;
529 }
526 530
527 ret = perf_session__process_events(session); 531 ret = perf_session__process_events(session);
528 if (ret) 532 if (ret) {
533 ui__error("failed to process sample\n");
529 return ret; 534 return ret;
535 }
530 536
531 report__warn_kptr_restrict(rep); 537 report__warn_kptr_restrict(rep);
532 538