diff options
author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2014-07-04 07:43:48 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-07-07 15:55:24 -0400 |
commit | d400a68d1f1e7a1fc7c5caf9024d4e67b218558d (patch) | |
tree | cba65b9040c912b23d467e9ddf79b23b35fa0c27 /tools/perf/util/trace-event-info.c | |
parent | f8d9ccde2be4c24bfb8787af36a59a981b00a02d (diff) |
perf tools: Convert open coded equivalents to asprintf()
The following snippet
V = malloc(S);
if (!V) { }
sprintf(V, ...)
Can be easily changed to a one line:
if (asprintf(&V, ...) < 0) { }
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Link: http://lkml.kernel.org/r/1404474229-15272-1-git-send-email-andriy.shevchenko@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/trace-event-info.c')
-rw-r--r-- | tools/perf/util/trace-event-info.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 7e6fcfe8b438..c3bba883f5c3 100644 --- a/tools/perf/util/trace-event-info.c +++ b/tools/perf/util/trace-event-info.c | |||
@@ -191,12 +191,10 @@ static int copy_event_system(const char *sys, struct tracepoint_path *tps) | |||
191 | strcmp(dent->d_name, "..") == 0 || | 191 | strcmp(dent->d_name, "..") == 0 || |
192 | !name_in_tp_list(dent->d_name, tps)) | 192 | !name_in_tp_list(dent->d_name, tps)) |
193 | continue; | 193 | continue; |
194 | format = malloc(strlen(sys) + strlen(dent->d_name) + 10); | 194 | if (asprintf(&format, "%s/%s/format", sys, dent->d_name) < 0) { |
195 | if (!format) { | ||
196 | err = -ENOMEM; | 195 | err = -ENOMEM; |
197 | goto out; | 196 | goto out; |
198 | } | 197 | } |
199 | sprintf(format, "%s/%s/format", sys, dent->d_name); | ||
200 | ret = stat(format, &st); | 198 | ret = stat(format, &st); |
201 | free(format); | 199 | free(format); |
202 | if (ret < 0) | 200 | if (ret < 0) |
@@ -217,12 +215,10 @@ static int copy_event_system(const char *sys, struct tracepoint_path *tps) | |||
217 | strcmp(dent->d_name, "..") == 0 || | 215 | strcmp(dent->d_name, "..") == 0 || |
218 | !name_in_tp_list(dent->d_name, tps)) | 216 | !name_in_tp_list(dent->d_name, tps)) |
219 | continue; | 217 | continue; |
220 | format = malloc(strlen(sys) + strlen(dent->d_name) + 10); | 218 | if (asprintf(&format, "%s/%s/format", sys, dent->d_name) < 0) { |
221 | if (!format) { | ||
222 | err = -ENOMEM; | 219 | err = -ENOMEM; |
223 | goto out; | 220 | goto out; |
224 | } | 221 | } |
225 | sprintf(format, "%s/%s/format", sys, dent->d_name); | ||
226 | ret = stat(format, &st); | 222 | ret = stat(format, &st); |
227 | 223 | ||
228 | if (ret >= 0) { | 224 | if (ret >= 0) { |
@@ -317,12 +313,10 @@ static int record_event_files(struct tracepoint_path *tps) | |||
317 | strcmp(dent->d_name, "ftrace") == 0 || | 313 | strcmp(dent->d_name, "ftrace") == 0 || |
318 | !system_in_tp_list(dent->d_name, tps)) | 314 | !system_in_tp_list(dent->d_name, tps)) |
319 | continue; | 315 | continue; |
320 | sys = malloc(strlen(path) + strlen(dent->d_name) + 2); | 316 | if (asprintf(&sys, "%s/%s", path, dent->d_name) < 0) { |
321 | if (!sys) { | ||
322 | err = -ENOMEM; | 317 | err = -ENOMEM; |
323 | goto out; | 318 | goto out; |
324 | } | 319 | } |
325 | sprintf(sys, "%s/%s", path, dent->d_name); | ||
326 | ret = stat(sys, &st); | 320 | ret = stat(sys, &st); |
327 | if (ret >= 0) { | 321 | if (ret >= 0) { |
328 | ssize_t size = strlen(dent->d_name) + 1; | 322 | ssize_t size = strlen(dent->d_name) + 1; |