aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util/annotate.c
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2016-11-18 14:54:10 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2016-11-25 08:38:56 -0500
commitacc9bfb5fae5c48ca875911d87d8d8a9d886bb66 (patch)
tree56cfb2d9ecabe8ab458089e412cde5b893dd90d0 /tools/perf/util/annotate.c
parent0781ea923445405a45464842e9ee0e30f76cb84b (diff)
perf annotate: Improve support for ARM
By using arch->init() to set up some regular expressions to associate ins_ops to ARM instructions, ditching that old table that has instructions not present on ARM. Take advantage of having an arch->init() to hide more arm specific stuff from the common code, like the objdump details. The regular expressions comes from a patch written by Kim Phillips. Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Chris Riyder <chris.ryder@arm.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kim Phillips <kim.phillips@arm.com> Cc: Markus Trippelsdorf <markus@trippelsdorf.de> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Cc: Taeung Song <treeze.taeung@gmail.com> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-77m7lufz9ajjimkrebtg5ead@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/annotate.c')
-rw-r--r--tools/perf/util/annotate.c9
1 files changed, 2 insertions, 7 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 1e96549650d7..bad44db7dd67 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -84,7 +84,7 @@ grow_from_non_allocated_table:
84 goto out_update_instructions; 84 goto out_update_instructions;
85} 85}
86 86
87static __maybe_unused int arch__associate_ins_ops(struct arch* arch, const char *name, struct ins_ops *ops) 87static int arch__associate_ins_ops(struct arch* arch, const char *name, struct ins_ops *ops)
88{ 88{
89 struct ins *ins; 89 struct ins *ins;
90 90
@@ -110,12 +110,7 @@ static __maybe_unused int arch__associate_ins_ops(struct arch* arch, const char
110static struct arch architectures[] = { 110static struct arch architectures[] = {
111 { 111 {
112 .name = "arm", 112 .name = "arm",
113 .instructions = arm__instructions, 113 .init = arm__annotate_init,
114 .nr_instructions = ARRAY_SIZE(arm__instructions),
115 .objdump = {
116 .comment_char = ';',
117 .skip_functions_char = '+',
118 },
119 }, 114 },
120 { 115 {
121 .name = "x86", 116 .name = "x86",