diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-09-11 01:09:30 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-10-09 15:01:44 -0400 |
commit | 86c98cab5a3137376ea7df5ffa5bd52e545fee95 (patch) | |
tree | 35e8a5fe7d0e1df6f1b00d4d9b5eaf63dc38299f /tools/perf/util/annotate.c | |
parent | 58d91a0068694a5ba3efc99e88ce6b4b0dd0d085 (diff) |
perf annotate: Pass dso instead of dso_name to get_srcline()
This is a preparation of next change. No functional changes are
intended.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1378876173-13363-7-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/annotate.c')
-rw-r--r-- | tools/perf/util/annotate.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index d48297d77e19..d73e8008aada 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c | |||
@@ -1081,8 +1081,7 @@ static void symbol__free_source_line(struct symbol *sym, int len) | |||
1081 | /* Get the filename:line for the colored entries */ | 1081 | /* Get the filename:line for the colored entries */ |
1082 | static int symbol__get_source_line(struct symbol *sym, struct map *map, | 1082 | static int symbol__get_source_line(struct symbol *sym, struct map *map, |
1083 | struct perf_evsel *evsel, | 1083 | struct perf_evsel *evsel, |
1084 | struct rb_root *root, int len, | 1084 | struct rb_root *root, int len) |
1085 | const char *filename) | ||
1086 | { | 1085 | { |
1087 | u64 start; | 1086 | u64 start; |
1088 | int i, k; | 1087 | int i, k; |
@@ -1131,7 +1130,7 @@ static int symbol__get_source_line(struct symbol *sym, struct map *map, | |||
1131 | goto next; | 1130 | goto next; |
1132 | 1131 | ||
1133 | offset = start + i; | 1132 | offset = start + i; |
1134 | src_line->path = get_srcline(filename, offset); | 1133 | src_line->path = get_srcline(map->dso, offset); |
1135 | insert_source_line(&tmp_root, src_line); | 1134 | insert_source_line(&tmp_root, src_line); |
1136 | 1135 | ||
1137 | next: | 1136 | next: |
@@ -1338,7 +1337,6 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, | |||
1338 | bool full_paths, int min_pcnt, int max_lines) | 1337 | bool full_paths, int min_pcnt, int max_lines) |
1339 | { | 1338 | { |
1340 | struct dso *dso = map->dso; | 1339 | struct dso *dso = map->dso; |
1341 | const char *filename = dso->long_name; | ||
1342 | struct rb_root source_line = RB_ROOT; | 1340 | struct rb_root source_line = RB_ROOT; |
1343 | u64 len; | 1341 | u64 len; |
1344 | 1342 | ||
@@ -1348,9 +1346,8 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, | |||
1348 | len = symbol__size(sym); | 1346 | len = symbol__size(sym); |
1349 | 1347 | ||
1350 | if (print_lines) { | 1348 | if (print_lines) { |
1351 | symbol__get_source_line(sym, map, evsel, &source_line, | 1349 | symbol__get_source_line(sym, map, evsel, &source_line, len); |
1352 | len, filename); | 1350 | print_summary(&source_line, dso->long_name); |
1353 | print_summary(&source_line, filename); | ||
1354 | } | 1351 | } |
1355 | 1352 | ||
1356 | symbol__annotate_printf(sym, map, evsel, full_paths, | 1353 | symbol__annotate_printf(sym, map, evsel, full_paths, |