diff options
author | Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> | 2016-12-05 10:56:46 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-12-15 14:25:46 -0500 |
commit | 3ee2eb6da20db1edad31070da38996e8e0f8adfa (patch) | |
tree | 096f060a9acdb26ae6ea2a590e813dc74b82fdaa /tools/perf/util/annotate.c | |
parent | 23dc4f1586159470aac707caae526824dd077e25 (diff) |
perf annotate: Support jump instruction with target as second operand
Architectures like PowerPC have jump instructions that includes a target
address as a second operand. For example, 'bne cr7,0xc0000000000f6154'.
Add support for such instruction in perf annotate.
objdump o/p:
c0000000000f6140: ld r9,1032(r31)
c0000000000f6144: cmpdi cr7,r9,0
c0000000000f6148: bne cr7,0xc0000000000f6154
c0000000000f614c: ld r9,2312(r30)
c0000000000f6150: std r9,1032(r31)
c0000000000f6154: ld r9,88(r31)
Corresponding perf annotate o/p:
Before patch:
ld r9,1032(r31)
cmpdi cr7,r9,0
v bne 3ffffffffff09f2c
ld r9,2312(r30)
std r9,1032(r31)
74: ld r9,88(r31)
After patch:
ld r9,1032(r31)
cmpdi cr7,r9,0
v bne 74
ld r9,2312(r30)
std r9,1032(r31)
74: ld r9,88(r31)
Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Chris Riyder <chris.ryder@arm.com>
Cc: Kim Phillips <kim.phillips@arm.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Taeung Song <treeze.taeung@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org
Link: http://lkml.kernel.org/r/1480953407-7605-2-git-send-email-ravi.bangoria@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util/annotate.c')
-rw-r--r-- | tools/perf/util/annotate.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index ea7e0de4b9c1..590244e5781e 100644 --- a/tools/perf/util/annotate.c +++ b/tools/perf/util/annotate.c | |||
@@ -223,8 +223,12 @@ bool ins__is_call(const struct ins *ins) | |||
223 | static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map *map __maybe_unused) | 223 | static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map *map __maybe_unused) |
224 | { | 224 | { |
225 | const char *s = strchr(ops->raw, '+'); | 225 | const char *s = strchr(ops->raw, '+'); |
226 | const char *c = strchr(ops->raw, ','); | ||
226 | 227 | ||
227 | ops->target.addr = strtoull(ops->raw, NULL, 16); | 228 | if (c++ != NULL) |
229 | ops->target.addr = strtoull(c, NULL, 16); | ||
230 | else | ||
231 | ops->target.addr = strtoull(ops->raw, NULL, 16); | ||
228 | 232 | ||
229 | if (s++ != NULL) | 233 | if (s++ != NULL) |
230 | ops->target.offset = strtoull(s, NULL, 16); | 234 | ops->target.offset = strtoull(s, NULL, 16); |