aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@redhat.com>2012-11-28 08:52:41 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-12-09 06:46:07 -0500
commitf4c8bae1920c459b7b9c12363d11e8a588862e42 (patch)
tree923d0b943153198760e473261480666ea36dca05 /tools/perf/ui
parent05472daa4d8ab88a071bfcaa3bb47473e4071848 (diff)
perf diff: Change formula methods to work with pair directly
Changing formula methods to operate over hist entry and its pair directly. This makes the code more obvious and readable, instead of all time checking for pair being != NULL. Signed-off-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1354110769-2998-7-git-send-email-jolsa@redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui')
-rw-r--r--tools/perf/ui/hist.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
index 108e5ed67621..1785bab7adfd 100644
--- a/tools/perf/ui/hist.c
+++ b/tools/perf/ui/hist.c
@@ -389,10 +389,13 @@ static int hpp__width_formula(struct perf_hpp *hpp __maybe_unused)
389 389
390static int hpp__entry_formula(struct perf_hpp *hpp, struct hist_entry *he) 390static int hpp__entry_formula(struct perf_hpp *hpp, struct hist_entry *he)
391{ 391{
392 struct hist_entry *pair = hist_entry__next_pair(he);
392 const char *fmt = symbol_conf.field_sep ? "%s" : "%-70s"; 393 const char *fmt = symbol_conf.field_sep ? "%s" : "%-70s";
393 char buf[96] = " "; 394 char buf[96] = " ";
394 395
395 perf_diff__formula(buf, sizeof(buf), he); 396 if (pair)
397 perf_diff__formula(he, pair, buf, sizeof(buf));
398
396 return scnprintf(hpp->buf, hpp->size, fmt, buf); 399 return scnprintf(hpp->buf, hpp->size, fmt, buf);
397} 400}
398 401