diff options
author | Namhyung Kim <namhyung@kernel.org> | 2016-02-21 09:22:34 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-02-22 10:07:14 -0500 |
commit | dd42baf1f64d7257258fa4f20064aee5160df369 (patch) | |
tree | ee84a994f8523bc2640400780bf3ae8199dbb42d /tools/perf/ui | |
parent | 0c0af78d472f96efe04daaaccede7522b2394b76 (diff) |
perf tools: Fix assertion failure on dynamic entry
The dynamic entry is created for each field in a tracepoint event.
Since they have no fixed hpp format index, it should skip when
perf_hpp__reset_width() is called.
This caused following assertion failure..
$ perf record -e sched:sched_switch -a sleep 1
$ perf report -s comm,next_pid --stdio
perf: ui/hist.c:651: perf_hpp__reset_width:
Assertion `!(fmt->idx >= PERF_HPP__MAX_INDEX)' failed.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1456064558-13086-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui')
-rw-r--r-- | tools/perf/ui/hist.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c index 1ba4117d9c2d..12223d791e9f 100644 --- a/tools/perf/ui/hist.c +++ b/tools/perf/ui/hist.c | |||
@@ -645,6 +645,9 @@ void perf_hpp__reset_width(struct perf_hpp_fmt *fmt, struct hists *hists) | |||
645 | if (perf_hpp__is_sort_entry(fmt)) | 645 | if (perf_hpp__is_sort_entry(fmt)) |
646 | return perf_hpp__reset_sort_width(fmt, hists); | 646 | return perf_hpp__reset_sort_width(fmt, hists); |
647 | 647 | ||
648 | if (perf_hpp__is_dynamic_entry(fmt)) | ||
649 | return; | ||
650 | |||
648 | BUG_ON(fmt->idx >= PERF_HPP__MAX_INDEX); | 651 | BUG_ON(fmt->idx >= PERF_HPP__MAX_INDEX); |
649 | 652 | ||
650 | switch (fmt->idx) { | 653 | switch (fmt->idx) { |