diff options
author | Jin Yao <yao.jin@linux.intel.com> | 2017-06-18 22:55:56 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2017-06-19 14:27:09 -0400 |
commit | dcaa394807ac219d8597d25bad3fe1bc6c86123b (patch) | |
tree | 50d0d72c558e8b114f1efde8d86dc0afa0113718 /tools/perf/ui/browsers/annotate.c | |
parent | d3cef7fe5151eabcd97ad8f9e595ec55f6ffb318 (diff) |
perf annotate: Return arch from symbol__disassemble() and save it in browser
In annotate browser, we will add support to check fused instructions.
While this is x86-specific feature so we need the annotate browser to
know what the arch it runs on.
symbol__disassemble() has figured out the arch. This patch just lets the
arch return from symbol__disassemble and save the arch in annotate
browser.
Signed-off-by: Yao Jin <yao.jin@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1497840958-4759-2-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
-rw-r--r-- | tools/perf/ui/browsers/annotate.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 7a03389b7a03..27f41f28dcb4 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c | |||
@@ -46,12 +46,15 @@ static struct annotate_browser_opt { | |||
46 | .jump_arrows = true, | 46 | .jump_arrows = true, |
47 | }; | 47 | }; |
48 | 48 | ||
49 | struct arch; | ||
50 | |||
49 | struct annotate_browser { | 51 | struct annotate_browser { |
50 | struct ui_browser b; | 52 | struct ui_browser b; |
51 | struct rb_root entries; | 53 | struct rb_root entries; |
52 | struct rb_node *curr_hot; | 54 | struct rb_node *curr_hot; |
53 | struct disasm_line *selection; | 55 | struct disasm_line *selection; |
54 | struct disasm_line **offsets; | 56 | struct disasm_line **offsets; |
57 | struct arch *arch; | ||
55 | int nr_events; | 58 | int nr_events; |
56 | u64 start; | 59 | u64 start; |
57 | int nr_asm_entries; | 60 | int nr_asm_entries; |
@@ -1070,7 +1073,8 @@ int symbol__tui_annotate(struct symbol *sym, struct map *map, | |||
1070 | (nr_pcnt - 1); | 1073 | (nr_pcnt - 1); |
1071 | } | 1074 | } |
1072 | 1075 | ||
1073 | err = symbol__disassemble(sym, map, perf_evsel__env_arch(evsel), sizeof_bdl); | 1076 | err = symbol__disassemble(sym, map, perf_evsel__env_arch(evsel), |
1077 | sizeof_bdl, &browser.arch); | ||
1074 | if (err) { | 1078 | if (err) { |
1075 | char msg[BUFSIZ]; | 1079 | char msg[BUFSIZ]; |
1076 | symbol__strerror_disassemble(sym, map, err, msg, sizeof(msg)); | 1080 | symbol__strerror_disassemble(sym, map, err, msg, sizeof(msg)); |