aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui/browsers/annotate.c
diff options
context:
space:
mode:
authorJin Yao <yao.jin@linux.intel.com>2017-05-04 10:58:14 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2017-06-19 14:14:57 -0400
commitc564f0db92b7f8d734ce530e42a540e12ae3d583 (patch)
tree30e8c20d5845812d7f763e0d5d21e2c550c7aae9 /tools/perf/ui/browsers/annotate.c
parent8052bd8243e823a0954bcbafda8f91072598f13d (diff)
perf report: Remove unnecessary check in annotate_browser_write()
In annotate_browser_write(), if (dl->offset != -1 && percent_max != 0.0) { if (percent_max != 0.0) { ... } ... } The second check of (percent_max != 0.0) is not necessary, remove it. Signed-off-by: Yao Jin <yao.jin@linux.intel.com> Acked-by: Milian Wolff <milian.wolff@kdab.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kan Liang <kan.liang@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Yao Jin <yao.jin@linux.intel.com> Link: http://lkml.kernel.org/r/1493909895-9668-2-git-send-email-yao.jin@linux.intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/ui/browsers/annotate.c')
-rw-r--r--tools/perf/ui/browsers/annotate.c24
1 files changed, 10 insertions, 14 deletions
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index d990ad08a3c6..52c1e8d672b5 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -132,21 +132,17 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
132 } 132 }
133 133
134 if (dl->offset != -1 && percent_max != 0.0) { 134 if (dl->offset != -1 && percent_max != 0.0) {
135 if (percent_max != 0.0) { 135 for (i = 0; i < ab->nr_events; i++) {
136 for (i = 0; i < ab->nr_events; i++) { 136 ui_browser__set_percent_color(browser,
137 ui_browser__set_percent_color(browser, 137 bdl->samples[i].percent,
138 bdl->samples[i].percent, 138 current_entry);
139 current_entry); 139 if (annotate_browser__opts.show_total_period) {
140 if (annotate_browser__opts.show_total_period) { 140 ui_browser__printf(browser, "%6" PRIu64 " ",
141 ui_browser__printf(browser, "%6" PRIu64 " ", 141 bdl->samples[i].nr);
142 bdl->samples[i].nr); 142 } else {
143 } else { 143 ui_browser__printf(browser, "%6.2f ",
144 ui_browser__printf(browser, "%6.2f ", 144 bdl->samples[i].percent);
145 bdl->samples[i].percent);
146 }
147 } 145 }
148 } else {
149 ui_browser__write_nstring(browser, " ", 7 * ab->nr_events);
150 } 146 }
151 } else { 147 } else {
152 ui_browser__set_percent_color(browser, 0, current_entry); 148 ui_browser__set_percent_color(browser, 0, current_entry);