diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-01-03 13:56:06 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-01-13 08:06:21 -0500 |
commit | 03ad9747c5f2169556467101e96bc390c5aa4b83 (patch) | |
tree | c60f2e8ad184a10ed493de0d6db07d2f03aae130 /tools/perf/tests/task-exit.c | |
parent | 3e2be2da8f76ef5b2e8e59c3dc8acd24640b4af4 (diff) |
perf evlist: Move destruction of maps to evlist destructor
Instead of requiring tools to do an extra destructor call just before
calling perf_evlist__delete.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-0jd2ptzyikxb5wp7inzz2ah2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/tests/task-exit.c')
-rw-r--r-- | tools/perf/tests/task-exit.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c index 44e339d4e297..fdeb2aa46a50 100644 --- a/tools/perf/tests/task-exit.c +++ b/tools/perf/tests/task-exit.c | |||
@@ -62,14 +62,14 @@ int test__task_exit(void) | |||
62 | if (!evlist->cpus || !evlist->threads) { | 62 | if (!evlist->cpus || !evlist->threads) { |
63 | err = -ENOMEM; | 63 | err = -ENOMEM; |
64 | pr_debug("Not enough memory to create thread/cpu maps\n"); | 64 | pr_debug("Not enough memory to create thread/cpu maps\n"); |
65 | goto out_delete_maps; | 65 | goto out_delete_evlist; |
66 | } | 66 | } |
67 | 67 | ||
68 | err = perf_evlist__prepare_workload(evlist, &target, argv, false, | 68 | err = perf_evlist__prepare_workload(evlist, &target, argv, false, |
69 | workload_exec_failed_signal); | 69 | workload_exec_failed_signal); |
70 | if (err < 0) { | 70 | if (err < 0) { |
71 | pr_debug("Couldn't run the workload!\n"); | 71 | pr_debug("Couldn't run the workload!\n"); |
72 | goto out_delete_maps; | 72 | goto out_delete_evlist; |
73 | } | 73 | } |
74 | 74 | ||
75 | evsel = perf_evlist__first(evlist); | 75 | evsel = perf_evlist__first(evlist); |
@@ -83,7 +83,7 @@ int test__task_exit(void) | |||
83 | err = perf_evlist__open(evlist); | 83 | err = perf_evlist__open(evlist); |
84 | if (err < 0) { | 84 | if (err < 0) { |
85 | pr_debug("Couldn't open the evlist: %s\n", strerror(-err)); | 85 | pr_debug("Couldn't open the evlist: %s\n", strerror(-err)); |
86 | goto out_delete_maps; | 86 | goto out_delete_evlist; |
87 | } | 87 | } |
88 | 88 | ||
89 | if (perf_evlist__mmap(evlist, 128, true) < 0) { | 89 | if (perf_evlist__mmap(evlist, 128, true) < 0) { |
@@ -115,8 +115,7 @@ retry: | |||
115 | perf_evlist__munmap(evlist); | 115 | perf_evlist__munmap(evlist); |
116 | out_close_evlist: | 116 | out_close_evlist: |
117 | perf_evlist__close(evlist); | 117 | perf_evlist__close(evlist); |
118 | out_delete_maps: | 118 | out_delete_evlist: |
119 | perf_evlist__delete_maps(evlist); | ||
120 | perf_evlist__delete(evlist); | 119 | perf_evlist__delete(evlist); |
121 | return err; | 120 | return err; |
122 | } | 121 | } |