aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorAdrian Hunter <adrian.hunter@intel.com>2019-07-10 04:58:02 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2019-07-10 11:23:55 -0400
commitecc8c9984dae9812a10936cb9c74957b68075e07 (patch)
treeaa2d73eecbad13a23c08392a4904cbebeb4563fe /tools/perf/scripts/python
parent4650c7bed79582c74452d284e45d5b76987c0ef3 (diff)
perf scripts python: export-to-sqlite.py: Add has_calls column to comms table
Now that a thread's current comm is exported, it shows up in the call graph and call tree even if it has no calls. That can happen because the calls are recorded against the main thread's initial comm. Add a table column to make it easy for the exported-sql-viewer.py script to select only comms with calls. Committer notes: Running the export-to-sqlite.py worked without warnings and using the exported-sql-viewer.py worked as before. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Link: http://lkml.kernel.org/r/20190710085810.1650-14-adrian.hunter@intel.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python')
-rw-r--r--tools/perf/scripts/python/export-to-sqlite.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index 97aa66dd2fe1..9156f6a1e5f0 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -606,6 +606,8 @@ def trace_end():
606 if perf_db_export_calls: 606 if perf_db_export_calls:
607 do_query(query, 'CREATE INDEX pcpid_idx ON calls (parent_call_path_id)') 607 do_query(query, 'CREATE INDEX pcpid_idx ON calls (parent_call_path_id)')
608 do_query(query, 'CREATE INDEX pid_idx ON calls (parent_id)') 608 do_query(query, 'CREATE INDEX pid_idx ON calls (parent_id)')
609 do_query(query, 'ALTER TABLE comms ADD has_calls boolean')
610 do_query(query, 'UPDATE comms SET has_calls = 1 WHERE comms.id IN (SELECT DISTINCT comm_id FROM calls)')
609 611
610 printdate("Dropping unused tables") 612 printdate("Dropping unused tables")
611 if is_table_empty("ptwrite"): 613 if is_table_empty("ptwrite"):