diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2019-05-03 08:08:24 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2019-05-15 15:36:47 -0400 |
commit | be6e747136a4dc8aad99259e47fd6f7362a43996 (patch) | |
tree | 2c63ed2448396fd7f14d573eb7f35ddabf2fdaa6 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | ca138a7aabc68bf727918bb40ce08157cd5ec0a5 (diff) |
perf scripts python: exported-sql-viewer.py: Move view creation
As preparation for adding support for copying to clipboard, create view
in TreeWindowBase instead of derived classes.
Committer testing:
Tested using an old .db used to test some older patches:
$ python ~acme/libexec/perf-core/scripts/python/exported-sql-viewer.py ~/c/adrian.hunter/simple-retpoline.db
Nothing breaks.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/20190503120828.25326-3-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
-rwxr-xr-x | tools/perf/scripts/python/exported-sql-viewer.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tools/perf/scripts/python/exported-sql-viewer.py b/tools/perf/scripts/python/exported-sql-viewer.py index 74ef92f1d19a..db4655168ab1 100755 --- a/tools/perf/scripts/python/exported-sql-viewer.py +++ b/tools/perf/scripts/python/exported-sql-viewer.py | |||
@@ -877,9 +877,10 @@ class TreeWindowBase(QMdiSubWindow): | |||
877 | super(TreeWindowBase, self).__init__(parent) | 877 | super(TreeWindowBase, self).__init__(parent) |
878 | 878 | ||
879 | self.model = None | 879 | self.model = None |
880 | self.view = None | ||
881 | self.find_bar = None | 880 | self.find_bar = None |
882 | 881 | ||
882 | self.view = QTreeView() | ||
883 | |||
883 | def DisplayFound(self, ids): | 884 | def DisplayFound(self, ids): |
884 | if not len(ids): | 885 | if not len(ids): |
885 | return False | 886 | return False |
@@ -921,7 +922,6 @@ class CallGraphWindow(TreeWindowBase): | |||
921 | 922 | ||
922 | self.model = LookupCreateModel("Context-Sensitive Call Graph", lambda x=glb: CallGraphModel(x)) | 923 | self.model = LookupCreateModel("Context-Sensitive Call Graph", lambda x=glb: CallGraphModel(x)) |
923 | 924 | ||
924 | self.view = QTreeView() | ||
925 | self.view.setModel(self.model) | 925 | self.view.setModel(self.model) |
926 | 926 | ||
927 | for c, w in ((0, 250), (1, 100), (2, 60), (3, 70), (4, 70), (5, 100)): | 927 | for c, w in ((0, 250), (1, 100), (2, 60), (3, 70), (4, 70), (5, 100)): |
@@ -944,7 +944,6 @@ class CallTreeWindow(TreeWindowBase): | |||
944 | 944 | ||
945 | self.model = LookupCreateModel("Call Tree", lambda x=glb: CallTreeModel(x)) | 945 | self.model = LookupCreateModel("Call Tree", lambda x=glb: CallTreeModel(x)) |
946 | 946 | ||
947 | self.view = QTreeView() | ||
948 | self.view.setModel(self.model) | 947 | self.view.setModel(self.model) |
949 | 948 | ||
950 | for c, w in ((0, 230), (1, 100), (2, 100), (3, 70), (4, 70), (5, 100)): | 949 | for c, w in ((0, 230), (1, 100), (2, 100), (3, 70), (4, 70), (5, 100)): |