diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-04-18 11:09:08 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-04-18 11:26:27 -0400 |
commit | 2ddd5c049e71dd8551c268e7386fefeb7495e988 (patch) | |
tree | 0c233c1a516a9fe5df9f382e7fb11fd07c3e0776 /tools/perf/builtin-trace.c | |
parent | 1cc83815d5fdb40a7d06c3f9871134a10e5ffa79 (diff) |
perf tools: Ditch record_opts.callgraph_set
We have callchain_param.enabled for that.
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-silwqjc2t25ls42dsvg28pp5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-trace.c')
-rw-r--r-- | tools/perf/builtin-trace.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c index 0e3c1cecef1b..5e2614bbb48d 100644 --- a/tools/perf/builtin-trace.c +++ b/tools/perf/builtin-trace.c | |||
@@ -2457,7 +2457,7 @@ static int trace__add_syscall_newtp(struct trace *trace) | |||
2457 | perf_evlist__add(evlist, sys_enter); | 2457 | perf_evlist__add(evlist, sys_enter); |
2458 | perf_evlist__add(evlist, sys_exit); | 2458 | perf_evlist__add(evlist, sys_exit); |
2459 | 2459 | ||
2460 | if (trace->opts.callgraph_set && !trace->kernel_syscallchains) { | 2460 | if (callchain_param.enabled && !trace->kernel_syscallchains) { |
2461 | /* | 2461 | /* |
2462 | * We're interested only in the user space callchain | 2462 | * We're interested only in the user space callchain |
2463 | * leading to the syscall, allow overriding that for | 2463 | * leading to the syscall, allow overriding that for |
@@ -2546,7 +2546,7 @@ static int trace__run(struct trace *trace, int argc, const char **argv) | |||
2546 | 2546 | ||
2547 | perf_evlist__config(evlist, &trace->opts, NULL); | 2547 | perf_evlist__config(evlist, &trace->opts, NULL); |
2548 | 2548 | ||
2549 | if (trace->opts.callgraph_set && trace->syscalls.events.sys_exit) { | 2549 | if (callchain_param.enabled && trace->syscalls.events.sys_exit) { |
2550 | perf_evsel__config_callchain(trace->syscalls.events.sys_exit, | 2550 | perf_evsel__config_callchain(trace->syscalls.events.sys_exit, |
2551 | &trace->opts, &callchain_param); | 2551 | &trace->opts, &callchain_param); |
2552 | /* | 2552 | /* |
@@ -3153,11 +3153,11 @@ int cmd_trace(int argc, const char **argv, const char *prefix __maybe_unused) | |||
3153 | } | 3153 | } |
3154 | 3154 | ||
3155 | #ifdef HAVE_DWARF_UNWIND_SUPPORT | 3155 | #ifdef HAVE_DWARF_UNWIND_SUPPORT |
3156 | if ((trace.min_stack || max_stack_user_set) && !trace.opts.callgraph_set) | 3156 | if ((trace.min_stack || max_stack_user_set) && !callchain_param.enabled) |
3157 | record_opts__parse_callchain(&trace.opts, &callchain_param, "dwarf", false); | 3157 | record_opts__parse_callchain(&trace.opts, &callchain_param, "dwarf", false); |
3158 | #endif | 3158 | #endif |
3159 | 3159 | ||
3160 | if (trace.opts.callgraph_set) { | 3160 | if (callchain_param.enabled) { |
3161 | if (!mmap_pages_user_set && geteuid() == 0) | 3161 | if (!mmap_pages_user_set && geteuid() == 0) |
3162 | trace.opts.mmap_pages = perf_event_mlock_kb_in_pages() * 4; | 3162 | trace.opts.mmap_pages = perf_event_mlock_kb_in_pages() * 4; |
3163 | 3163 | ||