diff options
author | Adrian Hunter <adrian.hunter@intel.com> | 2014-07-14 06:02:25 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-07-16 16:57:33 -0400 |
commit | 1fcb8768636d38cb6fdfeef83a5ee596c4bd9c56 (patch) | |
tree | ffefb332e8e0e035201fbe4b0f4cef9301ac76d1 /tools/perf/builtin-sched.c | |
parent | 57608cfd8827a74237d264a197722e2c99f72da4 (diff) |
perf machine: Fix the value used for unknown pids
The value used for unknown pids cannot be zero because that is used by
the "idle" task.
Use -1 instead. Also handle the unknown pid case when creating map
groups.
Note that, threads with an unknown pid should not occur because fork (or
synthesized) events precede the thread's existence.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1405332185-4050-2-git-send-email-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-sched.c')
-rw-r--r-- | tools/perf/builtin-sched.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index c38d06c04775..b7f555add0c8 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c | |||
@@ -935,8 +935,8 @@ static int latency_switch_event(struct perf_sched *sched, | |||
935 | return -1; | 935 | return -1; |
936 | } | 936 | } |
937 | 937 | ||
938 | sched_out = machine__findnew_thread(machine, 0, prev_pid); | 938 | sched_out = machine__findnew_thread(machine, -1, prev_pid); |
939 | sched_in = machine__findnew_thread(machine, 0, next_pid); | 939 | sched_in = machine__findnew_thread(machine, -1, next_pid); |
940 | 940 | ||
941 | out_events = thread_atoms_search(&sched->atom_root, sched_out, &sched->cmp_pid); | 941 | out_events = thread_atoms_search(&sched->atom_root, sched_out, &sched->cmp_pid); |
942 | if (!out_events) { | 942 | if (!out_events) { |
@@ -979,7 +979,7 @@ static int latency_runtime_event(struct perf_sched *sched, | |||
979 | { | 979 | { |
980 | const u32 pid = perf_evsel__intval(evsel, sample, "pid"); | 980 | const u32 pid = perf_evsel__intval(evsel, sample, "pid"); |
981 | const u64 runtime = perf_evsel__intval(evsel, sample, "runtime"); | 981 | const u64 runtime = perf_evsel__intval(evsel, sample, "runtime"); |
982 | struct thread *thread = machine__findnew_thread(machine, 0, pid); | 982 | struct thread *thread = machine__findnew_thread(machine, -1, pid); |
983 | struct work_atoms *atoms = thread_atoms_search(&sched->atom_root, thread, &sched->cmp_pid); | 983 | struct work_atoms *atoms = thread_atoms_search(&sched->atom_root, thread, &sched->cmp_pid); |
984 | u64 timestamp = sample->time; | 984 | u64 timestamp = sample->time; |
985 | int cpu = sample->cpu; | 985 | int cpu = sample->cpu; |
@@ -1012,7 +1012,7 @@ static int latency_wakeup_event(struct perf_sched *sched, | |||
1012 | struct thread *wakee; | 1012 | struct thread *wakee; |
1013 | u64 timestamp = sample->time; | 1013 | u64 timestamp = sample->time; |
1014 | 1014 | ||
1015 | wakee = machine__findnew_thread(machine, 0, pid); | 1015 | wakee = machine__findnew_thread(machine, -1, pid); |
1016 | atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid); | 1016 | atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid); |
1017 | if (!atoms) { | 1017 | if (!atoms) { |
1018 | if (thread_atoms_insert(sched, wakee)) | 1018 | if (thread_atoms_insert(sched, wakee)) |
@@ -1072,7 +1072,7 @@ static int latency_migrate_task_event(struct perf_sched *sched, | |||
1072 | if (sched->profile_cpu == -1) | 1072 | if (sched->profile_cpu == -1) |
1073 | return 0; | 1073 | return 0; |
1074 | 1074 | ||
1075 | migrant = machine__findnew_thread(machine, 0, pid); | 1075 | migrant = machine__findnew_thread(machine, -1, pid); |
1076 | atoms = thread_atoms_search(&sched->atom_root, migrant, &sched->cmp_pid); | 1076 | atoms = thread_atoms_search(&sched->atom_root, migrant, &sched->cmp_pid); |
1077 | if (!atoms) { | 1077 | if (!atoms) { |
1078 | if (thread_atoms_insert(sched, migrant)) | 1078 | if (thread_atoms_insert(sched, migrant)) |
@@ -1290,7 +1290,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel, | |||
1290 | return -1; | 1290 | return -1; |
1291 | } | 1291 | } |
1292 | 1292 | ||
1293 | sched_in = machine__findnew_thread(machine, 0, next_pid); | 1293 | sched_in = machine__findnew_thread(machine, -1, next_pid); |
1294 | 1294 | ||
1295 | sched->curr_thread[this_cpu] = sched_in; | 1295 | sched->curr_thread[this_cpu] = sched_in; |
1296 | 1296 | ||