diff options
author | Namhyung Kim <namhyung@kernel.org> | 2015-11-26 02:08:20 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-11-26 11:19:39 -0500 |
commit | b49a8fe52626814968b9a9d27d7ad1cadc5532ed (patch) | |
tree | 5a9b472fa6b69c8990adf2ddc561945d9ec0b081 /tools/perf/builtin-report.c | |
parent | a95a49fa0cc5eec730d8703b1544fa7ea6a11dec (diff) |
perf callchain: Honor hide_unresolved
If user requested to hide unresolved entries, skip unresolved callchains
as well as hist entries.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1448521700-32062-3-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/builtin-report.c')
-rw-r--r-- | tools/perf/builtin-report.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 14428342b47b..8a9c6908f54e 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c | |||
@@ -45,7 +45,6 @@ struct report { | |||
45 | struct perf_tool tool; | 45 | struct perf_tool tool; |
46 | struct perf_session *session; | 46 | struct perf_session *session; |
47 | bool use_tui, use_gtk, use_stdio; | 47 | bool use_tui, use_gtk, use_stdio; |
48 | bool hide_unresolved; | ||
49 | bool dont_use_callchains; | 48 | bool dont_use_callchains; |
50 | bool show_full_info; | 49 | bool show_full_info; |
51 | bool show_threads; | 50 | bool show_threads; |
@@ -146,7 +145,7 @@ static int process_sample_event(struct perf_tool *tool, | |||
146 | struct hist_entry_iter iter = { | 145 | struct hist_entry_iter iter = { |
147 | .evsel = evsel, | 146 | .evsel = evsel, |
148 | .sample = sample, | 147 | .sample = sample, |
149 | .hide_unresolved = rep->hide_unresolved, | 148 | .hide_unresolved = symbol_conf.hide_unresolved, |
150 | .add_entry_cb = hist_iter__report_callback, | 149 | .add_entry_cb = hist_iter__report_callback, |
151 | }; | 150 | }; |
152 | int ret = 0; | 151 | int ret = 0; |
@@ -157,7 +156,7 @@ static int process_sample_event(struct perf_tool *tool, | |||
157 | return -1; | 156 | return -1; |
158 | } | 157 | } |
159 | 158 | ||
160 | if (rep->hide_unresolved && al.sym == NULL) | 159 | if (symbol_conf.hide_unresolved && al.sym == NULL) |
161 | goto out_put; | 160 | goto out_put; |
162 | 161 | ||
163 | if (rep->cpu_list && !test_bit(sample->cpu, rep->cpu_bitmap)) | 162 | if (rep->cpu_list && !test_bit(sample->cpu, rep->cpu_bitmap)) |
@@ -740,7 +739,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused) | |||
740 | OPT_STRING_NOEMPTY('t', "field-separator", &symbol_conf.field_sep, "separator", | 739 | OPT_STRING_NOEMPTY('t', "field-separator", &symbol_conf.field_sep, "separator", |
741 | "separator for columns, no spaces will be added between " | 740 | "separator for columns, no spaces will be added between " |
742 | "columns '.' is reserved."), | 741 | "columns '.' is reserved."), |
743 | OPT_BOOLEAN('U', "hide-unresolved", &report.hide_unresolved, | 742 | OPT_BOOLEAN('U', "hide-unresolved", &symbol_conf.hide_unresolved, |
744 | "Only display entries resolved to a symbol"), | 743 | "Only display entries resolved to a symbol"), |
745 | OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", | 744 | OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory", |
746 | "Look for files with symbols relative to this directory"), | 745 | "Look for files with symbols relative to this directory"), |