diff options
author | Ingo Molnar <mingo@kernel.org> | 2016-09-05 09:15:49 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2016-09-05 09:15:49 -0400 |
commit | c0b172e5b6770048751b2c0a4fe44346c2080c5d (patch) | |
tree | 1a423ca2585eb1aae8d7e96b1bea7d5f3c03280f /tools/perf/builtin-annotate.c | |
parent | c9bbdd4830ab06288bb1d8c00ed8c8c6e80e377a (diff) | |
parent | 6243b9dc4c991fe8bdc53a0e029908aef3ddb101 (diff) |
Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo:
User visible changes:
- Support generating cross arch probes, i.e. if you specify a vmlinux
file for different arch than the one in the host machine,
$ perf probe --definition function_name args
will generate the probe definition string needed to append to the
target machine /sys/kernel/debug/tracing/kprobes_events file, using
scripting (Masami Hiramatsu).
- Make 'perf probe' skip the function prologue in uprobes if program
compiled without optimization, using the same strategy as gdb and
systemtap uses, fixing a bug where:
$ perf probe -x ./test 'foo i'
When 'foo(42)' was used on the "./test" executable would produce i=0
instead of the expected i=42 (Ravi Bangoria)
- Demangle symbols for synthesized @plt entries too (Millian Wolff)
Documentation changes:
- Show default report configuration in 'perf config' example
and docs (Millian Wolff)
Infrastructure changes:
- Make 'perf test vmlinux' tolerate the symbol aliasing pruning done when
loading kallsyms and vmlinux (Arnaldo Carvalho de Melo)
- Improve output of 'perf test vmlinux' test, to help identify on the verbose
output which lines are warning and which are errors (Arnaldo Carvalho de Melo)
- Prep work to stop having to pass symbol_filter_t to lots of functions,
simplifying symtab loading routines (Arnaldo Carvalho de Melo)
- Honor symbol_conf.allow_aliases when loading kallsyms as well, it was using
it only when loading vmlinux files (Arnaldo Carvalho de Melo)
- Fixup symbol->end before doing alias pruning when loading symbol tables
(Arnaldo Carvalho de Melo)
- Fix error handling of lzma kernel module decompression (Shawn Lin)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
-rw-r--r-- | tools/perf/builtin-annotate.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c index 9c1034d81b4f..f07b23011b22 100644 --- a/tools/perf/builtin-annotate.c +++ b/tools/perf/builtin-annotate.c | |||
@@ -204,8 +204,6 @@ static int __cmd_annotate(struct perf_annotate *ann) | |||
204 | struct perf_evsel *pos; | 204 | struct perf_evsel *pos; |
205 | u64 total_nr_samples; | 205 | u64 total_nr_samples; |
206 | 206 | ||
207 | machines__set_symbol_filter(&session->machines, symbol__annotate_init); | ||
208 | |||
209 | if (ann->cpu_list) { | 207 | if (ann->cpu_list) { |
210 | ret = perf_session__cpu_bitmap(session, ann->cpu_list, | 208 | ret = perf_session__cpu_bitmap(session, ann->cpu_list, |
211 | ann->cpu_bitmap); | 209 | ann->cpu_bitmap); |
@@ -367,7 +365,10 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused) | |||
367 | if (annotate.session == NULL) | 365 | if (annotate.session == NULL) |
368 | return -1; | 366 | return -1; |
369 | 367 | ||
370 | symbol_conf.priv_size = sizeof(struct annotation); | 368 | ret = symbol__annotation_init(); |
369 | if (ret < 0) | ||
370 | goto out_delete; | ||
371 | |||
371 | symbol_conf.try_vmlinux_path = true; | 372 | symbol_conf.try_vmlinux_path = true; |
372 | 373 | ||
373 | ret = symbol__init(&annotate.session->header.env); | 374 | ret = symbol__init(&annotate.session->header.env); |