aboutsummaryrefslogtreecommitdiffstats
path: root/sound/usb/line6
diff options
context:
space:
mode:
authorTakashi Iwai <tiwai@suse.de>2015-01-28 06:29:05 -0500
committerTakashi Iwai <tiwai@suse.de>2015-01-28 14:50:54 -0500
commit0416980d0a2bc10acff1c2329159577036e5666b (patch)
tree0344dfb49f4d4480c5b2d201af5267df0eaa4370 /sound/usb/line6
parent247d95ee6dd22e5323ecf7a73ff64110ef2fa2da (diff)
ALSA: line6: Fix volume calculation for big-endian
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/usb/line6')
-rw-r--r--sound/usb/line6/playback.c23
1 files changed, 14 insertions, 9 deletions
diff --git a/sound/usb/line6/playback.c b/sound/usb/line6/playback.c
index 1708c05f14db..ae41124c351e 100644
--- a/sound/usb/line6/playback.c
+++ b/sound/usb/line6/playback.c
@@ -31,14 +31,16 @@ static void change_volume(struct urb *urb_out, int volume[],
31 return; /* maximum volume - no change */ 31 return; /* maximum volume - no change */
32 32
33 if (bytes_per_frame == 4) { 33 if (bytes_per_frame == 4) {
34 short *p, *buf_end; 34 __le16 *p, *buf_end;
35 35
36 p = (short *)urb_out->transfer_buffer; 36 p = (__le16 *)urb_out->transfer_buffer;
37 buf_end = p + urb_out->transfer_buffer_length / sizeof(*p); 37 buf_end = p + urb_out->transfer_buffer_length / sizeof(*p);
38 38
39 for (; p < buf_end; ++p) { 39 for (; p < buf_end; ++p) {
40 int val = (*p * volume[chn & 1]) >> 8; 40 short pv = le16_to_cpu(*p);
41 *p = clamp(val, 0x7fff, -0x8000); 41 int val = (pv * volume[chn & 1]) >> 8;
42 pv = clamp(val, 0x7fff, -0x8000);
43 *p = cpu_to_le16(pv);
42 ++chn; 44 ++chn;
43 } 45 }
44 } else if (bytes_per_frame == 6) { 46 } else if (bytes_per_frame == 6) {
@@ -114,15 +116,18 @@ static void add_monitor_signal(struct urb *urb_out, unsigned char *signal,
114 return; /* zero volume - no change */ 116 return; /* zero volume - no change */
115 117
116 if (bytes_per_frame == 4) { 118 if (bytes_per_frame == 4) {
117 short *pi, *po, *buf_end; 119 __le16 *pi, *po, *buf_end;
118 120
119 pi = (short *)signal; 121 pi = (__le16 *)signal;
120 po = (short *)urb_out->transfer_buffer; 122 po = (__le16 *)urb_out->transfer_buffer;
121 buf_end = po + urb_out->transfer_buffer_length / sizeof(*po); 123 buf_end = po + urb_out->transfer_buffer_length / sizeof(*po);
122 124
123 for (; po < buf_end; ++pi, ++po) { 125 for (; po < buf_end; ++pi, ++po) {
124 int val = *po + ((*pi * volume) >> 8); 126 short pov = le16_to_cpu(*po);
125 *po = clamp(val, 0x7fff, -0x8000); 127 short piv = le16_to_cpu(*pi);
128 int val = pov + ((piv * volume) >> 8);
129 pov = clamp(val, 0x7fff, -0x8000);
130 *po = cpu_to_le16(pov);
126 } 131 }
127 } 132 }
128 133