Merge tag 'sound-4.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound

Pull sound updates from Takashi Iwai:
 "This development cycle resulted in a fair amount of changes in both
  core and driver sides. The most significant change in ALSA core is
  about PCM. Also the support of of-graph card and the new DAPM widget
  for DSP are noteworthy changes in ASoC core. And there're lots of
  small changes splat over the tree, as you can see in diffstat.

  Below are a few highlights:

  ALSA core:
   - Removal of set_fs() hackery from PCM core stuff, and the code
     reorganization / optimization thereafter
   - Improved support of PCM ack ops, and a new ABI for improved
     control/status mmap handling
   - Lots of constifications in various codes

  ASoC core:
   - The support of of-graph card, which may work as a better generic
     device for a replacement of simple-card
   - New widget types intended mainly for use with DSPs

  ASoC drivers:
   - New drivers for Allwinner V3s SoCs
   - Ensonic ES8316 codec support
   - More Intel SKL and KBL works
   - More device support for Intel SST Atom (mostly for cheap tablets
     and 2-in-1 devices)
   - Support for Rockchip PDM controllers
   - Support for STM32 I2S and S/PDIF controllers
   - Support for ZTE AUD96P22 codecs

  HD-audio:
   - Support of new Realtek codecs (ALC215/ALC285/ALC289), more quirks
     for HP and Dell machines
   - A few more fixes for i915 component binding"

* tag 'sound-4.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: (418 commits)
  ALSA: hda - Fix unbalance of i915 module refcount
  ASoC: Intel: Skylake: Remove driver debugfs exit
  ASoC: Intel: Skylake: explicitly add the headers sst-dsp.h
  ALSA: hda/realtek - Remove GPIO_MASK
  ALSA: hda/realtek - Fix typo of pincfg for Dell quirk
  ALSA: pcm: add a documentation for tracepoints
  ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
  ALSA: x86: fix error return code in hdmi_lpe_audio_probe()
  ASoC: Intel: Skylake: Add support to read firmware registers
  ASoC: Intel: Skylake: Add sram address to sst_addr structure
  ASoC: Intel: Skylake: Debugfs facility to dump module config
  ASoC: Intel: Skylake: Add debugfs support
  ASoC: fix semicolon.cocci warnings
  ASoC: rt5645: Add quirk override by module option
  ASoC: rsnd: make arrays path and cmd_case static const
  ASoC: audio-graph-card: add widgets and routing for external amplifier support
  ASoC: audio-graph-card: update bindings for amplifier support
  ASoC: rt5665: calibration should be done before jack detection
  ASoC: rsnd: constify dev_pm_ops structures.
  ASoC: nau8825: change crosstalk-bypass property to bool type
  ...

1 files changed, 25 insertions, 45 deletions

diff --git a/sound/core/control.c b/sound/core/control.c
index 6362da17ac3f..3c6be1452e35 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -747,65 +747,45 @@ static int snd_ctl_card_info(struct snd_card *card, struct snd_ctl_file * ctl,
 static int snd_ctl_elem_list(struct snd_card *card,
                              struct snd_ctl_elem_list __user *_list)
 {
-        struct list_head *plist;
         struct snd_ctl_elem_list list;
         struct snd_kcontrol *kctl;
-        struct snd_ctl_elem_id *dst, *id;
+        struct snd_ctl_elem_id id;
         unsigned int offset, space, jidx;
+        int err = 0;
         
         if (copy_from_user(&list, _list, sizeof(list)))
                 return -EFAULT;
         offset = list.offset;
         space = list.space;
-        /* try limit maximum space */
-        if (space > 16384)
-                return -ENOMEM;
+
+        down_read(&card->controls_rwsem);
+        list.count = card->controls_count;
+        list.used = 0;
         if (space > 0) {
-                /* allocate temporary buffer for atomic operation */
-                dst = vmalloc(space * sizeof(struct snd_ctl_elem_id));
-                if (dst == NULL)
-                        return -ENOMEM;
-                down_read(&card->controls_rwsem);
-                list.count = card->controls_count;
-                plist = card->controls.next;
-                while (plist != &card->controls) {
-                        if (offset == 0)
-                                break;
-                        kctl = snd_kcontrol(plist);
-                        if (offset < kctl->count)
-                                break;
-                        offset -= kctl->count;
-                        plist = plist->next;
-                }
-                list.used = 0;
-                id = dst;
-                while (space > 0 && plist != &card->controls) {
-                        kctl = snd_kcontrol(plist);
-                        for (jidx = offset; space > 0 && jidx < kctl->count; jidx++) {
-                                snd_ctl_build_ioff(id, kctl, jidx);
-                                id++;
-                                space--;
+                list_for_each_entry(kctl, &card->controls, list) {
+                        if (offset >= kctl->count) {
+                                offset -= kctl->count;
+                                continue;
+                        }
+                        for (jidx = offset; jidx < kctl->count; jidx++) {
+                                snd_ctl_build_ioff(&id, kctl, jidx);
+                                if (copy_to_user(list.pids + list.used, &id,
+                                                 sizeof(id))) {
+                                        err = -EFAULT;
+                                        goto out;
+                                }
                                 list.used++;
+                                if (!--space)
+                                        goto out;
                         }
-                        plist = plist->next;
                         offset = 0;
                 }
-                up_read(&card->controls_rwsem);
-                if (list.used > 0 &&
-                    copy_to_user(list.pids, dst,
-                                 list.used * sizeof(struct snd_ctl_elem_id))) {
-                        vfree(dst);
-                        return -EFAULT;
-                }
-                vfree(dst);
-        } else {
-                down_read(&card->controls_rwsem);
-                list.count = card->controls_count;
-                up_read(&card->controls_rwsem);
         }
-        if (copy_to_user(_list, &list, sizeof(list)))
-                return -EFAULT;
-        return 0;
+ out:
+        up_read(&card->controls_rwsem);
+        if (!err && copy_to_user(_list, &list, sizeof(list)))
+                err = -EFAULT;
+        return err;
 }
 
 static bool validate_element_member_dimension(struct snd_ctl_elem_info *info)