diff options
author | David S. Miller <davem@davemloft.net> | 2017-10-22 08:36:53 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-10-22 08:39:14 -0400 |
commit | f8ddadc4db6c7b7029b6d0e0d9af24f74ad27ca2 (patch) | |
tree | 0a6432aba336bae42313613f4c891bcfce02bd4e /security/keys/proc.c | |
parent | bdd091bab8c631bd2801af838e344fad34566410 (diff) | |
parent | b5ac3beb5a9f0ef0ea64cd85faf94c0dc4de0e42 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
There were quite a few overlapping sets of changes here.
Daniel's bug fix for off-by-ones in the new BPF branch instructions,
along with the added allowances for "data_end > ptr + x" forms
collided with the metadata additions.
Along with those three changes came veritifer test cases, which in
their final form I tried to group together properly. If I had just
trimmed GIT's conflict tags as-is, this would have split up the
meta tests unnecessarily.
In the socketmap code, a set of preemption disabling changes
overlapped with the rename of bpf_compute_data_end() to
bpf_compute_data_pointers().
Changes were made to the mv88e6060.c driver set addr method
which got removed in net-next.
The hyperv transport socket layer had a locking change in 'net'
which overlapped with a change of socket state macro usage
in 'net-next'.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'security/keys/proc.c')
-rw-r--r-- | security/keys/proc.c | 31 |
1 files changed, 19 insertions, 12 deletions
diff --git a/security/keys/proc.c b/security/keys/proc.c index de834309d100..6d1fcbba1e09 100644 --- a/security/keys/proc.c +++ b/security/keys/proc.c | |||
@@ -179,9 +179,12 @@ static int proc_keys_show(struct seq_file *m, void *v) | |||
179 | struct rb_node *_p = v; | 179 | struct rb_node *_p = v; |
180 | struct key *key = rb_entry(_p, struct key, serial_node); | 180 | struct key *key = rb_entry(_p, struct key, serial_node); |
181 | struct timespec now; | 181 | struct timespec now; |
182 | time_t expiry; | ||
182 | unsigned long timo; | 183 | unsigned long timo; |
184 | unsigned long flags; | ||
183 | key_ref_t key_ref, skey_ref; | 185 | key_ref_t key_ref, skey_ref; |
184 | char xbuf[16]; | 186 | char xbuf[16]; |
187 | short state; | ||
185 | int rc; | 188 | int rc; |
186 | 189 | ||
187 | struct keyring_search_context ctx = { | 190 | struct keyring_search_context ctx = { |
@@ -217,12 +220,13 @@ static int proc_keys_show(struct seq_file *m, void *v) | |||
217 | rcu_read_lock(); | 220 | rcu_read_lock(); |
218 | 221 | ||
219 | /* come up with a suitable timeout value */ | 222 | /* come up with a suitable timeout value */ |
220 | if (key->expiry == 0) { | 223 | expiry = READ_ONCE(key->expiry); |
224 | if (expiry == 0) { | ||
221 | memcpy(xbuf, "perm", 5); | 225 | memcpy(xbuf, "perm", 5); |
222 | } else if (now.tv_sec >= key->expiry) { | 226 | } else if (now.tv_sec >= expiry) { |
223 | memcpy(xbuf, "expd", 5); | 227 | memcpy(xbuf, "expd", 5); |
224 | } else { | 228 | } else { |
225 | timo = key->expiry - now.tv_sec; | 229 | timo = expiry - now.tv_sec; |
226 | 230 | ||
227 | if (timo < 60) | 231 | if (timo < 60) |
228 | sprintf(xbuf, "%lus", timo); | 232 | sprintf(xbuf, "%lus", timo); |
@@ -236,18 +240,21 @@ static int proc_keys_show(struct seq_file *m, void *v) | |||
236 | sprintf(xbuf, "%luw", timo / (60*60*24*7)); | 240 | sprintf(xbuf, "%luw", timo / (60*60*24*7)); |
237 | } | 241 | } |
238 | 242 | ||
239 | #define showflag(KEY, LETTER, FLAG) \ | 243 | state = key_read_state(key); |
240 | (test_bit(FLAG, &(KEY)->flags) ? LETTER : '-') | ||
241 | 244 | ||
245 | #define showflag(FLAGS, LETTER, FLAG) \ | ||
246 | ((FLAGS & (1 << FLAG)) ? LETTER : '-') | ||
247 | |||
248 | flags = READ_ONCE(key->flags); | ||
242 | seq_printf(m, "%08x %c%c%c%c%c%c%c %5d %4s %08x %5d %5d %-9.9s ", | 249 | seq_printf(m, "%08x %c%c%c%c%c%c%c %5d %4s %08x %5d %5d %-9.9s ", |
243 | key->serial, | 250 | key->serial, |
244 | showflag(key, 'I', KEY_FLAG_INSTANTIATED), | 251 | state != KEY_IS_UNINSTANTIATED ? 'I' : '-', |
245 | showflag(key, 'R', KEY_FLAG_REVOKED), | 252 | showflag(flags, 'R', KEY_FLAG_REVOKED), |
246 | showflag(key, 'D', KEY_FLAG_DEAD), | 253 | showflag(flags, 'D', KEY_FLAG_DEAD), |
247 | showflag(key, 'Q', KEY_FLAG_IN_QUOTA), | 254 | showflag(flags, 'Q', KEY_FLAG_IN_QUOTA), |
248 | showflag(key, 'U', KEY_FLAG_USER_CONSTRUCT), | 255 | showflag(flags, 'U', KEY_FLAG_USER_CONSTRUCT), |
249 | showflag(key, 'N', KEY_FLAG_NEGATIVE), | 256 | state < 0 ? 'N' : '-', |
250 | showflag(key, 'i', KEY_FLAG_INVALIDATED), | 257 | showflag(flags, 'i', KEY_FLAG_INVALIDATED), |
251 | refcount_read(&key->usage), | 258 | refcount_read(&key->usage), |
252 | xbuf, | 259 | xbuf, |
253 | key->perm, | 260 | key->perm, |