menuconfig: Assign jump keys per-page instead of globally

At the moment, keys 1-9 are assigned to the first 9 search results. This patch
makes them assigned to the first 9 results per-page instead. We are much less
likely to run out of keys that way.

Signed-off-by: Benjamin Poirier <bpoirier@suse.de>
Signed-off-by: Michal Marek <mmarek@suse.cz>

6 files changed, 149 insertions, 73 deletions

diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h
index 52f4246bd34d..bd2e09895553 100644
--- a/scripts/kconfig/expr.h
+++ b/scripts/kconfig/expr.h
@@ -12,6 +12,7 @@ extern "C" {
 
 #include <assert.h>
 #include <stdio.h>
+#include <sys/queue.h>
 #ifndef __cplusplus
 #include <stdbool.h>
 #endif
@@ -173,6 +174,14 @@ struct menu {
 #define MENU_CHANGED            0x0001
 #define MENU_ROOT               0x0002
 
+struct jump_key {
+        CIRCLEQ_ENTRY(jump_key) entries;
+        size_t offset;
+        struct menu *target;
+        int index;
+};
+CIRCLEQ_HEAD(jk_head, jump_key);
+
 #define JUMP_NB                 9
 
 extern struct file *file_list;
diff --git a/scripts/kconfig/lkc_proto.h b/scripts/kconfig/lkc_proto.h
index 946c2cb367f9..1d1c08537f1e 100644
--- a/scripts/kconfig/lkc_proto.h
+++ b/scripts/kconfig/lkc_proto.h
@@ -21,10 +21,10 @@ P(menu_get_root_menu,struct menu *,(struct menu *menu));
 P(menu_get_parent_menu,struct menu *,(struct menu *menu));
 P(menu_has_help,bool,(struct menu *menu));
 P(menu_get_help,const char *,(struct menu *menu));
-P(get_symbol_str, int, (struct gstr *r, struct symbol *sym, struct menu
-                        **jumps, int jump_nb));
-P(get_relations_str, struct gstr, (struct symbol **sym_arr, struct menu
-                                   **jumps));
+P(get_symbol_str, void, (struct gstr *r, struct symbol *sym, struct jk_head
+                         *head));
+P(get_relations_str, struct gstr, (struct symbol **sym_arr, struct jk_head
+                                   *head));
 P(menu_get_ext_help,void,(struct menu *menu, struct gstr *help));
 
 /* symbol.c */
diff --git a/scripts/kconfig/lxdialog/dialog.h b/scripts/kconfig/lxdialog/dialog.h
index 2a01cdfae5a8..ee17a5264d5b 100644
--- a/scripts/kconfig/lxdialog/dialog.h
+++ b/scripts/kconfig/lxdialog/dialog.h
@@ -210,8 +210,13 @@ int first_alpha(const char *string, const char *exempt);
 int dialog_yesno(const char *title, const char *prompt, int height, int width);
 int dialog_msgbox(const char *title, const char *prompt, int height,
                   int width, int pause);
-int dialog_textbox(const char *title, const char *file, int height, int width,
-                   int *keys, int *_vscroll, int *_hscroll);
+
+
+typedef void (*update_text_fn)(char *buf, size_t start, size_t end, void
+                               *_data);
+int dialog_textbox(const char *title, char *tbuf, int initial_height,
+                   int initial_width, int *keys, int *_vscroll, int *_hscroll,
+                   update_text_fn update_text, void *data);
 int dialog_menu(const char *title, const char *prompt,
                 const void *selected, int *s_scroll);
 int dialog_checklist(const char *title, const char *prompt, int height,
diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
index 3b3c5c470bf8..a48bb93e0907 100644
--- a/scripts/kconfig/lxdialog/textbox.c
+++ b/scripts/kconfig/lxdialog/textbox.c
@@ -22,23 +22,25 @@
 #include "dialog.h"
 
 static void back_lines(int n);
-static void print_page(WINDOW * win, int height, int width);
-static void print_line(WINDOW * win, int row, int width);
+static void print_page(WINDOW *win, int height, int width, update_text_fn
+                       update_text, void *data);
+static void print_line(WINDOW *win, int row, int width);
 static char *get_line(void);
 static void print_position(WINDOW * win);
 
 static int hscroll;
 static int begin_reached, end_reached, page_length;
-static const char *buf;
-static const char *page;
+static char *buf;
+static char *page;
 
 /*
  * refresh window content
  */
 static void refresh_text_box(WINDOW *dialog, WINDOW *box, int boxh, int boxw,
-                                                          int cur_y, int cur_x)
+                             int cur_y, int cur_x, update_text_fn update_text,
+                             void *data)
 {
-        print_page(box, boxh, boxw);
+        print_page(box, boxh, boxw, update_text, data);
         print_position(dialog);
         wmove(dialog, cur_y, cur_x);    /* Restore cursor position */
         wrefresh(dialog);
@@ -49,9 +51,11 @@ static void refresh_text_box(WINDOW *dialog, WINDOW *box, int boxh, int boxw,
  * Display text from a file in a dialog box.
  *
  * keys is a null-terminated array
+ * update_text() may not add or remove any '\n' or '\0' in tbuf
  */
-int dialog_textbox(const char *title, const char *tbuf, int initial_height,
-                   int initial_width, int *keys, int *_vscroll, int *_hscroll)
+int dialog_textbox(const char *title, char *tbuf, int initial_height,
+                   int initial_width, int *keys, int *_vscroll, int *_hscroll,
+                   update_text_fn update_text, void *data)
 {
         int i, x, y, cur_x, cur_y, key = 0;
         int height, width, boxh, boxw;
@@ -131,7 +135,8 @@ do_resize:
 
         /* Print first page of text */
         attr_clear(box, boxh, boxw, dlg.dialog.atr);
-        refresh_text_box(dialog, box, boxh, boxw, cur_y, cur_x);
+        refresh_text_box(dialog, box, boxh, boxw, cur_y, cur_x, update_text,
+                         data);
 
         while (!done) {
                 key = wgetch(dialog);
@@ -150,7 +155,8 @@ do_resize:
                                 begin_reached = 1;
                                 page = buf;
                                 refresh_text_box(dialog, box, boxh, boxw,
-                                                 cur_y, cur_x);
+                                                 cur_y, cur_x, update_text,
+                                                 data);
                         }
                         break;
                 case 'G':       /* Last page */
@@ -160,8 +166,8 @@ do_resize:
                         /* point to last char in buf */
                         page = buf + strlen(buf);
                         back_lines(boxh);
-                        refresh_text_box(dialog, box, boxh, boxw,
-                                         cur_y, cur_x);
+                        refresh_text_box(dialog, box, boxh, boxw, cur_y,
+                                         cur_x, update_text, data);
                         break;
                 case 'K':       /* Previous line */
                 case 'k':
@@ -171,7 +177,7 @@ do_resize:
 
                         back_lines(page_length + 1);
                         refresh_text_box(dialog, box, boxh, boxw, cur_y,
-                                         cur_x);
+                                         cur_x, update_text, data);
                         break;
                 case 'B':       /* Previous page */
                 case 'b':
@@ -180,8 +186,8 @@ do_resize:
                         if (begin_reached)
                                 break;
                         back_lines(page_length + boxh);
-                        refresh_text_box(dialog, box, boxh, boxw,
-                                         cur_y, cur_x);
+                        refresh_text_box(dialog, box, boxh, boxw, cur_y,
+                                         cur_x, update_text, data);
                         break;
                 case 'J':       /* Next line */
                 case 'j':
@@ -191,7 +197,7 @@ do_resize: