diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-08-05 05:27:13 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2014-08-05 05:27:13 -0400 |
commit | 7109561524dc57b95fd3f9b61547268b9b6db8ed (patch) | |
tree | df08f565b2c616b7e68fe35cd428a8c5ba3bfcb1 /scripts | |
parent | 6bf755db4d5e7ccea61fb17727a183b9bd8945b1 (diff) | |
parent | 3bb70de692f70861f5c5729cd2b870d0104a7cc9 (diff) |
Merge branches 'fixes' and 'misc' into for-next
Conflicts:
arch/arm/kernel/iwmmxt.S
arch/arm/mm/cache-l2x0.c
arch/arm/mm/mmu.c
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/checkpatch.pl | 15 | ||||
-rw-r--r-- | scripts/recordmcount.h | 4 |
2 files changed, 12 insertions, 7 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 010b18ef4ea0..182be0f12407 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
@@ -3476,12 +3476,17 @@ sub process { | |||
3476 | } | 3476 | } |
3477 | } | 3477 | } |
3478 | 3478 | ||
3479 | # unnecessary return in a void function? (a single leading tab, then return;) | 3479 | # unnecessary return in a void function |
3480 | if ($sline =~ /^\+\treturn\s*;\s*$/ && | 3480 | # at end-of-function, with the previous line a single leading tab, then return; |
3481 | $prevline =~ /^\+/) { | 3481 | # and the line before that not a goto label target like "out:" |
3482 | if ($sline =~ /^[ \+]}\s*$/ && | ||
3483 | $prevline =~ /^\+\treturn\s*;\s*$/ && | ||
3484 | $linenr >= 3 && | ||
3485 | $lines[$linenr - 3] =~ /^[ +]/ && | ||
3486 | $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) { | ||
3482 | WARN("RETURN_VOID", | 3487 | WARN("RETURN_VOID", |
3483 | "void function return statements are not generally useful\n" . $herecurr); | 3488 | "void function return statements are not generally useful\n" . $hereprev); |
3484 | } | 3489 | } |
3485 | 3490 | ||
3486 | # if statements using unnecessary parentheses - ie: if ((foo == bar)) | 3491 | # if statements using unnecessary parentheses - ie: if ((foo == bar)) |
3487 | if ($^V && $^V ge 5.10.0 && | 3492 | if ($^V && $^V ge 5.10.0 && |
diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h index 9d1421e63ff8..49b582a225b0 100644 --- a/scripts/recordmcount.h +++ b/scripts/recordmcount.h | |||
@@ -163,11 +163,11 @@ static int mcount_adjust = 0; | |||
163 | 163 | ||
164 | static int MIPS_is_fake_mcount(Elf_Rel const *rp) | 164 | static int MIPS_is_fake_mcount(Elf_Rel const *rp) |
165 | { | 165 | { |
166 | static Elf_Addr old_r_offset; | 166 | static Elf_Addr old_r_offset = ~(Elf_Addr)0; |
167 | Elf_Addr current_r_offset = _w(rp->r_offset); | 167 | Elf_Addr current_r_offset = _w(rp->r_offset); |
168 | int is_fake; | 168 | int is_fake; |
169 | 169 | ||
170 | is_fake = old_r_offset && | 170 | is_fake = (old_r_offset != ~(Elf_Addr)0) && |
171 | (current_r_offset - old_r_offset == MIPS_FAKEMCOUNT_OFFSET); | 171 | (current_r_offset - old_r_offset == MIPS_FAKEMCOUNT_OFFSET); |
172 | old_r_offset = current_r_offset; | 172 | old_r_offset = current_r_offset; |
173 | 173 | ||