diff options
| author | Andreas Brauchli <a.brauchli@elementarea.net> | 2018-02-06 18:38:45 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2018-02-06 21:32:45 -0500 |
| commit | 2e4bbbc550be336cbb3defc67430fc0700aa1426 (patch) | |
| tree | 05e556e547b6bcb68948333427449fc46123dd5f /scripts | |
| parent | 92fc7cb8ae4d021cf7740e4ad0ced9fa9e07dae0 (diff) | |
checkpatch: allow long lines containing URL
Allow lines with URL to exceed the 80 char limit for improved interaction
in adaption to ongoing but undocumented practice.
$ git grep -E '://\S{77}.*' -- '*.[ch]'
As per RFC3986 [1], the URL format allows for alphanum, +, - and .
characters in the scheme before the separator :// as long as it starts
with a letter (e.g. https, git, f.-+).
Recognition of URIs without more context information is prone to false
positives and thus currently left out of the heuristics.
$rawline is used in the check as comments are removed from $line.
[1] https://tools.ietf.org/html/rfc3986#section-3.1
Link: http://lkml.kernel.org/r/1511355432.12667.15.camel@elementarea.net
Signed-off-by: Andreas Brauchli <andreas.brauchli@sensirion.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/checkpatch.pl | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e954df2b2077..4306b7616cdd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl | |||
| @@ -2875,6 +2875,7 @@ sub process { | |||
| 2875 | # logging functions like pr_info that end in a string | 2875 | # logging functions like pr_info that end in a string |
| 2876 | # lines with a single string | 2876 | # lines with a single string |
| 2877 | # #defines that are a single string | 2877 | # #defines that are a single string |
| 2878 | # lines with an RFC3986 like URL | ||
| 2878 | # | 2879 | # |
| 2879 | # There are 3 different line length message types: | 2880 | # There are 3 different line length message types: |
| 2880 | # LONG_LINE_COMMENT a comment starts before but extends beyond $max_line_length | 2881 | # LONG_LINE_COMMENT a comment starts before but extends beyond $max_line_length |
| @@ -2906,6 +2907,10 @@ sub process { | |||
| 2906 | $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) { | 2907 | $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) { |
| 2907 | $msg_type = ""; | 2908 | $msg_type = ""; |
| 2908 | 2909 | ||
| 2910 | # URL ($rawline is used in case the URL is in a comment) | ||
| 2911 | } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\-]*:\/\/\S+/i) { | ||
| 2912 | $msg_type = ""; | ||
| 2913 | |||
| 2909 | # Otherwise set the alternate message types | 2914 | # Otherwise set the alternate message types |
| 2910 | 2915 | ||
| 2911 | # a comment starts before $max_line_length | 2916 | # a comment starts before $max_line_length |
