aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/mod/file2alias.c
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2017-10-22 14:42:29 -0400
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2017-10-22 15:49:59 -0400
commit09c3e01b255fe89eb1f1b7ded68b1b7d55e6d02b (patch)
tree1b088b8fe9b3b4550edd71ccea2e601cbf07263a /scripts/mod/file2alias.c
parentea04efee7635c9120d015dcdeeeb6988130cb67a (diff)
Input: do not use property bits when generating module alias
The commit 8724ecb07229 ("Input: allow matching device IDs on property bits") started using property bits when generating module aliases for input handlers, but did not adjust the generation of MODALIAS attribute on input device uevents, breaking automatic module loading. Given that no handler currently uses property bits in their module tables, let's revert this part of the commit for now. Reported-by: Damien Wyart <damien.wyart@gmail.com> Tested-by: Damien Wyart <damien.wyart@gmail.com> Fixes: 8724ecb07229 ("Input: allow matching device IDs on property bits") Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'scripts/mod/file2alias.c')
-rw-r--r--scripts/mod/file2alias.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
index bc25898f6df0..29d6699d5a06 100644
--- a/scripts/mod/file2alias.c
+++ b/scripts/mod/file2alias.c
@@ -761,7 +761,7 @@ static void do_input(char *alias,
761 sprintf(alias + strlen(alias), "%X,*", i); 761 sprintf(alias + strlen(alias), "%X,*", i);
762} 762}
763 763
764/* input:b0v0p0e0-eXkXrXaXmXlXsXfXwXprX where X is comma-separated %02X. */ 764/* input:b0v0p0e0-eXkXrXaXmXlXsXfXwX where X is comma-separated %02X. */
765static int do_input_entry(const char *filename, void *symval, 765static int do_input_entry(const char *filename, void *symval,
766 char *alias) 766 char *alias)
767{ 767{
@@ -779,7 +779,6 @@ static int do_input_entry(const char *filename, void *symval,
779 DEF_FIELD_ADDR(symval, input_device_id, sndbit); 779 DEF_FIELD_ADDR(symval, input_device_id, sndbit);
780 DEF_FIELD_ADDR(symval, input_device_id, ffbit); 780 DEF_FIELD_ADDR(symval, input_device_id, ffbit);
781 DEF_FIELD_ADDR(symval, input_device_id, swbit); 781 DEF_FIELD_ADDR(symval, input_device_id, swbit);
782 DEF_FIELD_ADDR(symval, input_device_id, propbit);
783 782
784 sprintf(alias, "input:"); 783 sprintf(alias, "input:");
785 784
@@ -817,9 +816,6 @@ static int do_input_entry(const char *filename, void *symval,
817 sprintf(alias + strlen(alias), "w*"); 816 sprintf(alias + strlen(alias), "w*");
818 if (flags & INPUT_DEVICE_ID_MATCH_SWBIT) 817 if (flags & INPUT_DEVICE_ID_MATCH_SWBIT)
819 do_input(alias, *swbit, 0, INPUT_DEVICE_ID_SW_MAX); 818 do_input(alias, *swbit, 0, INPUT_DEVICE_ID_SW_MAX);
820 sprintf(alias + strlen(alias), "pr*");
821 if (flags & INPUT_DEVICE_ID_MATCH_PROPBIT)
822 do_input(alias, *propbit, 0, INPUT_DEVICE_ID_PROP_MAX);
823 return 1; 819 return 1;
824} 820}
825ADD_TO_DEVTABLE("input", input_device_id, do_input_entry); 821ADD_TO_DEVTABLE("input", input_device_id, do_input_entry);