diff options
author | Stephen Boyd <swboyd@chromium.org> | 2019-05-14 18:46:02 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-05-14 22:52:52 -0400 |
commit | 494dbe02b6df0bd98f7353c21e0b9849a25d2dce (patch) | |
tree | ae4884ba977d2198b62837b5b1b7f5fbd9c8879a /scripts/gdb/linux | |
parent | 442284a89a65965b044df00345c193fcc3c53ad2 (diff) |
scripts/gdb: silence pep8 checks
These scripts have some pep8 style warnings. Fix them up so that this
directory is all pep8 clean.
Link: http://lkml.kernel.org/r/20190329220844.38234-6-swboyd@chromium.org
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Nikolay Borisov <n.borisov.lkml@gmail.com>
Cc: Kieran Bingham <kbingham@kernel.org>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Jackie Liu <liuyun01@kylinos.cn>
Cc: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/gdb/linux')
-rw-r--r-- | scripts/gdb/linux/cpus.py | 1 | ||||
-rw-r--r-- | scripts/gdb/linux/lists.py | 1 | ||||
-rw-r--r-- | scripts/gdb/linux/proc.py | 10 | ||||
-rw-r--r-- | scripts/gdb/linux/tasks.py | 2 | ||||
-rw-r--r-- | scripts/gdb/linux/utils.py | 7 |
5 files changed, 16 insertions, 5 deletions
diff --git a/scripts/gdb/linux/cpus.py b/scripts/gdb/linux/cpus.py index ca11e8df31b6..008e62f3190d 100644 --- a/scripts/gdb/linux/cpus.py +++ b/scripts/gdb/linux/cpus.py | |||
@@ -135,6 +135,7 @@ and can help identify the state of hotplugged CPUs""" | |||
135 | gdb.write("Online CPUs : {}\n".format(list(each_online_cpu()))) | 135 | gdb.write("Online CPUs : {}\n".format(list(each_online_cpu()))) |
136 | gdb.write("Active CPUs : {}\n".format(list(each_active_cpu()))) | 136 | gdb.write("Active CPUs : {}\n".format(list(each_active_cpu()))) |
137 | 137 | ||
138 | |||
138 | LxCpus() | 139 | LxCpus() |
139 | 140 | ||
140 | 141 | ||
diff --git a/scripts/gdb/linux/lists.py b/scripts/gdb/linux/lists.py index 2f335fbd86fd..1987d756b36b 100644 --- a/scripts/gdb/linux/lists.py +++ b/scripts/gdb/linux/lists.py | |||
@@ -110,4 +110,5 @@ class LxListChk(gdb.Command): | |||
110 | raise gdb.GdbError("lx-list-check takes one argument") | 110 | raise gdb.GdbError("lx-list-check takes one argument") |
111 | list_check(gdb.parse_and_eval(argv[0])) | 111 | list_check(gdb.parse_and_eval(argv[0])) |
112 | 112 | ||
113 | |||
113 | LxListChk() | 114 | LxListChk() |
diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py index 2f01a958eb22..6a56bba233a9 100644 --- a/scripts/gdb/linux/proc.py +++ b/scripts/gdb/linux/proc.py | |||
@@ -29,6 +29,7 @@ class LxCmdLine(gdb.Command): | |||
29 | def invoke(self, arg, from_tty): | 29 | def invoke(self, arg, from_tty): |
30 | gdb.write(gdb.parse_and_eval("saved_command_line").string() + "\n") | 30 | gdb.write(gdb.parse_and_eval("saved_command_line").string() + "\n") |
31 | 31 | ||
32 | |||
32 | LxCmdLine() | 33 | LxCmdLine() |
33 | 34 | ||
34 | 35 | ||
@@ -43,6 +44,7 @@ class LxVersion(gdb.Command): | |||
43 | # linux_banner should contain a newline | 44 | # linux_banner should contain a newline |
44 | gdb.write(gdb.parse_and_eval("(char *)linux_banner").string()) | 45 | gdb.write(gdb.parse_and_eval("(char *)linux_banner").string()) |
45 | 46 | ||
47 | |||
46 | LxVersion() | 48 | LxVersion() |
47 | 49 | ||
48 | 50 | ||
@@ -86,6 +88,7 @@ Equivalent to cat /proc/iomem on a running target""" | |||
86 | def invoke(self, arg, from_tty): | 88 | def invoke(self, arg, from_tty): |
87 | return show_lx_resources("iomem_resource") | 89 | return show_lx_resources("iomem_resource") |
88 | 90 | ||
91 | |||
89 | LxIOMem() | 92 | LxIOMem() |
90 | 93 | ||
91 | 94 | ||
@@ -100,6 +103,7 @@ Equivalent to cat /proc/ioports on a running target""" | |||
100 | def invoke(self, arg, from_tty): | 103 | def invoke(self, arg, from_tty): |
101 | return show_lx_resources("ioport_resource") | 104 | return show_lx_resources("ioport_resource") |
102 | 105 | ||
106 | |||
103 | LxIOPorts() | 107 | LxIOPorts() |
104 | 108 | ||
105 | 109 | ||
@@ -149,7 +153,7 @@ values of that process namespace""" | |||
149 | if len(argv) >= 1: | 153 | if len(argv) >= 1: |
150 | try: | 154 | try: |
151 | pid = int(argv[0]) | 155 | pid = int(argv[0]) |
152 | except: | 156 | except gdb.error: |
153 | raise gdb.GdbError("Provide a PID as integer value") | 157 | raise gdb.GdbError("Provide a PID as integer value") |
154 | else: | 158 | else: |
155 | pid = 1 | 159 | pid = 1 |
@@ -195,6 +199,7 @@ values of that process namespace""" | |||
195 | info_opts(FS_INFO, s_flags), | 199 | info_opts(FS_INFO, s_flags), |
196 | info_opts(MNT_INFO, m_flags))) | 200 | info_opts(MNT_INFO, m_flags))) |
197 | 201 | ||
202 | |||
198 | LxMounts() | 203 | LxMounts() |
199 | 204 | ||
200 | 205 | ||
@@ -259,7 +264,7 @@ class LxFdtDump(gdb.Command): | |||
259 | 264 | ||
260 | try: | 265 | try: |
261 | f = open(filename, 'wb') | 266 | f = open(filename, 'wb') |
262 | except: | 267 | except gdb.error: |
263 | raise gdb.GdbError("Could not open file to dump fdt") | 268 | raise gdb.GdbError("Could not open file to dump fdt") |
264 | 269 | ||
265 | f.write(fdt_buf) | 270 | f.write(fdt_buf) |
@@ -267,4 +272,5 @@ class LxFdtDump(gdb.Command): | |||
267 | 272 | ||
268 | gdb.write("Dumped fdt blob to " + filename + "\n") | 273 | gdb.write("Dumped fdt blob to " + filename + "\n") |
269 | 274 | ||
275 | |||
270 | LxFdtDump() | 276 | LxFdtDump() |
diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py index f6ab3ccf698f..0301dc1e0138 100644 --- a/scripts/gdb/linux/tasks.py +++ b/scripts/gdb/linux/tasks.py | |||
@@ -79,6 +79,7 @@ class LxPs(gdb.Command): | |||
79 | pid=task["pid"], | 79 | pid=task["pid"], |
80 | comm=task["comm"].string())) | 80 | comm=task["comm"].string())) |
81 | 81 | ||
82 | |||
82 | LxPs() | 83 | LxPs() |
83 | 84 | ||
84 | 85 | ||
@@ -134,4 +135,5 @@ variable.""" | |||
134 | else: | 135 | else: |
135 | raise gdb.GdbError("No task of PID " + str(pid)) | 136 | raise gdb.GdbError("No task of PID " + str(pid)) |
136 | 137 | ||
138 | |||
137 | LxThreadInfoByPidFunc() | 139 | LxThreadInfoByPidFunc() |
diff --git a/scripts/gdb/linux/utils.py b/scripts/gdb/linux/utils.py index 50805874cfc3..bc67126118c4 100644 --- a/scripts/gdb/linux/utils.py +++ b/scripts/gdb/linux/utils.py | |||
@@ -66,6 +66,7 @@ Note that TYPE and ELEMENT have to be quoted as strings.""" | |||
66 | return container_of(ptr, gdb.lookup_type(typename.string()).pointer(), | 66 | return container_of(ptr, gdb.lookup_type(typename.string()).pointer(), |
67 | elementname.string()) | 67 | elementname.string()) |
68 | 68 | ||
69 | |||
69 | ContainerOf() | 70 | ContainerOf() |
70 | 71 | ||
71 | 72 | ||
@@ -148,14 +149,14 @@ def get_gdbserver_type(): | |||
148 | def probe_qemu(): | 149 | def probe_qemu(): |
149 | try: | 150 | try: |
150 | return gdb.execute("monitor info version", to_string=True) != "" | 151 | return gdb.execute("monitor info version", to_string=True) != "" |
151 | except: | 152 | except gdb.error: |
152 | return False | 153 | return False |
153 | 154 | ||
154 | def probe_kgdb(): | 155 | def probe_kgdb(): |
155 | try: | 156 | try: |
156 | thread_info = gdb.execute("info thread 2", to_string=True) | 157 | thread_info = gdb.execute("info thread 2", to_string=True) |
157 | return "shadowCPU0" in thread_info | 158 | return "shadowCPU0" in thread_info |
158 | except: | 159 | except gdb.error: |
159 | return False | 160 | return False |
160 | 161 | ||
161 | global gdbserver_type | 162 | global gdbserver_type |
@@ -172,7 +173,7 @@ def get_gdbserver_type(): | |||
172 | def gdb_eval_or_none(expresssion): | 173 | def gdb_eval_or_none(expresssion): |
173 | try: | 174 | try: |
174 | return gdb.parse_and_eval(expresssion) | 175 | return gdb.parse_and_eval(expresssion) |
175 | except: | 176 | except gdb.error: |
176 | return None | 177 | return None |
177 | 178 | ||
178 | 179 | ||