checkpatch: improve the STORAGE_CLASS test

Make sure static, extern, and asmlinkage appear before a specific type.

e.g.:
	int asmlinkage foo(void)
is better written
       asmlinkage int foo(void)

Link: http://lkml.kernel.org/r/31704c96df2d5fd9df0b41165940a7a4feb16a63.1499284835.git.joe@perches.com
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 10 insertions, 2 deletions

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 8f940c09918f..2287a0bca863 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5576,10 +5576,18 @@ sub process {
                             "architecture specific defines should be avoided\n" .  $herecurr);
                 }
 
+# check that the storage class is not after a type
+                if ($line =~ /\b($Type)\s+($Storage)\b/) {
+                        WARN("STORAGE_CLASS",
+                             "storage class '$2' should be located before type '$1'\n" . $herecurr);
+                }
 # Check that the storage class is at the beginning of a declaration
-                if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
+                if ($line =~ /\b$Storage\b/ &&
+                    $line !~ /^.\s*$Storage/ &&
+                    $line =~ /^.\s*(.+?)\$Storage\s/ &&
+                    $1 !~ /[\,\)]\s*$/) {
                         WARN("STORAGE_CLASS",
-                             "storage class should be at the beginning of the declaration\n" . $herecurr)
+                             "storage class should be at the beginning of the declaration\n" . $herecurr);
                 }
 
 # check the location of the inline attribute, that it is between