diff options
| author | Huang Shijie <shijie.huang@arm.com> | 2016-08-03 16:46:03 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-08-04 08:50:07 -0400 |
| commit | e708c1488bca54b901c4c3e73462ab2decdb8209 (patch) | |
| tree | c0d455a7338ce1f5e4b7f716db578dbab411e657 /samples | |
| parent | 00085f1efa387a8ce100e3734920f7639c80caa3 (diff) | |
samples/kprobe: convert the printk to pr_info/pr_err
We prefer to use the pr_* to print out the log now, this patch converts
the printk to pr_info. In the error path, use the pr_err to replace the
printk.
Link: http://lkml.kernel.org/r/1464143083-3877-1-git-send-email-shijie.huang@arm.com
Signed-off-by: Huang Shijie <shijie.huang@arm.com>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Steve Capper <steve.capper@arm.com>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'samples')
| -rw-r--r-- | samples/kprobes/kprobe_example.c | 29 |
1 files changed, 12 insertions, 17 deletions
diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c index f3b61b4ee09c..88b3e2d227ae 100644 --- a/samples/kprobes/kprobe_example.c +++ b/samples/kprobes/kprobe_example.c | |||
| @@ -27,23 +27,19 @@ static struct kprobe kp = { | |||
| 27 | static int handler_pre(struct kprobe *p, struct pt_regs *regs) | 27 | static int handler_pre(struct kprobe *p, struct pt_regs *regs) |
| 28 | { | 28 | { |
| 29 | #ifdef CONFIG_X86 | 29 | #ifdef CONFIG_X86 |
| 30 | printk(KERN_INFO "<%s> pre_handler: p->addr = 0x%p, ip = %lx," | 30 | pr_info("<%s> pre_handler: p->addr = 0x%p, ip = %lx, flags = 0x%lx\n", |
| 31 | " flags = 0x%lx\n", | ||
| 32 | p->symbol_name, p->addr, regs->ip, regs->flags); | 31 | p->symbol_name, p->addr, regs->ip, regs->flags); |
| 33 | #endif | 32 | #endif |
| 34 | #ifdef CONFIG_PPC | 33 | #ifdef CONFIG_PPC |
| 35 | printk(KERN_INFO "<%s> pre_handler: p->addr = 0x%p, nip = 0x%lx," | 34 | pr_info("<%s> pre_handler: p->addr = 0x%p, nip = 0x%lx, msr = 0x%lx\n", |
| 36 | " msr = 0x%lx\n", | ||
| 37 | p->symbol_name, p->addr, regs->nip, regs->msr); | 35 | p->symbol_name, p->addr, regs->nip, regs->msr); |
| 38 | #endif | 36 | #endif |
| 39 | #ifdef CONFIG_MIPS | 37 | #ifdef CONFIG_MIPS |
| 40 | printk(KERN_INFO "<%s> pre_handler: p->addr = 0x%p, epc = 0x%lx," | 38 | pr_info("<%s> pre_handler: p->addr = 0x%p, epc = 0x%lx, status = 0x%lx\n", |
| 41 | " status = 0x%lx\n", | ||
| 42 | p->symbol_name, p->addr, regs->cp0_epc, regs->cp0_status); | 39 | p->symbol_name, p->addr, regs->cp0_epc, regs->cp0_status); |
| 43 | #endif | 40 | #endif |
| 44 | #ifdef CONFIG_TILEGX | 41 | #ifdef CONFIG_TILEGX |
| 45 | printk(KERN_INFO "<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx," | 42 | pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, ex1 = 0x%lx\n", |
| 46 | " ex1 = 0x%lx\n", | ||
| 47 | p->symbol_name, p->addr, regs->pc, regs->ex1); | 43 | p->symbol_name, p->addr, regs->pc, regs->ex1); |
| 48 | #endif | 44 | #endif |
| 49 | #ifdef CONFIG_ARM64 | 45 | #ifdef CONFIG_ARM64 |
| @@ -61,19 +57,19 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, | |||
| 61 | unsigned long flags) | 57 | unsigned long flags) |
| 62 | { | 58 | { |
| 63 | #ifdef CONFIG_X86 | 59 | #ifdef CONFIG_X86 |
| 64 | printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, flags = 0x%lx\n", | 60 | pr_info("<%s> post_handler: p->addr = 0x%p, flags = 0x%lx\n", |
| 65 | p->symbol_name, p->addr, regs->flags); | 61 | p->symbol_name, p->addr, regs->flags); |
| 66 | #endif | 62 | #endif |
| 67 | #ifdef CONFIG_PPC | 63 | #ifdef CONFIG_PPC |
| 68 | printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, msr = 0x%lx\n", | 64 | pr_info("<%s> post_handler: p->addr = 0x%p, msr = 0x%lx\n", |
| 69 | p->symbol_name, p->addr, regs->msr); | 65 | p->symbol_name, p->addr, regs->msr); |
| 70 | #endif | 66 | #endif |
| 71 | #ifdef CONFIG_MIPS | 67 | #ifdef CONFIG_MIPS |
| 72 | printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n", | 68 | pr_info("<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n", |
| 73 | p->symbol_name, p->addr, regs->cp0_status); | 69 | p->symbol_name, p->addr, regs->cp0_status); |
| 74 | #endif | 70 | #endif |
| 75 | #ifdef CONFIG_TILEGX | 71 | #ifdef CONFIG_TILEGX |
| 76 | printk(KERN_INFO "<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", | 72 | pr_info("<%s> post_handler: p->addr = 0x%p, ex1 = 0x%lx\n", |
| 77 | p->symbol_name, p->addr, regs->ex1); | 73 | p->symbol_name, p->addr, regs->ex1); |
| 78 | #endif | 74 | #endif |
| 79 | #ifdef CONFIG_ARM64 | 75 | #ifdef CONFIG_ARM64 |
| @@ -89,8 +85,7 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs, | |||
| 89 | */ | 85 | */ |
| 90 | static int handler_fault(struct kprobe *p, struct pt_regs *regs, int trapnr) | 86 | static int handler_fault(struct kprobe *p, struct pt_regs *regs, int trapnr) |
| 91 | { | 87 | { |
| 92 | printk(KERN_INFO "fault_handler: p->addr = 0x%p, trap #%dn", | 88 | pr_info("fault_handler: p->addr = 0x%p, trap #%dn", p->addr, trapnr); |
| 93 | p->addr, trapnr); | ||
| 94 | /* Return 0 because we don't handle the fault. */ | 89 | /* Return 0 because we don't handle the fault. */ |
| 95 | return 0; | 90 | return 0; |
| 96 | } | 91 | } |
| @@ -104,17 +99,17 @@ static int __init kprobe_init(void) | |||
| 104 | 99 | ||
| 105 | ret = register_kprobe(&kp); | 100 | ret = register_kprobe(&kp); |
| 106 | if (ret < 0) { | 101 | if (ret < 0) { |
| 107 | printk(KERN_INFO "register_kprobe failed, returned %d\n", ret); | 102 | pr_err("register_kprobe failed, returned %d\n", ret); |
| 108 | return ret; | 103 | return ret; |
| 109 | } | 104 | } |
| 110 | printk(KERN_INFO "Planted kprobe at %p\n", kp.addr); | 105 | pr_info("Planted kprobe at %p\n", kp.addr); |
| 111 | return 0; | 106 | return 0; |
| 112 | } | 107 | } |
| 113 | 108 | ||
| 114 | static void __exit kprobe_exit(void) | 109 | static void __exit kprobe_exit(void) |
| 115 | { | 110 | { |
| 116 | unregister_kprobe(&kp); | 111 | unregister_kprobe(&kp); |
| 117 | printk(KERN_INFO "kprobe at %p unregistered\n", kp.addr); | 112 | pr_info("kprobe at %p unregistered\n", kp.addr); |
| 118 | } | 113 | } |
| 119 | 114 | ||
| 120 | module_init(kprobe_init) | 115 | module_init(kprobe_init) |
