diff options
author | Viresh Kumar <viresh.kumar@linaro.org> | 2015-08-12 06:29:47 -0400 |
---|---|---|
committer | Jiri Kosina <jkosina@suse.cz> | 2015-09-29 09:15:40 -0400 |
commit | b5ffe634425591db5692fa242da0bbe20d1f76a7 (patch) | |
tree | 20380e2ff1c60c8b980629c5bb728106839e6a00 /net | |
parent | 18e8e5c7a9f9aef1b45e0729dc340989d5a954d0 (diff) |
net: Drop unlikely before IS_ERR(_OR_NULL)
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'net')
-rw-r--r-- | net/openvswitch/datapath.c | 2 | ||||
-rw-r--r-- | net/sctp/socket.c | 2 | ||||
-rw-r--r-- | net/socket.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index ff8c4a4c1609..01d69680ba5d 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c | |||
@@ -1143,7 +1143,7 @@ static int ovs_flow_cmd_set(struct sk_buff *skb, struct genl_info *info) | |||
1143 | info, OVS_FLOW_CMD_NEW, false, | 1143 | info, OVS_FLOW_CMD_NEW, false, |
1144 | ufid_flags); | 1144 | ufid_flags); |
1145 | 1145 | ||
1146 | if (unlikely(IS_ERR(reply))) { | 1146 | if (IS_ERR(reply)) { |
1147 | error = PTR_ERR(reply); | 1147 | error = PTR_ERR(reply); |
1148 | goto err_unlock_ovs; | 1148 | goto err_unlock_ovs; |
1149 | } | 1149 | } |
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 17bef01b9aa3..897c01c029ca 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c | |||
@@ -4475,7 +4475,7 @@ static int sctp_getsockopt_peeloff(struct sock *sk, int len, char __user *optval | |||
4475 | } | 4475 | } |
4476 | 4476 | ||
4477 | newfile = sock_alloc_file(newsock, 0, NULL); | 4477 | newfile = sock_alloc_file(newsock, 0, NULL); |
4478 | if (unlikely(IS_ERR(newfile))) { | 4478 | if (IS_ERR(newfile)) { |
4479 | put_unused_fd(retval); | 4479 | put_unused_fd(retval); |
4480 | sock_release(newsock); | 4480 | sock_release(newsock); |
4481 | return PTR_ERR(newfile); | 4481 | return PTR_ERR(newfile); |
diff --git a/net/socket.c b/net/socket.c index 9963a0b53a64..dd2c247c99e3 100644 --- a/net/socket.c +++ b/net/socket.c | |||
@@ -373,7 +373,7 @@ struct file *sock_alloc_file(struct socket *sock, int flags, const char *dname) | |||
373 | 373 | ||
374 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, | 374 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, |
375 | &socket_file_ops); | 375 | &socket_file_ops); |
376 | if (unlikely(IS_ERR(file))) { | 376 | if (IS_ERR(file)) { |
377 | /* drop dentry, keep inode */ | 377 | /* drop dentry, keep inode */ |
378 | ihold(d_inode(path.dentry)); | 378 | ihold(d_inode(path.dentry)); |
379 | path_put(&path); | 379 | path_put(&path); |
@@ -1303,7 +1303,7 @@ SYSCALL_DEFINE4(socketpair, int, family, int, type, int, protocol, | |||
1303 | } | 1303 | } |
1304 | 1304 | ||
1305 | newfile1 = sock_alloc_file(sock1, flags, NULL); | 1305 | newfile1 = sock_alloc_file(sock1, flags, NULL); |
1306 | if (unlikely(IS_ERR(newfile1))) { | 1306 | if (IS_ERR(newfile1)) { |
1307 | err = PTR_ERR(newfile1); | 1307 | err = PTR_ERR(newfile1); |
1308 | goto out_put_unused_both; | 1308 | goto out_put_unused_both; |
1309 | } | 1309 | } |
@@ -1467,7 +1467,7 @@ SYSCALL_DEFINE4(accept4, int, fd, struct sockaddr __user *, upeer_sockaddr, | |||
1467 | goto out_put; | 1467 | goto out_put; |
1468 | } | 1468 | } |
1469 | newfile = sock_alloc_file(newsock, flags, sock->sk->sk_prot_creator->name); | 1469 | newfile = sock_alloc_file(newsock, flags, sock->sk->sk_prot_creator->name); |
1470 | if (unlikely(IS_ERR(newfile))) { | 1470 | if (IS_ERR(newfile)) { |
1471 | err = PTR_ERR(newfile); | 1471 | err = PTR_ERR(newfile); |
1472 | put_unused_fd(newfd); | 1472 | put_unused_fd(newfd); |
1473 | sock_release(newsock); | 1473 | sock_release(newsock); |