aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorDavid Ahern <dsa@cumulusnetworks.com>2015-09-01 16:26:35 -0400
committerDavid S. Miller <davem@davemloft.net>2015-09-01 17:32:44 -0400
commit9b8ff51822893e743eee09350c1928daa3ef503f (patch)
tree36cee6d6eaaf0e9920593fd363bd373cf56383de /net
parent63b6c13dbb7d3e36f031629f7e4e86dacfcab8cf (diff)
net: Make table id type u32
A number of VRF patches used 'int' for table id. It should be u32 to be consistent with the rest of the stack. Fixes: 4e3c89920cd3a ("net: Introduce VRF related flags and helpers") 15be405eb2ea9 ("net: Add inet_addr lookup by table") 30bbaa1950055 ("net: Fix up inet_addr_type checks") 021dd3b8a142d ("net: Add routes to the table associated with the device") dc028da54ed35 ("inet: Move VRF table lookup to inlined function") f6d3c19274c74 ("net: FIB tracepoints") Signed-off-by: David Ahern <dsa@cumulusnetworks.com> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/af_inet.c2
-rw-r--r--net/ipv4/fib_frontend.c10
-rw-r--r--net/ipv4/fib_semantics.c2
3 files changed, 7 insertions, 7 deletions
diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
index 96773a2f95a7..1d0c3adb6f34 100644
--- a/net/ipv4/af_inet.c
+++ b/net/ipv4/af_inet.c
@@ -428,7 +428,7 @@ int inet_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len)
428 struct net *net = sock_net(sk); 428 struct net *net = sock_net(sk);
429 unsigned short snum; 429 unsigned short snum;
430 int chk_addr_ret; 430 int chk_addr_ret;
431 int tb_id = RT_TABLE_LOCAL; 431 u32 tb_id = RT_TABLE_LOCAL;
432 int err; 432 int err;
433 433
434 /* If the socket has its own bind function then use it. (RAW) */ 434 /* If the socket has its own bind function then use it. (RAW) */
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index 4036c94dfbe1..6fcbd215cdbc 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -213,7 +213,7 @@ void fib_flush_external(struct net *net)
213 */ 213 */
214static inline unsigned int __inet_dev_addr_type(struct net *net, 214static inline unsigned int __inet_dev_addr_type(struct net *net,
215 const struct net_device *dev, 215 const struct net_device *dev,
216 __be32 addr, int tb_id) 216 __be32 addr, u32 tb_id)
217{ 217{
218 struct flowi4 fl4 = { .daddr = addr }; 218 struct flowi4 fl4 = { .daddr = addr };
219 struct fib_result res; 219 struct fib_result res;
@@ -240,7 +240,7 @@ static inline unsigned int __inet_dev_addr_type(struct net *net,
240 return ret; 240 return ret;
241} 241}
242 242
243unsigned int inet_addr_type_table(struct net *net, __be32 addr, int tb_id) 243unsigned int inet_addr_type_table(struct net *net, __be32 addr, u32 tb_id)
244{ 244{
245 return __inet_dev_addr_type(net, NULL, addr, tb_id); 245 return __inet_dev_addr_type(net, NULL, addr, tb_id);
246} 246}
@@ -255,7 +255,7 @@ EXPORT_SYMBOL(inet_addr_type);
255unsigned int inet_dev_addr_type(struct net *net, const struct net_device *dev, 255unsigned int inet_dev_addr_type(struct net *net, const struct net_device *dev,
256 __be32 addr) 256 __be32 addr)
257{ 257{
258 int rt_table = vrf_dev_table(dev) ? : RT_TABLE_LOCAL; 258 u32 rt_table = vrf_dev_table(dev) ? : RT_TABLE_LOCAL;
259 259
260 return __inet_dev_addr_type(net, dev, addr, rt_table); 260 return __inet_dev_addr_type(net, dev, addr, rt_table);
261} 261}
@@ -268,7 +268,7 @@ unsigned int inet_addr_type_dev_table(struct net *net,
268 const struct net_device *dev, 268 const struct net_device *dev,
269 __be32 addr) 269 __be32 addr)
270{ 270{
271 int rt_table = vrf_dev_table(dev) ? : RT_TABLE_LOCAL; 271 u32 rt_table = vrf_dev_table(dev) ? : RT_TABLE_LOCAL;
272 272
273 return __inet_dev_addr_type(net, NULL, addr, rt_table); 273 return __inet_dev_addr_type(net, NULL, addr, rt_table);
274} 274}
@@ -803,7 +803,7 @@ out:
803static void fib_magic(int cmd, int type, __be32 dst, int dst_len, struct in_ifaddr *ifa) 803static void fib_magic(int cmd, int type, __be32 dst, int dst_len, struct in_ifaddr *ifa)
804{ 804{
805 struct net *net = dev_net(ifa->ifa_dev->dev); 805 struct net *net = dev_net(ifa->ifa_dev->dev);
806 int tb_id = vrf_dev_table_rtnl(ifa->ifa_dev->dev); 806 u32 tb_id = vrf_dev_table_rtnl(ifa->ifa_dev->dev);
807 struct fib_table *tb; 807 struct fib_table *tb;
808 struct fib_config cfg = { 808 struct fib_config cfg = {
809 .fc_protocol = RTPROT_KERNEL, 809 .fc_protocol = RTPROT_KERNEL,
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 992a9597daf8..064bd3caaa4f 100644
--- a/net/ipv4/fib_semantics.c
+++ b/net/ipv4/fib_semantics.c
@@ -863,7 +863,7 @@ static bool fib_valid_prefsrc(struct fib_config *cfg, __be32 fib_prefsrc)
863{ 863{
864 if (cfg->fc_type != RTN_LOCAL || !cfg->fc_dst || 864 if (cfg->fc_type != RTN_LOCAL || !cfg->fc_dst ||
865 fib_prefsrc != cfg->fc_dst) { 865 fib_prefsrc != cfg->fc_dst) {
866 int tb_id = cfg->fc_table; 866 u32 tb_id = cfg->fc_table;
867 867
868 if (tb_id == RT_TABLE_MAIN) 868 if (tb_id == RT_TABLE_MAIN)
869 tb_id = RT_TABLE_LOCAL; 869 tb_id = RT_TABLE_LOCAL;