ipx: call ipxitf_put() in ioctl error path

commit ee0d8d8482345ff97a75a7d747efc309f13b0d80 upstream.

We should call ipxitf_put() if the copy_to_user() fails.

Reported-by: 李强 <liqiang6-s@360.cn>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

1 files changed, 2 insertions, 3 deletions

diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
index 48d0dc89b58d..e735f781e4f3 100644
--- a/net/ipx/af_ipx.c
+++ b/net/ipx/af_ipx.c
@@ -1168,11 +1168,10 @@ static int ipxitf_ioctl(unsigned int cmd, void __user *arg)
                 sipx->sipx_network      = ipxif->if_netnum;
                 memcpy(sipx->sipx_node, ipxif->if_node,
                         sizeof(sipx->sipx_node));
-                rc = -EFAULT;
+                rc = 0;
                 if (copy_to_user(arg, &ifr, sizeof(ifr)))
-                        break;
+                        rc = -EFAULT;
                 ipxitf_put(ipxif);
-                rc = 0;
                 break;
         }
         case SIOCAIPXITFCRT: