diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2015-11-07 16:05:44 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-11-07 16:05:44 -0500 |
commit | 75021d28594d9b6fb4d05bbc41f77948a0db0e02 (patch) | |
tree | bd0939df57e358ef248993b7be4ac1260cb3f3b1 /net | |
parent | 6f1da317ac1df15f442b5fd37be7740c7cb55057 (diff) | |
parent | 8d090f47315507c3064ca4eefa9a1da52390b52e (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
Pull trivial updates from Jiri Kosina:
"Trivial stuff from trivial tree that can be trivially summed up as:
- treewide drop of spurious unlikely() before IS_ERR() from Viresh
Kumar
- cosmetic fixes (that don't really affect basic functionality of the
driver) for pktcdvd and bcache, from Julia Lawall and Petr Mladek
- various comment / printk fixes and updates all over the place"
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial:
bcache: Really show state of work pending bit
hwmon: applesmc: fix comment typos
Kconfig: remove comment about scsi_wait_scan module
class_find_device: fix reference to argument "match"
debugfs: document that debugfs_remove*() accepts NULL and error values
net: Drop unlikely before IS_ERR(_OR_NULL)
mm: Drop unlikely before IS_ERR(_OR_NULL)
fs: Drop unlikely before IS_ERR(_OR_NULL)
drivers: net: Drop unlikely before IS_ERR(_OR_NULL)
drivers: misc: Drop unlikely before IS_ERR(_OR_NULL)
UBI: Update comments to reflect UBI_METAONLY flag
pktcdvd: drop null test before destroy functions
Diffstat (limited to 'net')
-rw-r--r-- | net/openvswitch/datapath.c | 2 | ||||
-rw-r--r-- | net/sctp/socket.c | 2 | ||||
-rw-r--r-- | net/socket.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index 5633172b791a..91a8b004dc51 100644 --- a/net/openvswitch/datapath.c +++ b/net/openvswitch/datapath.c | |||
@@ -1175,7 +1175,7 @@ static int ovs_flow_cmd_set(struct sk_buff *skb, struct genl_info *info) | |||
1175 | info, OVS_FLOW_CMD_NEW, false, | 1175 | info, OVS_FLOW_CMD_NEW, false, |
1176 | ufid_flags); | 1176 | ufid_flags); |
1177 | 1177 | ||
1178 | if (unlikely(IS_ERR(reply))) { | 1178 | if (IS_ERR(reply)) { |
1179 | error = PTR_ERR(reply); | 1179 | error = PTR_ERR(reply); |
1180 | goto err_unlock_ovs; | 1180 | goto err_unlock_ovs; |
1181 | } | 1181 | } |
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 17bef01b9aa3..897c01c029ca 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c | |||
@@ -4475,7 +4475,7 @@ static int sctp_getsockopt_peeloff(struct sock *sk, int len, char __user *optval | |||
4475 | } | 4475 | } |
4476 | 4476 | ||
4477 | newfile = sock_alloc_file(newsock, 0, NULL); | 4477 | newfile = sock_alloc_file(newsock, 0, NULL); |
4478 | if (unlikely(IS_ERR(newfile))) { | 4478 | if (IS_ERR(newfile)) { |
4479 | put_unused_fd(retval); | 4479 | put_unused_fd(retval); |
4480 | sock_release(newsock); | 4480 | sock_release(newsock); |
4481 | return PTR_ERR(newfile); | 4481 | return PTR_ERR(newfile); |
diff --git a/net/socket.c b/net/socket.c index 9963a0b53a64..dd2c247c99e3 100644 --- a/net/socket.c +++ b/net/socket.c | |||
@@ -373,7 +373,7 @@ struct file *sock_alloc_file(struct socket *sock, int flags, const char *dname) | |||
373 | 373 | ||
374 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, | 374 | file = alloc_file(&path, FMODE_READ | FMODE_WRITE, |
375 | &socket_file_ops); | 375 | &socket_file_ops); |
376 | if (unlikely(IS_ERR(file))) { | 376 | if (IS_ERR(file)) { |
377 | /* drop dentry, keep inode */ | 377 | /* drop dentry, keep inode */ |
378 | ihold(d_inode(path.dentry)); | 378 | ihold(d_inode(path.dentry)); |
379 | path_put(&path); | 379 | path_put(&path); |
@@ -1303,7 +1303,7 @@ SYSCALL_DEFINE4(socketpair, int, family, int, type, int, protocol, | |||
1303 | } | 1303 | } |
1304 | 1304 | ||
1305 | newfile1 = sock_alloc_file(sock1, flags, NULL); | 1305 | newfile1 = sock_alloc_file(sock1, flags, NULL); |
1306 | if (unlikely(IS_ERR(newfile1))) { | 1306 | if (IS_ERR(newfile1)) { |
1307 | err = PTR_ERR(newfile1); | 1307 | err = PTR_ERR(newfile1); |
1308 | goto out_put_unused_both; | 1308 | goto out_put_unused_both; |
1309 | } | 1309 | } |
@@ -1467,7 +1467,7 @@ SYSCALL_DEFINE4(accept4, int, fd, struct sockaddr __user *, upeer_sockaddr, | |||
1467 | goto out_put; | 1467 | goto out_put; |
1468 | } | 1468 | } |
1469 | newfile = sock_alloc_file(newsock, flags, sock->sk->sk_prot_creator->name); | 1469 | newfile = sock_alloc_file(newsock, flags, sock->sk->sk_prot_creator->name); |
1470 | if (unlikely(IS_ERR(newfile))) { | 1470 | if (IS_ERR(newfile)) { |
1471 | err = PTR_ERR(newfile); | 1471 | err = PTR_ERR(newfile); |
1472 | put_unused_fd(newfd); | 1472 | put_unused_fd(newfd); |
1473 | sock_release(newsock); | 1473 | sock_release(newsock); |