Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next

Pull networking updates from David Miller:
 "Another merge window, another set of networking changes.  I've heard
  rumblings that the lightweight tunnels infrastructure has been voted
  networking change of the year.  But what do I know?

   1) Add conntrack support to openvswitch, from Joe Stringer.

   2) Initial support for VRF (Virtual Routing and Forwarding), which
      allows the segmentation of routing paths without using multiple
      devices.  There are some semantic kinks to work out still, but
      this is a reasonably strong foundation.  From David Ahern.

   3) Remove spinlock fro act_bpf fast path, from Alexei Starovoitov.

   4) Ignore route nexthops with a link down state in ipv6, just like
      ipv4.  From Andy Gospodarek.

   5) Remove spinlock from fast path of act_gact and act_mirred, from
      Eric Dumazet.

   6) Document the DSA layer, from Florian Fainelli.

   7) Add netconsole support to bcmgenet, systemport, and DSA.  Also
      from Florian Fainelli.

   8) Add Mellanox Switch Driver and core infrastructure, from Jiri
      Pirko.

   9) Add support for "light weight tunnels", which allow for
      encapsulation and decapsulation without bearing the overhead of a
      full blown netdevice.  From Thomas Graf, Jiri Benc, and a cast of
      others.

  10) Add Identifier Locator Addressing support for ipv6, from Tom
      Herbert.

  11) Support fragmented SKBs in iwlwifi, from Johannes Berg.

  12) Allow perf PMUs to be accessed from eBPF programs, from Kaixu Xia.

  13) Add BQL support to 3c59x driver, from Loganaden Velvindron.

  14) Stop using a zero TX queue length to mean that a device shouldn't
      have a qdisc attached, use an explicit flag instead.  From Phil
      Sutter.

  15) Use generic geneve netdevice infrastructure in openvswitch, from
      Pravin B Shelar.

  16) Add infrastructure to avoid re-forwarding a packet in software
      that was already forwarded by a hardware switch.  From Scott
      Feldman.

  17) Allow AF_PACKET fanout function to be implemented in a bpf
      program, from Willem de Bruijn"

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1458 commits)
  netfilter: nf_conntrack: make nf_ct_zone_dflt built-in
  netfilter: nf_dup{4, 6}: fix build error when nf_conntrack disabled
  net: fec: clear receive interrupts before processing a packet
  ipv6: fix exthdrs offload registration in out_rt path
  xen-netback: add support for multicast control
  bgmac: Update fixed_phy_register()
  sock, diag: fix panic in sock_diag_put_filterinfo
  flow_dissector: Use 'const' where possible.
  flow_dissector: Fix function argument ordering dependency
  ixgbe: Resolve "initialized field overwritten" warnings
  ixgbe: Remove bimodal SR-IOV disabling
  ixgbe: Add support for reporting 2.5G link speed
  ixgbe: fix bounds checking in ixgbe_setup_tc for 82598
  ixgbe: support for ethtool set_rxfh
  ixgbe: Avoid needless PHY access on copper phys
  ixgbe: cleanup to use cached mask value
  ixgbe: Remove second instance of lan_id variable
  ixgbe: use kzalloc for allocating one thing
  flow: Move __get_hash_from_flowi{4,6} into flow_dissector.c
  ixgbe: Remove unused PCI bus types
  ...

2 files changed, 17 insertions, 15 deletions

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index 18cead7645be..94af3d065785 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -115,7 +115,8 @@ static void xfrm_policy_put_afinfo(struct xfrm_policy_afinfo *afinfo)
         rcu_read_unlock();
 }
 
-static inline struct dst_entry *__xfrm_dst_lookup(struct net *net, int tos,
+static inline struct dst_entry *__xfrm_dst_lookup(struct net *net,
+                                                  int tos, int oif,
                                                   const xfrm_address_t *saddr,
                                                   const xfrm_address_t *daddr,
                                                   int family)
@@ -127,14 +128,15 @@ static inline struct dst_entry *__xfrm_dst_lookup(struct net *net, int tos,
         if (unlikely(afinfo == NULL))
                 return ERR_PTR(-EAFNOSUPPORT);
 
-        dst = afinfo->dst_lookup(net, tos, saddr, daddr);
+        dst = afinfo->dst_lookup(net, tos, oif, saddr, daddr);
 
         xfrm_policy_put_afinfo(afinfo);
 
         return dst;
 }
 
-static inline struct dst_entry *xfrm_dst_lookup(struct xfrm_state *x, int tos,
+static inline struct dst_entry *xfrm_dst_lookup(struct xfrm_state *x,
+                                                int tos, int oif,
                                                 xfrm_address_t *prev_saddr,
                                                 xfrm_address_t *prev_daddr,
                                                 int family)
@@ -153,7 +155,7 @@ static inline struct dst_entry *xfrm_dst_lookup(struct xfrm_state *x, int tos,
                 daddr = x->coaddr;
         }
 
-        dst = __xfrm_dst_lookup(net, tos, saddr, daddr, family);
+        dst = __xfrm_dst_lookup(net, tos, oif, saddr, daddr, family);
 
         if (!IS_ERR(dst)) {
                 if (prev_saddr != saddr)
@@ -1373,15 +1375,15 @@ int __xfrm_sk_clone_policy(struct sock *sk)
 }
 
 static int
-xfrm_get_saddr(struct net *net, xfrm_address_t *local, xfrm_address_t *remote,
-               unsigned short family)
+xfrm_get_saddr(struct net *net, int oif, xfrm_address_t *local,
+               xfrm_address_t *remote, unsigned short family)
 {
         int err;
         struct xfrm_policy_afinfo *afinfo = xfrm_policy_get_afinfo(family);
 
         if (unlikely(afinfo == NULL))
                 return -EINVAL;
-        err = afinfo->get_saddr(net, local, remote);
+        err = afinfo->get_saddr(net, oif, local, remote);
         xfrm_policy_put_afinfo(afinfo);
         return err;
 }
@@ -1410,7 +1412,9 @@ xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
                         remote = &tmpl->id.daddr;
                         local = &tmpl->saddr;
                         if (xfrm_addr_any(local, tmpl->encap_family)) {
-                                error = xfrm_get_saddr(net, &tmp, remote, tmpl->encap_family);
+                                error = xfrm_get_saddr(net, fl->flowi_oif,
+                                                       &tmp, remote,
+                                                       tmpl->encap_family);
                                 if (error)
                                         goto fail;
                                 local = &tmp;
@@ -1690,8 +1694,8 @@ static struct dst_entry *xfrm_bundle_create(struct xfrm_policy *policy,
 
                 if (xfrm[i]->props.mode != XFRM_MODE_TRANSPORT) {
                         family = xfrm[i]->props.family;
-                        dst = xfrm_dst_lookup(xfrm[i], tos, &saddr, &daddr,
-                                              family);
+                        dst = xfrm_dst_lookup(xfrm[i], tos, fl->flowi_oif,
+                                              &saddr, &daddr, family);
                         err = PTR_ERR(dst);
                         if (IS_ERR(dst))
                                 goto put_states;
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
index bd16c6c7e1e7..a8de9e300200 100644
--- a/net/xfrm/xfrm_user.c
+++ b/net/xfrm/xfrm_user.c
@@ -925,12 +925,10 @@ static int xfrm_dump_sa(struct sk_buff *skb, struct netlink_callback *cb)
                         return err;
 
                 if (attrs[XFRMA_ADDRESS_FILTER]) {
-                        filter = kmalloc(sizeof(*filter), GFP_KERNEL);
+                        filter = kmemdup(nla_data(attrs[XFRMA_ADDRESS_FILTER]),
+                                         sizeof(*filter), GFP_KERNEL);
                         if (filter == NULL)
                                 return -ENOMEM;
-
-                        memcpy(filter, nla_data(attrs[XFRMA_ADDRESS_FILTER]),
-                               sizeof(*filter));
                 }
 
                 if (attrs[XFRMA_PROTO])
@@ -2048,7 +2046,7 @@ static int xfrm_add_pol_expire(struct sk_buff *skb, struct nlmsghdr *nlh,
                 xfrm_audit_policy_delete(xp, 1, true);
         } else {
                 // reset the timers here?
-                WARN(1, "Dont know what to do with soft policy expire\n");
+                WARN(1, "Don't know what to do with soft policy expire\n");
         }
         km_policy_expired(xp, p->dir, up->hard, nlh->nlmsg_pid);