aboutsummaryrefslogtreecommitdiffstats
path: root/net/tls/tls_main.c
diff options
context:
space:
mode:
authorBoris Pismenny <borisp@mellanox.com>2019-02-27 10:38:04 -0500
committerDavid S. Miller <davem@davemloft.net>2019-03-04 01:10:16 -0500
commit7463d3a2db0efea3701aab5eeb310e0d8157aff7 (patch)
tree1fd12490ff9e33b93b9b503c89e2c9cb48c08082 /net/tls/tls_main.c
parent94850257cf0f88b20db7644f28bfedc7d284de15 (diff)
tls: Fix write space handling
TLS device cannot use the sw context. This patch returns the original tls device write space handler and moves the sw/device specific portions to the relevant files. Also, we remove the write_space call for the tls_sw flow, because it handles partial records in its delayed tx work handler. Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance") Signed-off-by: Boris Pismenny <borisp@mellanox.com> Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tls/tls_main.c')
-rw-r--r--net/tls/tls_main.c15
1 files changed, 6 insertions, 9 deletions
diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
index 7e05af75536d..17e8667917aa 100644
--- a/net/tls/tls_main.c
+++ b/net/tls/tls_main.c
@@ -212,7 +212,6 @@ int tls_push_partial_record(struct sock *sk, struct tls_context *ctx,
212static void tls_write_space(struct sock *sk) 212static void tls_write_space(struct sock *sk)
213{ 213{
214 struct tls_context *ctx = tls_get_ctx(sk); 214 struct tls_context *ctx = tls_get_ctx(sk);
215 struct tls_sw_context_tx *tx_ctx = tls_sw_ctx_tx(ctx);
216 215
217 /* If in_tcp_sendpages call lower protocol write space handler 216 /* If in_tcp_sendpages call lower protocol write space handler
218 * to ensure we wake up any waiting operations there. For example 217 * to ensure we wake up any waiting operations there. For example
@@ -223,14 +222,12 @@ static void tls_write_space(struct sock *sk)
223 return; 222 return;
224 } 223 }
225 224
226 /* Schedule the transmission if tx list is ready */ 225#ifdef CONFIG_TLS_DEVICE
227 if (is_tx_ready(tx_ctx) && !sk->sk_write_pending) { 226 if (ctx->tx_conf == TLS_HW)
228 /* Schedule the transmission */ 227 tls_device_write_space(sk, ctx);
229 if (!test_and_set_bit(BIT_TX_SCHEDULED, &tx_ctx->tx_bitmask)) 228 else
230 schedule_delayed_work(&tx_ctx->tx_work.work, 0); 229#endif
231 } 230 tls_sw_write_space(sk, ctx);
232
233 ctx->sk_write_space(sk);
234} 231}
235 232
236static void tls_ctx_free(struct tls_context *ctx) 233static void tls_ctx_free(struct tls_context *ctx)