tipc: fix premature addition of node to lookup table

In commit 5266698661401a ("tipc: let broadcast packet reception
use new link receive function") we introduced a new per-node
broadcast reception link instance. This link is created at the
moment the node itself is created. Unfortunately, the allocation
is done after the node instance has already been added to the node
lookup hash table. This creates a potential race condition, where
arriving broadcast packets are able to find and access the node
before it has been fully initialized, and before the above mentioned
link has been created. The result is occasional crashes in the function
tipc_bcast_rcv(), which is trying to access the not-yet existing link.

We fix this by deferring the addition of the node instance until after
it has been fully initialized in the function tipc_node_create().

Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 6 insertions, 6 deletions

diff --git a/net/tipc/node.c b/net/tipc/node.c
index fa97d9649a28..9d7a16fc5ca4 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -346,12 +346,6 @@ struct tipc_node *tipc_node_create(struct net *net, u32 addr, u16 capabilities)
         skb_queue_head_init(&n->bc_entry.inputq2);
         for (i = 0; i < MAX_BEARERS; i++)
                 spin_lock_init(&n->links[i].lock);
-        hlist_add_head_rcu(&n->hash, &tn->node_htable[tipc_hashfn(addr)]);
-        list_for_each_entry_rcu(temp_node, &tn->node_list, list) {
-                if (n->addr < temp_node->addr)
-                        break;
-        }
-        list_add_tail_rcu(&n->list, &temp_node->list);
         n->state = SELF_DOWN_PEER_LEAVING;
         n->signature = INVALID_NODE_SIG;
         n->active_links[0] = INVALID_BEARER_ID;
@@ -372,6 +366,12 @@ struct tipc_node *tipc_node_create(struct net *net, u32 addr, u16 capabilities)
         tipc_node_get(n);
         setup_timer(&n->timer, tipc_node_timeout, (unsigned long)n);
         n->keepalive_intv = U32_MAX;
+        hlist_add_head_rcu(&n->hash, &tn->node_htable[tipc_hashfn(addr)]);
+        list_for_each_entry_rcu(temp_node, &tn->node_list, list) {
+                if (n->addr < temp_node->addr)
+                        break;
+        }
+        list_add_tail_rcu(&n->list, &temp_node->list);
 exit:
         spin_unlock_bh(&tn->node_list_lock);
         return n;